[jira] Created: (OFBIZ-1206) Bugs in availability checking of rental products

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)
Bugs in availability checking of rental products
------------------------------------------------

                 Key: OFBIZ-1206
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
             Project: OFBiz
          Issue Type: Bug
          Components: ecommerce
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
             Fix For: SVN trunk
         Attachments: 1.patch

Hi all,

I found some bugs in availability checking of rooms, when booking.
You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
Also if the room do not have associated calendar, you can add to cart any quantity you wish.
But later, when creating the order, you will get error, telling you that there is not enough quantity.
Applied first patch fixes these bugs.
Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
I did two separated patches, to make it easier to review(and commit ;)

Regards,
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1206:
---------------------------------

    Attachment: 1.patch

> Bugs in availability checking of rental products
> ------------------------------------------------
>
>                 Key: OFBIZ-1206
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1.patch
>
>
> Hi all,
> I found some bugs in availability checking of rooms, when booking.
> You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
> Also if the room do not have associated calendar, you can add to cart any quantity you wish.
> But later, when creating the order, you will get error, telling you that there is not enough quantity.
> Applied first patch fixes these bugs.
> Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
> Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
> I did two separated patches, to make it easier to review(and commit ;)
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1206:
---------------------------------

    Attachment: 2.patch

> Bugs in availability checking of rental products
> ------------------------------------------------
>
>                 Key: OFBIZ-1206
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1.patch, 2.patch
>
>
> Hi all,
> I found some bugs in availability checking of rooms, when booking.
> You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
> Also if the room do not have associated calendar, you can add to cart any quantity you wish.
> But later, when creating the order, you will get error, telling you that there is not enough quantity.
> Applied first patch fixes these bugs.
> Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
> Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
> I did two separated patches, to make it easier to review(and commit ;)
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker reassigned OFBIZ-1206:
----------------------------------

    Assignee: Hans Bakker

> Bugs in availability checking of rental products
> ------------------------------------------------
>
>                 Key: OFBIZ-1206
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: 1.patch, 2.patch
>
>
> Hi all,
> I found some bugs in availability checking of rooms, when booking.
> You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
> Also if the room do not have associated calendar, you can add to cart any quantity you wish.
> But later, when creating the order, you will get error, telling you that there is not enough quantity.
> Applied first patch fixes these bugs.
> Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
> Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
> I did two separated patches, to make it easier to review(and commit ;)
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1206:
------------------------------------

    Assignee: Bilgin Ibryam  (was: Hans Bakker)

> Bugs in availability checking of rental products
> ------------------------------------------------
>
>                 Key: OFBIZ-1206
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk
>
>         Attachments: 1.patch, 2.patch
>
>
> Hi all,
> I found some bugs in availability checking of rooms, when booking.
> You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
> Also if the room do not have associated calendar, you can add to cart any quantity you wish.
> But later, when creating the order, you will get error, telling you that there is not enough quantity.
> Applied first patch fixes these bugs.
> Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
> Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
> I did two separated patches, to make it easier to review(and commit ;)
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1206) Bugs in availability checking of rental products

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1206.
--------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0

Committed in trunk rev. 635847 and 4.0 rev. 635850

> Bugs in availability checking of rental products
> ------------------------------------------------
>
>                 Key: OFBIZ-1206
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1206
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: 1.patch, 2.patch
>
>
> Hi all,
> I found some bugs in availability checking of rooms, when booking.
> You can add to cart any quantity of a room, if the reservation date interval do not have any previously made reservations.
> Also if the room do not have associated calendar, you can add to cart any quantity you wish.
> But later, when creating the order, you will get error, telling you that there is not enough quantity.
> Applied first patch fixes these bugs.
> Another bug is that if you add the same rental item to cart , you can add it again and again and even with big quantities.
> Availability check is missed when you are adding the same order item to cart. This is fixed in the second patch.
> I did two separated patches, to make it easier to review(and commit ;)
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.