[jira] Created: (OFBIZ-1226) updateReturnHeader broken by createTrackingCodeOrderReturns

[Nicolas Malin (Jira)]

updateReturnHeader broken by createTrackingCodeOrderReturns
-----------------------------------------------------------

                 Key: OFBIZ-1226
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1226
             Project: OFBiz
          Issue Type: Bug
            Reporter: Si Chen


2007-09-05 13:02:52,874 (http-64.151.73.110-443-Processor4) [     ServiceEcaRule.java:140:INFO ] Running Service ECA Service: createTrackingCodeOrderReturns, triggered by rule on Service: updateReturnHeader
2007-09-05 13:02:52,875 (http-64.151.73.110-443-Processor4) [       ModelService.java:377:INFO ] Set default value for parameter: primaryPermission
2007-09-05 13:02:52,908 (http-64.151.73.110-443-Processor4) [            UtilXml.java:246:DEBUG] XML Read 0.031s: file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml
2007-09-05 13:02:52,910 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing.
2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing.
2007-09-05 13:02:52,912 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
2007-09-05 13:02:52,916 (http-64.151.73.110-443-Processor4) [    TransactionUtil.java:294:WARN ]
---- exception report ----------------------------------------------------------
[TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening:
Exception: java.lang.Exception
Message: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]
---- stack trace ---------------------------------------------------------------
java.lang.Exception: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525205 ]

Si Chen commented on OFBIZ-1226:
--------------------------------

It does not appear that the default-value in
<attribute name="primaryPermission" type="String" mode="IN" optional="false" default-value="MARKETING"/>
       
is being respected.

> updateReturnHeader broken by createTrackingCodeOrderReturns
> -----------------------------------------------------------
>
>                 Key: OFBIZ-1226
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1226
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> 2007-09-05 13:02:52,874 (http-64.151.73.110-443-Processor4) [     ServiceEcaRule.java:140:INFO ] Running Service ECA Service: createTrackingCodeOrderReturns, triggered by rule on Service: updateReturnHeader
> 2007-09-05 13:02:52,875 (http-64.151.73.110-443-Processor4) [       ModelService.java:377:INFO ] Set default value for parameter: primaryPermission
> 2007-09-05 13:02:52,908 (http-64.151.73.110-443-Processor4) [            UtilXml.java:246:DEBUG] XML Read 0.031s: file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml
> 2007-09-05 13:02:52,910 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing.
> 2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
> 2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing.
> 2007-09-05 13:02:52,912 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
> 2007-09-05 13:02:52,916 (http-64.151.73.110-443-Processor4) [    TransactionUtil.java:294:WARN ]
> ---- exception report ----------------------------------------------------------
> [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening:
> Exception: java.lang.Exception
> Message: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]
> ---- stack trace ---------------------------------------------------------------
> java.lang.Exception: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-1226.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: David E. Jones

Thanks for reporting this Si. There was an error in funny cases in the service engine for default values that affected this. In SVN rev 573140 I refactored that a bit to simplify the code a lot and fixed the problem. My first attempt at this didn't fix the problem, in SVN rev 573126, but the comments there still apply.

The rule #1 on the committers was broken by the code that exposed this problem, those rules/guidelines are here:

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities

It's important to NOT break existing stuff when you are adding new things. Adding new things that aren't 100% yet is fine in order to collaborate more easily, but breaking existing stuff is something we really want to avoid, especially when you know it breaks stuff.

Onward and upward!

> updateReturnHeader broken by createTrackingCodeOrderReturns
> -----------------------------------------------------------
>
>                 Key: OFBIZ-1226
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1226
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>            Assignee: David E. Jones
>             Fix For: SVN trunk
>
>
> 2007-09-05 13:02:52,874 (http-64.151.73.110-443-Processor4) [     ServiceEcaRule.java:140:INFO ] Running Service ECA Service: createTrackingCodeOrderReturns, triggered by rule on Service: updateReturnHeader
> 2007-09-05 13:02:52,875 (http-64.151.73.110-443-Processor4) [       ModelService.java:377:INFO ] Set default value for parameter: primaryPermission
> 2007-09-05 13:02:52,908 (http-64.151.73.110-443-Processor4) [            UtilXml.java:246:DEBUG] XML Read 0.031s: file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml
> 2007-09-05 13:02:52,910 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [primaryPermission], inserting nothing.
> 2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
> 2007-09-05 13:02:52,911 (http-64.151.73.110-443-Processor4) [FlexibleStringExpander.java:358:WARN ] Could not find value in environment for the name [altPermission], inserting nothing.
> 2007-09-05 13:02:52,912 (http-64.151.73.110-443-Processor4) [                Log.java:97 :INFO ] Checking for _CREATE
> 2007-09-05 13:02:52,916 (http-64.151.73.110-443-Processor4) [    TransactionUtil.java:294:WARN ]
> ---- exception report ----------------------------------------------------------
> [TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening:
> Exception: java.lang.Exception
> Message: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]
> ---- stack trace ---------------------------------------------------------------
> java.lang.Exception: Error in simple-method [Basic Permission check [file:/home/opentaps/trunk/framework/common/script/org/ofbiz/common/permission/CommonPermissionServices.xml#genericBasePermissionCheck]]: ; [Permission primaryPermission parameter missing!]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.