[jira] Created: (OFBIZ-1230) Move common requests to a separate xml file to reduce component's controller.xml file size

[Nicolas Malin (Jira)]

Move common requests to a separate xml file to reduce component's controller.xml file size
------------------------------------------------------------------------------------------

                 Key: OFBIZ-1230
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor


All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1230:
-------------------------------

    Attachment: common_requests.patch

Attached patch contains the common requests.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: common_requests.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526002 ]

Jacques Le Roux commented on OFBIZ-1230:
----------------------------------------

Adrian,

Good idea but there is sill some work, do you sent this 1st patch to validate the idea ? Anyway I vote for.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: common_requests.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526176 ]

Adrian Crum commented on OFBIZ-1230:
------------------------------------

Jacques,

What additional work needs to be done? If the developer community agrees that this is a good idea and the patch gets committed, then I can start updating each component's controller.xml file.

In other words, I need someone with framework commit access to commit this patch, then I can do the rest of the work myself - except for the example and webtools components.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: common_requests.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1230:
-------------------------------

    Attachment: example.patch
                common_requests.patch

Updated patch, plus concept demo in the Example component.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532713 ]

Adrian Crum commented on OFBIZ-1230:
------------------------------------

Bump.

I'd like to work on this during the weekend, if we could get the common_requests.patch file committed.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1230:
--------------------------------------

    Assignee: Jacques Le Roux

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532792 ]

BJ Freeman commented on OFBIZ-1230:
-----------------------------------

seems that including this caused the login to happen for every menu selection.
So the overrided must have a glitch.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532793 ]

BJ Freeman commented on OFBIZ-1230:
-----------------------------------

example shows this
   <include location="component://common/webcommon/includes/common-requests.xml"/>    
should not it be
   <include location="component://common/webcommon/WEB-INFO/common.xml"/>    

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532793 ]

bjfreeman edited comment on OFBIZ-1230 at 10/5/07 4:22 PM:
------------------------------------------------------------

example shows this
   <include location="component://common/webcommon/includes/common-requests.xml"/>    
should not it be
   <include location="component://common/webcommon/WEB-INF/common.xml"/>    


      was (Author: bjfreeman):
    example shows this
   <include location="component://common/webcommon/includes/common-requests.xml"/>    
should not it be
   <include location="component://common/webcommon/WEB-INFO/common.xml"/>    

 

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532801 ]

Adrian Crum commented on OFBIZ-1230:
------------------------------------

I suppose the file could be moved to a new folder. I placed it in an existing folder for simplicity sake. Your suggestion would be better - for consistency.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532816 ]

Jacques Le Roux commented on OFBIZ-1230:
----------------------------------------

Adrian,

Could you please update the patches if needed (cursory comment) ?

Thanks

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1230:
-------------------------------

    Attachment: example.patch
                common_requests.patch

Jacques,

Updated patches attached.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1230:
-------------------------------

    Attachment: common_requests.patch

Improved patch.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1230.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Adrian,

Your patch is in trunk revision: 582509  

Thanks BJ for review and suggestion

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532884 ]

Adrian Crum commented on OFBIZ-1230:
------------------------------------

Jacques,

Thinking about it more, maybe common-requests.xml should be called common-controller.xml.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532885 ]

Adrian Crum commented on OFBIZ-1230:
------------------------------------

Oops, you slipped in there. Thanks Jacques!

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532919 ]

Jacques Le Roux commented on OFBIZ-1230:
----------------------------------------

common-requests.xml is fine to me, actually only request are in common ;o)

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533021 ]

David E. Jones commented on OFBIZ-1230:
---------------------------------------

I agree with Adrian... the name common-requests is funny because the file does have more than just requests, it also has: handlers, pre/postprocessors, view-maps, and can have other misc stuff.

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533042 ]

Jacques Le Roux commented on OFBIZ-1230:
----------------------------------------

Done in revision: 582717  

> Move common requests to a separate xml file to reduce component's controller.xml file size
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1230
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1230
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: common_requests.patch, common_requests.patch, common_requests.patch, common_requests.patch, example.patch, example.patch
>
>
> All (or nearly all) components have a group of similar entries in their controller.xml file. Those similar entries can be moved to a separate xml file to be included in the component's controller.xml file using the <include> element - which would reduce the size of each controller.xml file.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.