[
https://issues.apache.org/jira/browse/OFBIZ-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527479 ]
Bilgin Ibryam commented on OFBIZ-1231:
--------------------------------------
Jonathon,
Thank you for testing and reviewing.
Updating the patch 3 times, i did some error in patch.
Now i fixed the patch :) preferredCurrencyUomIdusId should be preferredCurrencyUomId, i changed it.
I removed the ? from partyIdTo?, now it also work fine.
Here i got a question.
During person creation in party manger, first name and last name are required. But then you can update the person and remove first name and last name.
The same is valid for ecommerce application. While registering as a new customer, the names are required, but later if you decide to update the profile you can remove the names (even they are marked as required).
In the person entity, firsName and lastName are not required fields, so removing them is ok, but there are lots of screen (i found 3 of them in few clicks) that assumes firstName and lastName always present for a person. So these screens broke of firstName and lastName are empty.
I propose to make these fields also required for updatePerson service, unless there is a reason for not doing so that i missed (or we can do not_required these fields also during person creation). What do you think ?
> Small user interface improvement
> --------------------------------
>
> Key: OFBIZ-1231
> URL:
https://issues.apache.org/jira/browse/OFBIZ-1231> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: UI.patch, UI.patch, UI.patch
>
>
> 1. Added some missing lookups and dropdowns.
> 2. Required filed labels in person creation screen.
> 3. Preferred contact mech in create person screen was not working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
