[jira] Created: (OFBIZ-1242) MRP days to ship and inventory event planned dates issues

[Nicolas Malin (Jira)]

MRP days to ship and inventory event planned dates issues
---------------------------------------------------------

                 Key: OFBIZ-1242
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
             Project: OFBiz
          Issue Type: Bug
            Reporter: Si Chen


I noticed a couple of interesting issues with the MRP algorithm:

It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.

The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.

If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527468 ]

Mario Cappellato commented on OFBIZ-1242:
-----------------------------------------

The days to ship are very important for purchase orders. The MRP calculates the requiredByDate from routing tasks and adding the Days to ship to calculate the requirementStartDate.
I agree to remove the "ship to day" from the MRP algorithm but I propose to add a new field (mrpLeadTimeMillis) into ProductFacility and replace the "ship to day" with this new field in the MRP. Then MRP algorithm will add all the time mrpLeadTimeMillis to the calculated time of every event.

I don't think that forcing the proposed date by MRP at now if the date is before of today is a good idea. As is now is better because you have a clear understanding of how late an order is.

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen reassigned OFBIZ-1242:
------------------------------

    Assignee: Si Chen

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>            Assignee: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen reassigned OFBIZ-1242:
------------------------------

    Assignee:     (was: Si Chen)

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527538 ]

Si Chen commented on OFBIZ-1242:
--------------------------------

#1 I think if you want to use some measure of how long a product takes to ship, you should be using SupplierProduct not the ProductFacility entity.  

#2 Then shouldn't the "isLate" flag be set?  It seems always to be set to "false"

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527556 ]

Mario Cappellato commented on OFBIZ-1242:
-----------------------------------------

#1 The MRP doesn't analyse SuppliersProduct because it creates the unassigned requirements.

#2 Yes, the "isLate" flag is set to "Y" when the eventDate is minus of run day. I tried and it is true.

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535463 ]

Jacopo Cappellato commented on OFBIZ-1242:
------------------------------------------

Si,

can we close this issue?

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1242:
----------------------------------------

    Assignee: Jacopo Cappellato

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>            Assignee: Jacopo Cappellato
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1242.
------------------------------------

    Resolution: Cannot Reproduce

> MRP days to ship and inventory event planned dates issues
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1242
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1242
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Si Chen
>            Assignee: Jacopo Cappellato
>
> I noticed a couple of interesting issues with the MRP algorithm:
> It was using ProductFacility.daysToShip to create a buffer time for requirements, but it was doing it for all requirements, so even manufactured parts were having this buffer time added.  I fixed it in 575413 by limiting days to ship to only sales order related requirements.  However, I believe that daysToShip should be eliminated altogether in MRP, because I think this field should be used as an average value for customer-related "how long it takes to ship this order."  The actual time to manufacture or order and receive an item may vary, depend on the priority of the order, etc.  If a buffer process is required, it should be added for example as a manufacturing routing task.
> The other issue is that MRP will create inventory events in the past (ie, before the time when it's run.)  I think we should limit it so that inventory events created should be now or in the future.
> If there are no comments to the contrary I will make these changes and commit them.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[je]

Absolutely agree！

Mario Cappellato commented on OFBIZ-1242:
-----------------------------------------

The days to ship are very important for purchase orders. The MRP calculates the requiredByDate from routing tasks and adding the Days to ship to calculate the requirementStartDate.
I agree to remove the "ship to day" from the MRP algorithm but I propose to add a new field (mrpLeadTimeMillis) into ProductFacility and replace the "ship to day" with this new field in the MRP. Then MRP algorithm will add all the time mrpLeadTimeMillis to the calculated time of every event.

I don't think that forcing the proposed date by MRP at now if the date is before of today is a good idea. As is now is better because you have a clear understanding of how late an order is.