[jira] Created: (OFBIZ-1245) Service Engine inconsistent in handling fail results

[Nicolas Malin (Jira)]

Service Engine inconsistent in handling fail results
----------------------------------------------------

                 Key: OFBIZ-1245
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor


Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1245:
-------------------------------

    Attachment: framework_service.patch

Attached patch fixes the bug.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1245:
-------------------------------

    Attachment: asset_maint.patch

asset_maint.patch demonstrates the fix.

Apply the asset_maint patch to a fresh checkout & build, rev 576583 or later. Create a demo user login and assign it the ASSETMAINTTECH permission group. Log into Asset Maint as that user. Try to update the DEMO_MACHINE fixed asset - a permission error message pops up, ACCOUNTING permissions are required. The operation should have completed successfully.

Apply the patch from OFBIZ-1246, the framework_service patch from this issue, and then merge in the patch from OFBIZ-1237 (all are needed). Rebuild the project and try the DEMO_MACHINE update again. Now the update is successful.

Using the same demo user, try to create a new fixed asset. The create will fail with the both permission errors listed - ACCOUNTING and ASSETMAINT (the correct behavior).

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: asset_maint.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1245:
-------------------------------

    Attachment: framework_service.patch

Updated patch against latest SVN.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: asset_maint.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1245:
----------------------------------------

    Assignee: David E. Jones

David,

can I assign this issue to you? It is closely related to OFBIZ-1237 that you already assigned to you (and partially committed). Ok, I just assigned it... but if you don't want to look at it just deassign :-)

Thanks

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>         Attachments: asset_maint.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1245:
-------------------------------

    Attachment: framework_service.patch

Updated patch to latest SVN.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>         Attachments: asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1245:
-------------------------------

    Attachment: framework_service.patch
                asset_maint.patch

Updated both patch files to latest SVN.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>         Attachments: asset_maint.patch, asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538841 ]

Adrian Crum commented on OFBIZ-1245:
------------------------------------

Updated demo instructions:

Apply both patches to a fresh checkout, then build. Create a demo user login and assign it the ASSETMAINTTECH permission group. Log into Asset Maint as that user.

Try to update the DEMO_MACHINE fixed asset - the operation should complete successfully.

Using the same demo user, try to create a new equipment. The create will fail with the both permission errors listed - ACCOUNTING and ASSETMAINT.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>         Attachments: asset_maint.patch, asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539096 ]

Adrian Crum commented on OFBIZ-1245:
------------------------------------

David,

I'm not sure if you're aware of this, but this patch needs to be committed to complete the permission service ECA work.

Once this is committed, I'll update the Asset Maintenance component  and then create a Wiki document on how to use permission services.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>         Attachments: asset_maint.patch, asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-1245.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks for your work on this Adrian. Your changes are SVN rev 591241, just the framework_services patch. Based on a review I'm not sure if I like how all of the failureMessage stuff is handled, but that's not because of this patch. This does appear to be consistent with other places, and if it works, then great for now!

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: asset_maint.patch, asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539604 ]

Adrian Crum commented on OFBIZ-1245:
------------------------------------

David,

Thank you very much for your help! I will commit the Asset Maintenance part.

I agree - I don't like how failure status/messages are handled. It appears they were tacked on as an after thought, so they are not handled consistently. Perhaps we can discuss a better way of handling them on the ml.

> Service Engine inconsistent in handling fail results
> ----------------------------------------------------
>
>                 Key: OFBIZ-1245
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1245
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: asset_maint.patch, asset_maint.patch, framework_service.patch, framework_service.patch, framework_service.patch, framework_service.patch
>
>
> Services can indicate failure with a ModelService.RESPOND_FAIL response or by putting a failMessage element in the result Map. The service engine is inconsistent in checking for a failure - sometimes it checks for ModelService.RESPOND_FAIL and sometimes it checks for the failMessage element in the result Map. This can lead to unpredictable results when working with services that return failure.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.