[jira] Created: (OFBIZ-1260) reserve inventory not accounting for inventory transfers

[Nicolas Malin (Jira)]

reserve inventory not accounting for inventory transfers
--------------------------------------------------------

                 Key: OFBIZ-1260
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
             Project: OFBiz
          Issue Type: Bug
          Components: product
            Reporter: Si Chen


It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542999 ]

Jacopo Cappellato commented on OFBIZ-1260:
------------------------------------------

Si,

are you sure there is a bug here?
If I'm not wrong, when you start an inventory transfer, the units are reserved for it and released only when the transfer is complete.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543136 ]

Si Chen commented on OFBIZ-1260:
--------------------------------

Well that would be nice...  Where does it do that?  Did I miss it in the code?

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543262 ]

Jacopo Cappellato commented on OFBIZ-1260:
------------------------------------------

Just create a transfer, you'll see that the ATP units are decreased.
For example, I've created a transfer for the item 9010:

https://demo.hotwaxmedia.com/facility/control/TransferInventoryItem?inventoryTransferId=10002

here is the inventory item screen:

https://demo.hotwaxmedia.com/facility/control/EditInventoryItem?inventoryItemId=9010&facilityId=WebStoreWarehouse

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543361 ]

Jacques Le Roux commented on OFBIZ-1260:
----------------------------------------

Should we close this issue ?

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543613 ]

Si Chen commented on OFBIZ-1260:
--------------------------------

The ATP is decreased, but is the inventory item considered reserved?  For example, if you create a sales order for the same item, I think the system would reserve the inventory item which should be transferred against the sales order.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543808 ]

Jacopo Cappellato commented on OFBIZ-1260:
------------------------------------------

Si,

I don't know if there is an issue here: did you get a chance to test what happens in the scenario that you have described?

By the way, I agree that we should create InventoryItemDetails entries for inventory transfers as well (is this that you are suggesting?)... in my opinion InventoryItemDetails should be created to log all the relevant changes to inventory items (not only the changes to the qoh/atp): facilityId (after a transfer), location, unit cost, owner...

 

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen updated OFBIZ-1260:
---------------------------

    Attachment: ofbiz-inv-xfer-res.zip

video showing this

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543993 ]

Si Chen commented on OFBIZ-1260:
--------------------------------

I am able to replicate the scenario, and what happens is the item waiting for a transfer is reserved against a new order.  You can try it yourself:

1.  Receive 1.0 of GZ-1001 into WebStoreWarehouse
2.  Create a pending inventory transfer to My Retail Warehouse
3.  Create sales order for 1 GZ-1001 for the Demo Ecommerce Store.

You will see that the same item which is awaiting inventory transfer is reserved for your sales order.  

Please take a look at the video I just uploaded.

I'm not sure that IID is the answer or if the reserveProductInventory method should check for pending transfers manually.

Si

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544073 ]

Bilgin Ibryam commented on OFBIZ-1260:
--------------------------------------

Si,

Not sure that this is what you are looking for, but if you change "Require Inventory = Y" for Demo Ecommerce Store, you will notice that this item cannot be ordered(then cannot be reserved), because ATP is decreased due to inventory transfer.  (very long sentence -:)

Bilgin

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544100 ]

Si Chen commented on OFBIZ-1260:
--------------------------------

Hi Bilgin,

Yes, thanks for pointing that out, but that's not quite the same thing.  I think we should be able to support taking the back order, but it should not reserve against an item waiting to be transferred.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544409 ]

Scott Gray commented on OFBIZ-1260:
-----------------------------------

Sounds like the inventory is being reserved even though atp is 0, probably some sort of bug in reserveProductInventory.  It shouldn't specifically be checking for transfers it just needs to reserve no more than what is available to promise.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544419 ]

Bilgin Ibryam commented on OFBIZ-1260:
--------------------------------------

Also notice that the system does reservations for products w/o inventory or for products that has negative ATP. If this behavour is OK,  reservations for items waiting for transfer looks the same. Item waiting transfer is like no item, or negative ATP item (in some cases).

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544537 ]

Si Chen commented on OFBIZ-1260:
--------------------------------

Hey guys, reserving inventory for products with negative atp or 0 atp is the desired behavior.  This is how the system takes back orders and when inventory is received balanceInventoryItems will set it off against a positive item.  

In any case, it's a totally different issue than what this issue is about: here the issue is that even when an inventory item is pending transfer, it will still be reserved against orders.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576101#action_12576101 ]

Bradley Plies commented on OFBIZ-1260:
--------------------------------------

Si,

I will first admit that I am not knowledgeable about this area, but is reserving an inventory item that is being transfered for an order necessarily wrong?  What if you have two inventory facilities that your organization fulfills orders from, and in this case, say both of these facilities are that way.  So no matter which facility ends up with the item, it is reserved for fulfillment when it gets there. If the order were created first before the transfer, then obviously we could have avoided some wasteful delivery between facilities (an operational efficiency issue), but if the order is created during a transfer there was no way to prevent/foresee it and you still actually have the item to promise to the order.

Just some thoughts to hopefully view the issue in a different light.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576101#action_12576101 ]

bplies edited comment on OFBIZ-1260 at 3/7/08 1:45 AM:
--------------------------------------------------------------

Si,

I will first admit that I am not knowledgeable about this area, but is reserving an inventory item that is being transfered necessarily wrong?  What if you have two inventory facilities that your organization fulfills orders from, and in this case, say both of these facilities are that way.  So no matter which facility ends up with the item, it is reserved for fulfillment when it gets there. If the order were created first before the transfer, then obviously we could have avoided some wasteful delivery between facilities (an operational efficiency issue), but if the order is created during a transfer there was no way to prevent/foresee it and you still actually have the item to promise to the order.

Just some thoughts to hopefully view the issue in a different light.

      was (Author: bplies):
    Si,

I will first admit that I am not knowledgeable about this area, but is reserving an inventory item that is being transfered for an order necessarily wrong?  What if you have two inventory facilities that your organization fulfills orders from, and in this case, say both of these facilities are that way.  So no matter which facility ends up with the item, it is reserved for fulfillment when it gets there. If the order were created first before the transfer, then obviously we could have avoided some wasteful delivery between facilities (an operational efficiency issue), but if the order is created during a transfer there was no way to prevent/foresee it and you still actually have the item to promise to the order.

Just some thoughts to hopefully view the issue in a different light.
 

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1260.
----------------------------------

    Resolution: Won't Fix
      Assignee: Jacques Le Roux

I think Bradley is right here : the item is still available in the company. Of course if we are considering a transfer out of the company this would be false. But I think a transfer is always between company's facilites.

> reserve inventory not accounting for inventory transfers
> --------------------------------------------------------
>
>                 Key: OFBIZ-1260
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1260
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: ofbiz-inv-xfer-res.zip
>
>
> It appears that the reserve inventory service, specifically reserveForInventoryItemInline in InventoryReserveServices.xml, is not accounting for pending InventoryTransfers.  I think it should be.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.