[jira] Created: (OFBIZ-1277) Underlining doesn't work on receipts

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1277) Underlining doesn't work on receipts

Nicolas Malin (Jira)
Underlining doesn't work on receipts
------------------------------------

                 Key: OFBIZ-1277
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1277
             Project: OFBiz
          Issue Type: Bug
          Components: pos
    Affects Versions: SVN trunk, Release Branch 4.0
         Environment: Linux
            Reporter: Chris Lombardi
            Priority: Minor
             Fix For: SVN trunk, Release Branch 4.0


Provisions were made for underlining in Receipt.java, but the substitution of the printer code was left out.  Simple fix to follow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1277) Underlining doesn't work on receipts

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1277:
----------------------------------

    Attachment: ofbiz-1277.patch

patched on release4.0, but should also work on trunk.  Thanks!

> Underlining doesn't work on receipts
> ------------------------------------
>
>                 Key: OFBIZ-1277
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1277
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: Linux
>            Reporter: Chris Lombardi
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ofbiz-1277.patch
>
>
> Provisions were made for underlining in Receipt.java, but the substitution of the printer code was left out.  Simple fix to follow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1277) Underlining doesn't work on receipts

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1277.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Chris,

Please when you submit a patch follow this guidelines : http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Notably in you patch :
. Don't use tabs
. Don't use absolute pathes
. The 3 1st lines of your patch should not look like
    diff -x .svn -aurN release4.0-clean/specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java release4.0/specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java
    --- release4.0-clean/specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java 2007-09-30 14:22:25.000000000 -0500
    +++ release4.0/specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java 2007-09-30 14:06:38.000000000 -0500
but be only one line :
    Index specialpurpose/pos/src/org/ofbiz/pos/device/impl/Receipt.java

Nevertheless the change you suggested is in trunk 580789, release4.0 580792

> Underlining doesn't work on receipts
> ------------------------------------
>
>                 Key: OFBIZ-1277
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1277
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: Linux
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ofbiz-1277.patch
>
>
> Provisions were made for underlining in Receipt.java, but the substitution of the printer code was left out.  Simple fix to follow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1277) Underlining doesn't work on receipts

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539832 ]

Chris Lombardi commented on OFBIZ-1277:
---------------------------------------

I updated my scripts to handle these situations.  Thanks.

C



> Underlining doesn't work on receipts
> ------------------------------------
>
>                 Key: OFBIZ-1277
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1277
>             Project: OFBiz
>          Issue Type: Bug
>          Components: pos
>    Affects Versions: SVN trunk, Release Branch 4.0
>         Environment: Linux
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ofbiz-1277.patch
>
>
> Provisions were made for underlining in Receipt.java, but the substitution of the printer code was left out.  Simple fix to follow.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.