[jira] Created: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
Automatic Translation of view entity fields from the real entity linked to the view
-----------------------------------------------------------------------------------

                 Key: OFBIZ-129
                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
         Environment: Windows
            Reporter: Marco Risaliti
            Priority: Minor


I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
To be more clear I will try to explain with an example.
A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
In this case I will have to create the following row into CommonEntityLabels.properties  :
UomType.description.LENGTH_MEASURE=Length
Uom.description.LEN_cm=Centimeter

and to solve the view entity issue I had to insert also this row in the same property file
UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length

This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
I wait for you feedback on this patch and I'm at your disposal for discuss on it.

Thanks a lot
Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-129?page=all ]

Marco Risaliti updated OFBIZ-129:
---------------------------------

    Attachment: i18n_view_entity.patch

> Automatic Translation of view entity fields from the real entity linked to the view
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-129
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>            Priority: Minor
>         Attachments: i18n_view_entity.patch
>
>
> I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
> The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
> To be more clear I will try to explain with an example.
> A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
> In this case I will have to create the following row into CommonEntityLabels.properties  :
> UomType.description.LENGTH_MEASURE=Length
> Uom.description.LEN_cm=Centimeter
> and to solve the view entity issue I had to insert also this row in the same property file
> UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
> UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length
> This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
> I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
> I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
> In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
> I wait for you feedback on this patch and I'm at your disposal for discuss on it.
> Thanks a lot
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-129?page=comments#action_12425157 ]
           
Jacques Le Roux commented on OFBIZ-129:
---------------------------------------

Sounds good to me.

> Automatic Translation of view entity fields from the real entity linked to the view
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-129
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>            Priority: Minor
>         Attachments: i18n_view_entity.patch
>
>
> I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
> The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
> To be more clear I will try to explain with an example.
> A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
> In this case I will have to create the following row into CommonEntityLabels.properties  :
> UomType.description.LENGTH_MEASURE=Length
> Uom.description.LEN_cm=Centimeter
> and to solve the view entity issue I had to insert also this row in the same property file
> UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
> UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length
> This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
> I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
> I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
> In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
> I wait for you feedback on this patch and I'm at your disposal for discuss on it.
> Thanks a lot
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-129?page=all ]

David E. Jones closed OFBIZ-129.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: David E. Jones

Thanks Marco, this is a nice feature. It is in SVN rev 429250.

BTW, please check out the code conventions for OFBiz (especially using spaces instead of tabs, and not putting open curly braces on their own line). Details are on the docs site here:

http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

I also changed the modelEntity variable name to avoid confusion with the object level variable that had the same name.

> Automatic Translation of view entity fields from the real entity linked to the view
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-129
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: i18n_view_entity.patch
>
>
> I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
> The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
> To be more clear I will try to explain with an example.
> A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
> In this case I will have to create the following row into CommonEntityLabels.properties  :
> UomType.description.LENGTH_MEASURE=Length
> Uom.description.LEN_cm=Centimeter
> and to solve the view entity issue I had to insert also this row in the same property file
> UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
> UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length
> This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
> I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
> I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
> In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
> I wait for you feedback on this patch and I'm at your disposal for discuss on it.
> Thanks a lot
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-129?page=comments#action_12426309 ]
           
Marco Risaliti commented on OFBIZ-129:
--------------------------------------

Hi David,

I'm completed agree with you but unfortunately I have changed my eclipse version and I have changed the formatting/indentation options before changing the code inside this patch.
Anyway I will follow your standard code.

Thanks again for you support and work
Marco

> Automatic Translation of view entity fields from the real entity linked to the view
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-129
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: i18n_view_entity.patch
>
>
> I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
> The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
> To be more clear I will try to explain with an example.
> A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
> In this case I will have to create the following row into CommonEntityLabels.properties  :
> UomType.description.LENGTH_MEASURE=Length
> Uom.description.LEN_cm=Centimeter
> and to solve the view entity issue I had to insert also this row in the same property file
> UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
> UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length
> This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
> I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
> I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
> In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
> I wait for you feedback on this patch and I'm at your disposal for discuss on it.
> Thanks a lot
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-129) Automatic Translation of view entity fields from the real entity linked to the view

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-129?page=comments#action_12426313 ]
           
David E. Jones commented on OFBIZ-129:
--------------------------------------

No problem Marco, just a reminder.

In fact, I recently updated Eclipse on my laptop and got burned by the rather unfortunate default settings it comes with...

> Automatic Translation of view entity fields from the real entity linked to the view
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-129
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-129
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Windows
>            Reporter: Marco Risaliti
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: i18n_view_entity.patch
>
>
> I have seen that in same forms the heading of the fields was not translated and checking in to the source I have verified that in case of using the view entity those fields was not translated automatically from the real entity linked to the view.
> The first solution can be to insert also the view entities into the EntityLabels properties file but in this case a lot of replication of data will be happened.
> To be more clear I will try to explain with an example.
> A lot of fields into the forms use the view entity UomAndType that can be used to show the type and unit of misure.
> In this case I will have to create the following row into CommonEntityLabels.properties  :
> UomType.description.LENGTH_MEASURE=Length
> Uom.description.LEN_cm=Centimeter
> and to solve the view entity issue I had to insert also this row in the same property file
> UomAndType.description.LEN_cm.LENGTH_MEASURE=Centimeter
> UomAndType.typeDescription.LEN_cm.LENGTH_MEASURE=Length
> This cause a lot of data replication into the EntityLabels properties and so I prefer that the Entity Engine will retrieve automatically the translation of the heading of the fields from the real entity linked to the view.
> I have modified the GenericEntity.get() method to apply this new mechanism that you can find attached to this issue.
> I have tried this patch a lot but I prefer if some of the major expert of OFBIZ can test it before commits because this method it's hugely into the forms.
> In the patch you can find also the new header for this class and you can find also Valid Status Change for Shipment to test this new mechanism.
> I wait for you feedback on this patch and I'm at your disposal for discuss on it.
> Thanks a lot
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira