[jira] Created: (OFBIZ-1300) Don't create temporary Integer in UtilCache config code

[Nicolas Malin (Jira)]

Don't create temporary Integer in UtilCache config code
-------------------------------------------------------

                 Key: OFBIZ-1300
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1300
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adam Heath
            Priority: Trivial
             Fix For: SVN trunk
         Attachments: framework-base-UtilCache-ImprovedNumberParsing.patch

When UtilCache is reading it's properties, it was creating a new Integer(or Long).  It then compared that to null(which would never be false).  Then, it fetched the int(or long) value from the number container.  It's more efficient to just call parseInt(or parseLong).

This patch depends on OFBIZ-1295

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1300:
------------------------------

    Attachment: framework-base-UtilCache-ImprovedNumberParsing.patch

> Don't create temporary Integer in UtilCache config code
> -------------------------------------------------------
>
>                 Key: OFBIZ-1300
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1300
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: framework-base-UtilCache-ImprovedNumberParsing.patch
>
>
> When UtilCache is reading it's properties, it was creating a new Integer(or Long).  It then compared that to null(which would never be false).  Then, it fetched the int(or long) value from the number container.  It's more efficient to just call parseInt(or parseLong).
> This patch depends on OFBIZ-1295

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1300:
------------------------------

    Assignee: Adam Heath

> Don't create temporary Integer in UtilCache config code
> -------------------------------------------------------
>
>                 Key: OFBIZ-1300
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1300
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: framework-base-UtilCache-ImprovedNumberParsing.patch
>
>
> When UtilCache is reading it's properties, it was creating a new Integer(or Long).  It then compared that to null(which would never be false).  Then, it fetched the int(or long) value from the number container.  It's more efficient to just call parseInt(or parseLong).
> This patch depends on OFBIZ-1295

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath closed OFBIZ-1300.
-----------------------------

    Resolution: Fixed

Resolved by 585653.

> Don't create temporary Integer in UtilCache config code
> -------------------------------------------------------
>
>                 Key: OFBIZ-1300
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1300
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: framework-base-UtilCache-ImprovedNumberParsing.patch
>
>
> When UtilCache is reading it's properties, it was creating a new Integer(or Long).  It then compared that to null(which would never be false).  Then, it fetched the int(or long) value from the number container.  It's more efficient to just call parseInt(or parseLong).
> This patch depends on OFBIZ-1295

... [show rest of quote]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.