OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1318) screen widget show where code came from in html

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

31 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541630 ]

Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------

Adrian,

To make this useful feature easier to use I propose to put

<context-param>
<param-name>widgetVerbose</param-name>
<param-value>false</param-value>
<description>Set to true to enables widget boundary comments. See JavaDoc for use in screen widget </description>
</context-param>

in each web.xml files. If nobody see problems with that I will do it and commit the whole soon

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541633 ]

Adrian Crum commented on OFBIZ-1318:
------------------------------------

Jacques,

I was thinking we could do that in the Example component only. From my perspective, you would want the default to be OFF, then turn it ON when you're trying to debug HTML.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541638 ]

Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------

Adrian,

Yes I agree, Example should be sufficient, shoulf be OFF of course. We may also put some information in Confluence as looking in web.xml or javaDoc is not obvious. Not sure on which page yet (any ideas welcome), then I will put a link from "my" tips :o)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541652 ]

David E. Jones commented on OFBIZ-1318:
---------------------------------------

Do we really want to configure this through web.xml?

What about when a screen or form or whatever is rendered in a non-web context and there is no web.xml?

In the past this happened when passing in a special parameter, so it just had to be in the parameters Map for the screen, but admittedly that may not be the best choice.

How about a property in debug.properties, like piggy-backing on verbose or info? Info is usually on during development only, or when debugging production servers, and that might be a good option.

Other ideas?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541660 ]

Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------

I would prefer debug.properties too.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

Attachment: widget_boundary_comments.patch

Improved patch - now accepts widget.verbose property in debug.properties.

David,
Just to clarify - the original behavior has been preserved. Boundary comments are still enabled with widgetVerbose set true in the parameters Map.

Jacques,
This patch includes the Example component context parameter in web.xml.

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1318) screen widget show where code came from in html

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1318.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Thanks Adrian,

Your patch is in trunk revision: 594042.

I just wondered if we should not use the compressHTML by default (ON) from a property in general.properties ?

> screen widget show where code came from in html
> -----------------------------------------------
>
> Key: OFBIZ-1318
> URL: https://issues.apache.org/jira/browse/OFBIZ-1318
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from. For example, if the screen widget called a form, it could put into HTML:
> 
> 
> Similarly, if html-template is called it could put into HTML:
> 
> 
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.