[jira] Created: (OFBIZ-1318) screen widget show where code came from in html

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
screen widget show where code came from in html
-----------------------------------------------

                 Key: OFBIZ-1318
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Si Chen


This should help debugging a lot:

The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:

<!-- Begin XXXX.Forms.xml#FormA -->

<!-- End XXXX.Forms.xml#FormA -->

Similarly, if html-template is called it could put into HTML:

<!-- Begin applications/XXX/x.ftl -->

<!-- End applications/XXX/x.ftl -->

etc. etc.

I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532807 ]

Si Chen commented on OFBIZ-1318:
--------------------------------

So, anyway, is anybody opposed to this?  

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532808 ]

David E. Jones commented on OFBIZ-1318:
---------------------------------------

there is already some stuff like this in the screen widget, activated by passing a special parameter

I never remember what that parameter is, but looking at the screen widget code you can find it pretty easily

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532815 ]

Jacques Le Roux commented on OFBIZ-1318:
----------------------------------------

I just worked on widget, it seems to me (not sure) that no parameters is needed (it's by default).
Look for  
  buffer.append("<!-- begin form widget -->");
string in *.java

For the moment it's not as complete as what Si propose. This could be easily enhanced... I vote for !

For me it does not need to be VERBOSE, as it's right now it's ok, just extending should be sufficient

My 2 cents

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533140 ]

Adrian Crum commented on OFBIZ-1318:
------------------------------------

Si,

I looked at that capability back when I was refactoring the UI. The existing comments that Jacques mentioned were put there by me. At the time David had commented about the existing capability to turn on the comments via a parameter, so I checked into it. I found that the code David is referring to needed work - because the commenting was done by the model classes, not the HTML rendering classes. I had planned on reworking the screen widgets to move that code to the HTML rendering classes, but I ran out of time.

Anyways, I'll vote for this. I agree it would greatly benefit development. I can lend a hand if you'd like.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533198 ]

Si Chen commented on OFBIZ-1318:
--------------------------------

Yea, Adrian, if you have some time to work on it it'd be great!

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

Si,

I am attaching a basic patch for you to review. I moved the boundary comment code to the rendering classes. I also cleaned up a few things and fixed a bug I ran into while working on it.

The rendered comments don't include the location#name syntax you're looking for because the rendering classes have no references to the model classes that created them.  I could develop this further to enable that capability, but that would require refactoring the widget interfaces.

HTML comments are enabled with the "widgetVerbose" parameter set to true.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

Improved patch. All comments appear as requested.

I didn't have to refactor anything - minimal changes were made.

If this patch is acceptable, let me know and I will flesh out the javadocs, then I will submit a final version.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533911 ]

Si Chen commented on OFBIZ-1318:
--------------------------------

Wow, this is interesting.  As far as I'm concerned, it'd be nice to provide deprecated methods of the old parameter signatures, but otherwise it looks OK.

What does everybody else think?  

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534062 ]

Adrian Crum commented on OFBIZ-1318:
------------------------------------

Si,

I'm confused. What does "deprecated methods of the old parameter signatures" mean?


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

Final version attached.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

Updated patch to latest SVN.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment:     (was: widget_boundary_comments.patch)

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1318:
--------------------------------------

    Assignee: Jacques Le Roux

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

Updated patch to latest SVN.


> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment:     (was: widget_boundary_comments.patch)

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment:     (was: widget_boundary_comments.patch)

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1318) screen widget show where code came from in html

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1318:
-------------------------------

    Attachment: widget_boundary_comments.patch

> screen widget show where code came from in html
> -----------------------------------------------
>
>                 Key: OFBIZ-1318
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1318
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Si Chen
>            Assignee: Jacques Le Roux
>         Attachments: widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch, widget_boundary_comments.patch
>
>
> This should help debugging a lot:
> The screen widget render could put in an HTML comment in the html document if log INFO is turned on (or VERBOSE if you really don't like it) to show where the text came from.  For example, if the screen widget called a form, it could put into HTML:
> <!-- Begin XXXX.Forms.xml#FormA -->
> <!-- End XXXX.Forms.xml#FormA -->
> Similarly, if html-template is called it could put into HTML:
> <!-- Begin applications/XXX/x.ftl -->
> <!-- End applications/XXX/x.ftl -->
> etc. etc.
> I think this would be a good debugging tool.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

12