[jira] Created: (OFBIZ-1346) GenericEntity.setString does handles BigDecimal and Boolean backwards.

[Nicolas Malin (Jira)]

GenericEntity.setString does handles BigDecimal and Boolean backwards.
----------------------------------------------------------------------

                 Key: OFBIZ-1346
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: Adam Heath
            Priority: Critical
             Fix For: SVN trunk, Release Branch 4.0


I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1346:
------------------------------

    Attachment: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1346:
------------------------------

    Attachment: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch

New version of the patch.

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1346:
------------------------------

    Attachment:     (was: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch)

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1346:
------------------------------

    Attachment: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch

Yet another version.  Sorry about the churn.

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath updated OFBIZ-1346:
------------------------------

    Attachment:     (was: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch)

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535009 ]

Adam Heath commented on OFBIZ-1346:
-----------------------------------

Just noticed that datasource/MemoryHelper has another problem with this.  It *requires* that boolean fields store a Boolean object.  However, from the discussion on the mailing list, this is *not* the case; boolean fields actually store a single character String(Y/N).

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath reassigned OFBIZ-1346:
---------------------------------

    Assignee: Adam Heath

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath closed OFBIZ-1346.
-----------------------------

    Resolution: Fixed

Applied in version 585820.

> GenericEntity.setString does handles BigDecimal and Boolean backwards.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1346
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1346
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Critical
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: framework-entity-GenericEntity-setString-Boolean-BigDecimal-fix.patch
>
>
> I was converting SqlJdbcUtil to use enums for the field types, and discovered that GenericEntity.setString had the int values for BigDecimal and Boolean reversed.  See attached patch for the fix.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.