[jira] Created: (OFBIZ-1356) Variable error in viewprofile.ftl

[Nicolas Malin (Jira)]

Variable error in viewprofile.ftl
---------------------------------

                 Key: OFBIZ-1356
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: Release Branch 4.0
         Environment: Mac OS X 10.4.10
            Reporter: Carl Johansson
            Priority: Minor


The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536456 ]

Bilgin Ibryam commented on OFBIZ-1356:
--------------------------------------

Carl,

You can still use Team > Create patch in Eclipse for patches. The only thing you have to do is to remove the beginning of paths up to ofbiz home dir from your patch.
After creating the patch i usually open it with a text editor, mark the beginning of the path for removing, and do a replace all from edit menu of text editor  with an empty string. This should fix paths in the patch file.

Regards,
Bilgin Ibryam

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536465 ]

Jacques Le Roux commented on OFBIZ-1356:
----------------------------------------

Carl,

If you are interested "by the why ?" :  http://issues.apache.org/jira/browse/OFBIZ-46#action_12417609 

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Johansson updated OFBIZ-1356:
----------------------------------

    Attachment: viewprofilevar.patch

Changes ${partyId} to ${party.partyId} in viewprofile.ftl

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536480 ]

BJ Freeman commented on OFBIZ-1356:
-----------------------------------

this should help using eclipse
http://docs.ofbiz.org/display/OFBIZ/Eclipse+Tips

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536497 ]

Scott Gray commented on OFBIZ-1356:
-----------------------------------

Hi Carl

I had a quick look and it seems ok to use ${partyId} because it exists in the context, was this causing problems for you?

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536506 ]

Carl Johansson commented on OFBIZ-1356:
---------------------------------------

Scott,

yes it made the template useless for me and changing it solved the issue. Does ${partyId} work for anyone else?

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536560 ]

Adrian Crum commented on OFBIZ-1356:
------------------------------------

I checked the markup of a recent SVN rev and I was unable to reproduce the problem - the partyId appears in the links as expected.

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536594 ]

Carl Johansson commented on OFBIZ-1356:
---------------------------------------

Even though changing the variables fixed my issue I have - fortunately - not been able to reproduce it and I say let's call this off as "unable to reproduce".

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Johansson closed OFBIZ-1356.
---------------------------------

       Resolution: Cannot Reproduce
    Fix Version/s: Release Branch 4.0

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536595 ]

Scott Gray commented on OFBIZ-1356:
-----------------------------------

Look on the bright side, at least now you know how to create patches :-)

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536623 ]

Carl Johansson commented on OFBIZ-1356:
---------------------------------------

Exactly ;) Thanks for the help and hope we'll see some real patches by me in the future instead.

> Variable error in viewprofile.ftl
> ---------------------------------
>
>                 Key: OFBIZ-1356
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1356
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: Mac OS X 10.4.10
>            Reporter: Carl Johansson
>            Priority: Minor
>             Fix For: Release Branch 4.0
>
>         Attachments: viewprofilevar.patch
>
>
> The template viewprofile.ftl contains faulty variables. The ${partyId} should be changed to ${party.partyId}. I have however never made a patch and Team > Create patch in Eclipse made a very strange patch including the complete paths on my local system.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.