[jira] Created: (OFBIZ-1360) permission-service errors

[Nicolas Malin (Jira)]

permission-service errors
-------------------------

                 Key: OFBIZ-1360
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
             Project: OFBiz
          Issue Type: Bug
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
             Fix For: SVN trunk


Hi all,

I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:

The Following Errors Occurred:
Unknown parameter found: [createWorkEffort.hasPermission]
Unknown parameter found: [createWorkEffort.responseMessage]

In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
In checkAuth method ServiceDispatcher.java:885 there is
                context.putAll(permResp);
                context = origService.makeValid(context, ModelService.IN_PARAM);

context.putAll(permResp);  puts these extra parameters  and
context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.

it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
passed in context." cause this error, but i didnot test it, so not 100% about the reason.

I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?

Regards,
Bilgin Ibryam


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536505 ]

Adrian Crum commented on OFBIZ-1360:
------------------------------------

I've been getting those errors too. Something definitely broke in a recent commit.

> permission-service errors
> -------------------------
>
>                 Key: OFBIZ-1360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>
> Hi all,
> I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:
> The Following Errors Occurred:
> Unknown parameter found: [createWorkEffort.hasPermission]
> Unknown parameter found: [createWorkEffort.responseMessage]
> In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
> In checkAuth method ServiceDispatcher.java:885 there is
>                 context.putAll(permResp);
>                 context = origService.makeValid(context, ModelService.IN_PARAM);
> context.putAll(permResp);  puts these extra parameters  and
> context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
> But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
> I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.
> it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
> passed in context." cause this error, but i didnot test it, so not 100% about the reason.
> I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536520 ]

Jacopo Cappellato commented on OFBIZ-1360:
------------------------------------------

I had similar errors too.

> permission-service errors
> -------------------------
>
>                 Key: OFBIZ-1360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>
> Hi all,
> I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:
> The Following Errors Occurred:
> Unknown parameter found: [createWorkEffort.hasPermission]
> Unknown parameter found: [createWorkEffort.responseMessage]
> In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
> In checkAuth method ServiceDispatcher.java:885 there is
>                 context.putAll(permResp);
>                 context = origService.makeValid(context, ModelService.IN_PARAM);
> context.putAll(permResp);  puts these extra parameters  and
> context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
> But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
> I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.
> it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
> passed in context." cause this error, but i didnot test it, so not 100% about the reason.
> I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536526 ]

Adam Heath commented on OFBIZ-1360:
-----------------------------------

I am not familar with work efforts.  Please tell me exactly what you filled out in those fields.  Or, if someone else has something easier to deal with.

Upon looking at the code closer, I did make a mistake in making checkAuth not have a return value.  I backed that out in revision 586938.  Could you please try again?

> permission-service errors
> -------------------------
>
>                 Key: OFBIZ-1360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>
> Hi all,
> I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:
> The Following Errors Occurred:
> Unknown parameter found: [createWorkEffort.hasPermission]
> Unknown parameter found: [createWorkEffort.responseMessage]
> In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
> In checkAuth method ServiceDispatcher.java:885 there is
>                 context.putAll(permResp);
>                 context = origService.makeValid(context, ModelService.IN_PARAM);
> context.putAll(permResp);  puts these extra parameters  and
> context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
> But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
> I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.
> it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
> passed in context." cause this error, but i didnot test it, so not 100% about the reason.
> I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536532 ]

Bilgin Ibryam commented on OFBIZ-1360:
--------------------------------------

I gave "create workeffort " only as an example for error generation. The errors occurs in lots of screens using services with permission-service tag.
Now after reverting the changes in r586938 all the errors i saw are gone.
Thanks Adam

> permission-service errors
> -------------------------
>
>                 Key: OFBIZ-1360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>
> Hi all,
> I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:
> The Following Errors Occurred:
> Unknown parameter found: [createWorkEffort.hasPermission]
> Unknown parameter found: [createWorkEffort.responseMessage]
> In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
> In checkAuth method ServiceDispatcher.java:885 there is
>                 context.putAll(permResp);
>                 context = origService.makeValid(context, ModelService.IN_PARAM);
> context.putAll(permResp);  puts these extra parameters  and
> context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
> But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
> I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.
> it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
> passed in context." cause this error, but i didnot test it, so not 100% about the reason.
> I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1360.
------------------------------------

    Resolution: Fixed

Yes, it now works, thanks Adam (and to Bilgin and Adrian).

> permission-service errors
> -------------------------
>
>                 Key: OFBIZ-1360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1360
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>             Fix For: SVN trunk
>
>
> Hi all,
> I tried to create a workEffort in lates ofbiz trunk (w/o any changes) from workEffort manger with admin and got this error:
> The Following Errors Occurred:
> Unknown parameter found: [createWorkEffort.hasPermission]
> Unknown parameter found: [createWorkEffort.responseMessage]
> In ServiceDispatcher.java ,  at runSync and at runAsync  is called checkAuth(localName, context, modelService);
> In checkAuth method ServiceDispatcher.java:885 there is
>                 context.putAll(permResp);
>                 context = origService.makeValid(context, ModelService.IN_PARAM);
> context.putAll(permResp);  puts these extra parameters  and
> context = origService.makeValid(context, ModelService.IN_PARAM);  removes the not needed ones.
> But this local context  is not returned from checkAuth method, and the main context still contains these extra params (hasPermission, responseMessage...).
> I fixed the bug calling makeValid() in runSync and at runAsync exactly after checkAuth method. This will remove these extra params, from main context map.
> it looks like the chages in r586470 "No longer return anything from checkAuth; instead, just modify the
> passed in context." cause this error, but i didnot test it, so not 100% about the reason.
> I am not sure how should be fixed the bug: reverting changes or calling makeValid evrytime after checkAuth or another way. ?
> Regards,
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.