[jira] Created: (OFBIZ-1366) Comparaison between Integer and String in RecurrenceRule.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-1366) Comparaison between Integer and String in RecurrenceRule.java

Nicolas Malin (Jira)
Comparaison between Integer and String in RecurrenceRule.java
-------------------------------------------------------------

                 Key: OFBIZ-1366
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1366
             Project: OFBiz
          Issue Type: Bug
         Environment: na
            Reporter: Fabien Carrion


The mail on this link is right http://mail-archives.apache.org/mod_mbox/ofbiz-user/200706.mbox/%3C026601c7b7cf$47e9b3c0$0300a8c0@LesArts%3E

I just made the try and confirm this bug exists. In recurenceRule, instead of having:

if (!byMinuteList.contains(new Integer(cal.get(Calendar.MINUTE))))

we should have

if (!byMinuteList.contains(new String(cal.get(Calendar.MINUTE))))

Thanks

Fabien


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-1366) Comparaison between Integer and String in RecurrenceRule.java

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1366:
----------------------------------

          Component/s: framework
        Fix Version/s: SVN trunk
    Affects Version/s: SVN trunk

> Comparaison between Integer and String in RecurrenceRule.java
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1366
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1366
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: na
>            Reporter: Fabien Carrion
>             Fix For: SVN trunk
>
>
> The mail on this link is right http://mail-archives.apache.org/mod_mbox/ofbiz-user/200706.mbox/%3C026601c7b7cf$47e9b3c0$0300a8c0@LesArts%3E
> I just made the try and confirm this bug exists. In recurenceRule, instead of having:
> if (!byMinuteList.contains(new Integer(cal.get(Calendar.MINUTE))))
> we should have
> if (!byMinuteList.contains(new String(cal.get(Calendar.MINUTE))))
> Thanks
> Fabien

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-1366) Comparaison between Integer and String in RecurrenceRule.java

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1366.
----------------------------------

    Resolution: Invalid
      Assignee: Jacques Le Roux

RecurrenceRule.java has been rewritten/refactored and I suppose that this comment was written using an older version since it was already done the 24 oct 2007. Morevoer it seems that the concerns does not apply anymore since a calendar is used now for this comparaison.

> Comparaison between Integer and String in RecurrenceRule.java
> -------------------------------------------------------------
>
>                 Key: OFBIZ-1366
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1366
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: na
>            Reporter: Fabien Carrion
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>
> The mail on this link is right http://mail-archives.apache.org/mod_mbox/ofbiz-user/200706.mbox/%3C026601c7b7cf$47e9b3c0$0300a8c0@LesArts%3E
> I just made the try and confirm this bug exists. In recurenceRule, instead of having:
> if (!byMinuteList.contains(new Integer(cal.get(Calendar.MINUTE))))
> we should have
> if (!byMinuteList.contains(new String(cal.get(Calendar.MINUTE))))
> Thanks
> Fabien

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.