[jira] Created: (OFBIZ-1367) Create person page does not show required feilds

[Nicolas Malin (Jira)]

Create person page does not show required feilds
------------------------------------------------

                 Key: OFBIZ-1367
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: BJ Freeman
            Priority: Minor
             Fix For: SVN trunk, Release Branch 4.0


https://operations.digiresources.com:8443/partymgr/control/editperson?create_new=Y
First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538075 ]

BJ Freeman commented on OFBIZ-1367:
-----------------------------------

sorry should be
« Hide
https://localhost:8443/partymgr/control/editperson?create_new=Y 

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk, Release Branch 4.0
>
>
> https://operations.digiresources.com:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1367:
-------------------------------------

        Fix Version/s:     (was: Release Branch 4.0)
          Description:
https://localhost:8443/partymgr/control/editperson?create_new=Y
First name and Last Name should show required.

  was:
https://operations.digiresources.com:8443/partymgr/control/editperson?create_new=Y
First name and Last Name should show required.

    Affects Version/s:     (was: Release Branch 4.0)

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1367:
-------------------------------------

    Comment: was deleted

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538232 ]

BJ Freeman commented on OFBIZ-1367:
-----------------------------------

so this will not get fixed in ver 4.0 ?

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538259 ]

Jacques Le Roux commented on OFBIZ-1367:
----------------------------------------

I guess the answer will be "this is not a bug fix". The discipline is to only fix bugs, the frontier is not always clear...
Is this breaking the screen ? If yes it should be back ported, else not and you will have to deal with it for your client (if I have well understood), sorry for that BJ.

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538261 ]

BJ Freeman commented on OFBIZ-1367:
-----------------------------------

If the user does not fill in both the first name and last name the creation fails.
so to me that is a bug. and it is broken

so if I fix this can I put the patch in to have 4.0 fixed

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538262 ]

Jacques Le Roux commented on OFBIZ-1367:
----------------------------------------

There is no msg, it breaks (sorry to be so unfriendly, I want to be sure to be able to defend your case ;o) ?

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1367:
-----------------------------------

       Priority: Trivial  (was: Minor)
     Issue Type: Improvement  (was: Bug)
    Environment: N/A

It works weel in trunk so the version is innapropriate. On the other hand, in release, there are messages but nothing breaks. It's an enhancement, not a bug fix.

I still wonder if we should not back port so trivial changes without any risks to release. Any opinions ? The idea is not to discuss about this issue but at large to fix/adapt the rule (rules have to be amended, only death does not change)

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: N/A
>            Reporter: BJ Freeman
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1367:
-----------------------------------

    Affects Version/s:     (was: SVN trunk)
                       Release Branch 4.0

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538277 ]

BJ Freeman commented on OFBIZ-1367:
-----------------------------------

thanks for working with me on this.
So a bug is just software that breaks or does not perform as expected.

Taking that to another level there are bugs that cause users to not perform the right tasks based on input from the application.
if you look at create customer, create prospect, and create employee
they all have required fields called out.
Therefore in the same group and expectation that create person would also show any required fields.

though you get
The Following Errors Occurred:
The following required parameter is missing: [createPerson.firstName]
The following required parameter is missing: [createPerson.lastName]

it is not an expected behavior, there for a bug from a clients point of view, since the others tell you what is required.


that said I don't support adding enhancements to 4.0 only fix it so it is ready for release so a client that is not met with unexpected results from thier input.

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538277 ]

bjfreeman edited comment on OFBIZ-1367 at 10/27/07 5:36 PM:
-------------------------------------------------------------

thanks for working with me on this.
So a bug is just software that breaks or does not perform as expected.

Taking that to another level there are bugs that cause users to not perform the right tasks based on input from the application.
if you look at create customer, create prospect, and create employee
they all have required fields called out.
Therefore in the same group and expectation that create person would also show any required fields.

though you get
The Following Errors Occurred:
The following required parameter is missing: [createPerson.firstName]
The following required parameter is missing: [createPerson.lastName]

it is not an expected behavior, there for a bug from a clients point of view, since the others tell you what is required.
If I remember right there is a jira that was suppose to cover this. so it was planned to be done but got missed.

that said I don't support adding enhancements to 4.0 only fix it so it is ready for release so a client that is not met with unexpected results from thier input.


      was (Author: bjfreeman):
    thanks for working with me on this.
So a bug is just software that breaks or does not perform as expected.

Taking that to another level there are bugs that cause users to not perform the right tasks based on input from the application.
if you look at create customer, create prospect, and create employee
they all have required fields called out.
Therefore in the same group and expectation that create person would also show any required fields.

though you get
The Following Errors Occurred:
The following required parameter is missing: [createPerson.firstName]
The following required parameter is missing: [createPerson.lastName]

it is not an expected behavior, there for a bug from a clients point of view, since the others tell you what is required.


that said I don't support adding enhancements to 4.0 only fix it so it is ready for release so a client that is not met with unexpected results from thier input.

 

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1367:
----------------------------------------

    Assignee: Jacopo Cappellato

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1367.
------------------------------------

    Resolution: Fixed

This is now also in the release branch with rev. 589272

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539630 ]

BJ Freeman commented on OFBIZ-1367:
-----------------------------------

thanks. Actually I had the fix, but was waiting to see if it would be put in 4.0 or not.

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539942 ]

Jacques Le Roux commented on OFBIZ-1367:
----------------------------------------

I must admit I was a bit overzealous on this one ;o)

> Create person page does not show required feilds
> ------------------------------------------------
>
>                 Key: OFBIZ-1367
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1367
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Release Branch 4.0
>         Environment: N/A
>            Reporter: BJ Freeman
>            Assignee: Jacopo Cappellato
>            Priority: Trivial
>             Fix For: SVN trunk
>
>
> https://localhost:8443/partymgr/control/editperson?create_new=Y
> First name and Last Name should show required.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.