OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created
-------------------------------------------------------------------------------------------------------------------------

Key: OFBIZ-1381
URL: https://issues.apache.org/jira/browse/OFBIZ-1381
Project: OFBiz
Issue Type: Bug
Components: accounting, order
Affects Versions: SVN trunk
Reporter: Skip Dever
Fix For: SVN trunk

If you sell a WG-1111 to DemoCustCompany on a billing account, then ship it, then create a return on a store credit for the same Order/Invoice, the DemoCustomer will end up with two billing accounts. Do it again and he will have three.

If this is not a "feature" that someone is using, I will fix it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

[ https://issues.apache.org/jira/browse/OFBIZ-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539884 ]

Jacopo Cappellato commented on OFBIZ-1381:
------------------------------------------

Yes,

I've noticed this too and I agree that it should be fixed: if the customer has already a billing account, then the refund should be put in that account.

> If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1381
> URL: https://issues.apache.org/jira/browse/OFBIZ-1381
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk
> Reporter: Skip Dever
> Fix For: SVN trunk
>
>
> If you sell a WG-1111 to DemoCustCompany on a billing account, then ship it, then create a return on a store credit for the same Order/Invoice, the DemoCustomer will end up with two billing accounts. Do it again and he will have three.
> If this is not a "feature" that someone is using, I will fix it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Skip Dever updated OFBIZ-1381:
------------------------------

Attachment: quickReturn.patch

This patch modifies a .bsh script to supply a billingAccountId if one exists in the OrderHeader and then creates a hidden field in the form so the billingAccountId is passed to the createReturnHeader service.

> If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1381
> URL: https://issues.apache.org/jira/browse/OFBIZ-1381
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk
> Reporter: Skip Dever
> Fix For: SVN trunk
>
> Attachments: quickReturn.patch
>
>
> If you sell a WG-1111 to DemoCustCompany on a billing account, then ship it, then create a return on a store credit for the same Order/Invoice, the DemoCustomer will end up with two billing accounts. Do it again and he will have three.
> If this is not a "feature" that someone is using, I will fix it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540017 ]

Skip Dever commented on OFBIZ-1381:
-----------------------------------

The supplied patch fixes the problem described in this one selected area (quickReturn). However, I am betting that there are other screens from which you can create returns and they would need to be patched similiarly.

An alternate method would be to modify the OrderReturnServices.processCreditReturn() to look for an existing BillingAccount for the partyId, but this way is more flexible and allows to create a second billing account in some unknown circumstance.

Just have to make sure it's done everywhere a credit return is done.

> If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1381
> URL: https://issues.apache.org/jira/browse/OFBIZ-1381
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk
> Reporter: Skip Dever
> Fix For: SVN trunk
>
> Attachments: quickReturn.patch
>
>
> If you sell a WG-1111 to DemoCustCompany on a billing account, then ship it, then create a return on a store credit for the same Order/Invoice, the DemoCustomer will end up with two billing accounts. Do it again and he will have three.
> If this is not a "feature" that someone is using, I will fix it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-1381) If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1381:
----------------------------------------

Assignee: Jacopo Cappellato

> If you Create and Ship an Order for a billing account and then create a store credit, a second billing account is created
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1381
> URL: https://issues.apache.org/jira/browse/OFBIZ-1381
> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order
> Affects Versions: SVN trunk
> Reporter: Skip Dever
> Assignee: Jacopo Cappellato
> Fix For: SVN trunk
>
> Attachments: quickReturn.patch
>
>
> If you sell a WG-1111 to DemoCustCompany on a billing account, then ship it, then create a return on a store credit for the same Order/Invoice, the DemoCustomer will end up with two billing accounts. Do it again and he will have three.
> If this is not a "feature" that someone is using, I will fix it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.