[jira] Created: (OFBIZ-1400) NullPointerException in Shipment Plan screen

[Nicolas Malin (Jira)]

NullPointerException in Shipment Plan screen
--------------------------------------------

                 Key: OFBIZ-1400
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Priority: Minor
             Fix For: SVN trunk
         Attachments: shipment.patch

Hi all,

This bug appears if you create an order with more than one ship group.
After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:

     [java] ---- exception report ----------------------------------------------------------
     [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
     [java] Target exception: java.lang.NullPointerException
     [java] Exception: bsh.TargetError
     [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
     [java] ---- stack trace

I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?

Bilgin Ibryam


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1400:
---------------------------------

    Attachment: shipment.patch

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1400:
----------------------------------------

    Assignee: Jacopo Cappellato

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1400:
----------------------------------------

    Assignee: Bilgin Ibryam  (was: Jacopo Cappellato)

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549943 ]

Jacopo Cappellato commented on OFBIZ-1400:
------------------------------------------

Bilgin,

I think that adding a new "Ship Group Seq Id" field in Shipment Plan screen would be the preferred way to go... are you thinking to an hidden field that is populated only if the shipment has a primary order id and primary ship group seq id?

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551144 ]

Bilgin Ibryam commented on OFBIZ-1400:
--------------------------------------

Jacopo,

Thanks for the suggestion. I added the hidden field you proposed and commited in r603765

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1400.
--------------------------------

    Resolution: Fixed

> NullPointerException in Shipment Plan screen
> --------------------------------------------
>
>                 Key: OFBIZ-1400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1400
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipment.patch
>
>
> Hi all,
> This bug appears if you create an order with more than one ship group.
> After the order is created and approved, from order view screens you can create a shipment for specific ship group. For example you can use the following link  "New Shipment For Ship Group [00001] "  . At this stage the shipment is created (for this order and this ship group!) and we can go to Shipment Plan  screen. After entering the orderId and submitting the form we can see ALL THE ITEMS from the order, also the items that does not belongs to this ship group.  If we add items that does not belongs to this ship group, to current shipment plan and use  "Shipment Plan --> Order Items" link the following error is generated:
>      [java] ---- exception report ----------------------------------------------------------
>      [java] WARNING: no cause (from getCause) found for BSH EvalError: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor : at Line: 207 : in file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : new HashMap ( orderItemShipGroupAssoc )
>      [java] Target exception: java.lang.NullPointerException
>      [java] Exception: bsh.TargetError
>      [java] Message: Sourced file: component://product/webapp/facility/WEB-INF/actions/shipment/AddItemsFromOrder.bsh : Typed variable declaration : Object constructor
>      [java] ---- stack trace
> I did a fast fix for this bug so it ignores the items that does not belong to this ship group.
> Another solution could be to add a "Ship Group Seq Id" field in Shipment Plan screen,  so the items will be filtered by orderId AND "Ship Group Seq Id" This way it will be not possible to plan items from another ship group, when the shipment is created for a specific Ship Group. What do you think ?
> Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.