[jira] Created: (OFBIZ-1420) Enable HTML whitespace removal through debug.properties element

[Nicolas Malin (Jira)]

Enable HTML whitespace removal through debug.properties element
---------------------------------------------------------------

                 Key: OFBIZ-1420
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
            Reporter: Adrian Crum
            Priority: Minor
         Attachments: compress_html.patch



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1420:
-------------------------------

    Attachment: compress_html.patch

Attached patch implements a compressHTML property in debug.properties.

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544633 ]

David E. Jones commented on OFBIZ-1420:
---------------------------------------

I'm missing something here... why would this go in debug.properties?

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544634 ]

Adrian Crum commented on OFBIZ-1420:
------------------------------------

Suggest a better place for it and I'll put there.

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1420:
-------------------------------

    Attachment: compress_html.patch

Updated patch uses compress.HTML property in general.properties.

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch, compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544647 ]

David E. Jones commented on OFBIZ-1420:
---------------------------------------

In general all configuration for code should go in the same component as the code. In this case that would be the framework/widget component.

Any breaking of this pattern will eventually need to be undone, or changed to new a pattern should one be established.

In general though the point is that components remain as modular and self-sufficient as possible, even in the framework. Otherwise there is no organization and one never knows where to look for code, configuration, etc.

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch, compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1420:
-------------------------------

    Attachment: compress_html.patch

Updated patch uses compress.HTML property in new file - widget.properties. Also moved widget.verbose setting there.

Third time's a charm? *crosses fingers* ;-)

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: compress_html.patch, compress_html.patch, compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1420:
--------------------------------------

    Assignee: Jacques Le Roux

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: compress_html.patch, compress_html.patch, compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1420.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Adrian,

Your patch is in trunk rev. 598362

I finally uncommented the line widget.verbose=true in widget.properties and put an help in http://docs.ofbiz.org/display/OFBTECH/Apache+OFBiz+Technical+Production+Setup+Guide#ApacheOFBizTechnicalProductionSetupGuide-Widgetssetting

> Enable HTML whitespace removal through debug.properties element
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-1420
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1420
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: compress_html.patch, compress_html.patch, compress_html.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.