[jira] Created: (OFBIZ-1427) Modal windows require keyboard and mouse
Locked
[jira] Created: (OFBIZ-1427) Modal windows require keyboard and mouse
 
|
Modal windows require keyboard and mouse
---------------------------------------- Key: OFBIZ-1427 URL: https://issues.apache.org/jira/browse/OFBIZ-1427 Project: OFBiz Issue Type: Improvement Components: pos Affects Versions: SVN trunk Environment: Any Reporter: Vince Clark Priority: Minor Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1427: -------------------------------------- Assignee: Jacques Le Roux > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Branden Strickland updated OFBIZ-1427: -------------------------------------- Attachment: keyboard.diff Patch to modify Savesale.java Keyboard.java keyaboard.xml Adds button to savesale window to bring up QWERTY keyboard. Haven't gotten cancel to cancel the changes, but I'm working on it. Branden - > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605981#action_12605981 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Hi Branden, I did not try your patch yet, only reviewed, some minor remarks : . Please don't use tabs in code part in your patches (don't worry, it's easy to clean) . For historical reasons in France we use an AZERTY keyboard (http://en.wikipedia.org/wiki/QWERTY) I will add it with a properties to turn it on when needed. I let other cases to other people (http://en.wikipedia.org/wiki/Keyboard_layout, woowww what a planet ;o) ... > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606001#action_12606001 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Some other remarks (I suppose you read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices) . Don't put your reference (name or what else) in the patch . For commentd use simple one eg not //PATCH - importing DeviceLoader for pop.drawer - BSTRICKLAND but // importing DeviceLoader for pop.drawer Imagine if everybody was putting his name in code ;o) There is a duplicated SaveSale.java part in your patch, not sure how this could happen. It seems that a Keyboard class is missing i get this when compiling [javac] ^ [javac] D:\Workspace\ofbiz.pos\specialpurpose\pos\src\org\ofbiz\pos\screen\SaveSale.java:132: cannot find symbol [javac] symbol : class Keyboard [javac] location: class org.ofbiz.pos.screen.SaveSale [javac] Keyboard keyboard = new Keyboard(m_pos); [javac] ^ [javac] D:\Workspace\ofbiz.pos\specialpurpose\pos\src\org\ofbiz\pos\screen\SaveSale.java:132: cannot find symbol [javac] symbol : class Keyboard [javac] location: class org.ofbiz.pos.screen.SaveSale [javac] Keyboard keyboard = new Keyboard(m_pos); [javac] ^ [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 2 errors [javac] 7 warnings BUILD FAILED D:\Workspace\ofbiz.pos\build.xml:131: The following error occurred while executing this line: Moreover, there is already a Keyboard class but without a one parameter constructor. Thanks for your work > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606392#action_12606392 ] Branden Strickland commented on OFBIZ-1427: ------------------------------------------- Would you like me to look into the error? Or have you found my dirty mess and cleaned it up?! :P I'm not sure how the patch file got 2 SaveSales in it. Interesting. I'll have to make sure to review any more work I post up here BEFORE I post it! > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606457#action_12606457 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Yes please, could you look at this error. It should be easier for you as you should have this one parameter constructor for the Keyboard class somewhere...Maybe you simply forgot to put the modified Keyboard .java file in the patch ? > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lombardi updated OFBIZ-1427: ---------------------------------- Attachment: 23June2008_OnScreenKeyboard.patch 23June2008_OnScreenKeyboard.patch changes: Added Uppercase / Lowercase functionality, including single button shift and shift-lock Fixed the behavior of the cancel button Removed unused code and general cleanup Would like to add other layout / language support, need to think more on how to implement that. I haven't looked into BS's added code in SaveSale.java, but thought I would put up what I have as I may not get around to it again this week. > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607738#action_12607738 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Thanks Chris, Your patch is in trunk at revision: 671316. I will certainly do some changes but it's ok for now. I do not close this issue as we will enhance the feature... > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607787#action_12607787 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Branden, Chris, First of all bravo ! Just some minor remarks, . please, don't forget to put ASL2 header at top of new files; . don't use tabs in your code but 4 spaces; . take care of your way of formatting code. Please when you will have a chance read carefully http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html. This link cand be found in red in http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices ;o). . Have a look at revision 671332 commit to see how I modified code from your patch. Thanks and keep on the good work > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608915#action_12608915 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- I have introduced a ShowKeyboardInSaveSale parameters in a new parameters.properties file to allow showing the virtual keyboard or not. Used for the moment in Save Sale screen only. Committed in revision 672390. > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610308#action_12610308 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- I have added the virtual keyboard in Paid In and Paid Out screens as requested initially. I keep this issue open because of the keyboard localisation... > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617308#action_12617308 ] Jacques Le Roux commented on OFBIZ-1427: ---------------------------------------- Due to XUI 800*600 harcoded maxi dialog box size, I introduced a numbers line in revision 680147 + some other changes. > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617308#action_12617308 ] jacques.le.roux edited comment on OFBIZ-1427 at 7/28/08 2:56 AM: ----------------------------------------------------------------- Due to XUI 800*600 harcoded maxi dialog box size, I introduced a numbers line in revision 680147 + some other changes. About XUI 800*600 harcoded maxi dialog box size, see https://issues.apache.org/jira/browse/OFBIZ-1606?focusedCommentId=12614446#action_12614446 was (Author: jacques.le.roux): Due to XUI 800*600 harcoded maxi dialog box size, I introduced a numbers line in revision 680147 + some other changes. > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-1427) Modal windows require keyboard and mouse
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1427. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk I close this issue as I have added a number line above the a alpha keyboard creating a standard alphanum keyboard. I will open a new issue regarding the XUI dialog box issue (max 800*600) > Modal windows require keyboard and mouse > ---------------------------------------- > > Key: OFBIZ-1427 > URL: https://issues.apache.org/jira/browse/OFBIZ-1427 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/pos > Affects Versions: SVN trunk > Environment: Any > Reporter: Vince Clark > Assignee: Jacques Le Roux > Priority: Minor > Fix For: SVN trunk > > Attachments: 23June2008_OnScreenKeyboard.patch, keyboard.diff > > > Modal windows such as "Cash Out" require the use of a keyboard and mouse to enter data because the keypad cannot be accessed for input. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |