[jira] Created: (OFBIZ-1440) Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen

[Nicolas Malin (Jira)]

Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
--------------------------------------------------------------------

                 Key: OFBIZ-1440
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
            Reporter: Jacopo Cappellato


Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId

- add more fields (from the AcctgTrans entity) to the form at the top of the screen
- the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-1440:
-----------------------------------

    Assignee: Anil K Patel

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1440:
-------------------------------

    Attachment: CreateAcctgTrans.patch

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547055 ]

Anil K Patel commented on OFBIZ-1440:
-------------------------------------

Vikas your patch is in svn # 599753. We got a good start. I am keeping this issue open because I think there is lot more that can be done to improve this screen.

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550844 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

I think it is time to prevent the ability to modify an accounting transaction that is posted.
Instead of adding a bunch of use-when in the form definition's fields, I'd suggest that we create two new forms and we add a <section><condition>... area to the screen definition to include the editable or not editable ones according to the isPosted flag.

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550879 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

Another thing I've noticed: in the single form the field "Inventory Item Id" is rendered using a drop down box; since we usually have a huge number of inventory items in the system, we have to change this: a simple input box is fine (or a lookup link).

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550881 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

The following fields, in the single form, should be set with allow-empty="true":

Group Status Id
Fixed Asset Id
Role Type Id

and in the list form below it, also the following field can have an empty value:

Gl Account Id

> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1440:
-------------------------------------

    Summary: UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen  (was: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen)

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554102 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

We should also include in the screens the following fields: glAccountTypeId, origAmount, origCurrencyUomId

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-1440:
------------------------------------------

    Assignee: Ashish Vijaywargiya  (was: Anil K Patel)

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587536#action_12587536 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

Most, if not all, of the issues listed in my previous comments have been fixed, except for this one:

"I think it is time to prevent the ability to modify an accounting transaction that is posted.
Instead of adding a bunch of use-when in the form definition's fields, I'd suggest that we create two new forms and we add a <section><condition>... area to the screen definition to include the editable or not editable ones according to the isPosted flag. "

It would be great to address this last issue and then close the task.

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587741#action_12587741 ]

David E. Jones commented on OFBIZ-1440:
---------------------------------------

It's great to have something in the UI so they know they can't modify a posted transaction.

Are the underlying services also checking for this to enforce it on the server side?

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587879#action_12587879 ]

Jacopo Cappellato commented on OFBIZ-1440:
------------------------------------------

David,

thanks, this is an important point actually.
I've checked the code and unfortunately the flag is not checked by the underlying services.
For this reason, in order to complete the task, we have also to add the logic (and return an error if the transaction has been already posted: AcctgTrans.isPosted==Y) to the following services:

- updateAcctgTrans
- deleteAcctgTrans
- createAcctgTransEntry
- updateAcctgTransEntry
- deleteAcctgTransEntry
- completeAcctgTransEntries

Jacopo

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brajesh Patel updated OFBIZ-1440:
---------------------------------

    Attachment: Review_EditAcctgTrans_Screens_issue.patch

 I have attached patch for this issue please collect this,
 if there is some improvements then let me know.

Brajesh Patel

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch, Review_EditAcctgTrans_Screens_issue.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brajesh Patel updated OFBIZ-1440:
---------------------------------

    Attachment: Review_EditAcctgTrans_Screens_issue.patch

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>         Attachments: CreateAcctgTrans.patch, Review_EditAcctgTrans_Screens_issue.patch, Review_EditAcctgTrans_Screens_issue.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-1440:
----------------------------------

    Assignee: Vikas Mayur  (was: Ashish Vijaywargiya)

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Vikas Mayur
>         Attachments: CreateAcctgTrans.patch, Review_EditAcctgTrans_Screens_issue.patch, Review_EditAcctgTrans_Screens_issue.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-1440.
------------------------------

    Resolution: Fixed

Thanks Brajesh,
Yours patch is in trunk rev 650883.

> UI: Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1440
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1440
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Vikas Mayur
>         Attachments: CreateAcctgTrans.patch, Review_EditAcctgTrans_Screens_issue.patch, Review_EditAcctgTrans_Screens_issue.patch
>
>
> Review/Improve/Cleanup the /accounting/control/EditAcctgTrans screen: you can reach it from Accounting>General Ledger>Accounting>Accounting Transactions>then perform a search and click one of the accctgTransId
> - add more fields (from the AcctgTrans entity) to the form at the top of the screen
> - the form at the top of the screen, and the underlying updateAcctgTrans service, always allows to edit the fields of the AcctgTrans entity (even if the transactions are posted): should we limit this (both at the ui and service level)?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.