[jira] Created: (OFBIZ-1450) allows better testing of testmode from propties file of authorize.net

[Nicolas Malin (Jira)]

allows better testing of testmode from propties file of authorize.net
---------------------------------------------------------------------

                 Key: OFBIZ-1450
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
    Affects Versions: SVN trunk
         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
            Reporter: BJ Freeman


Does more testing of the property to validate if this is in test mode or not.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1450:
------------------------------

    Attachment: authorizenet_istest.patch

patch to allow better evaluation of properites for testmode operation.
Taken from Ver.4.0

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>         Attachments: authorizenet_istest.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1450:
------------------------------

    Attachment: authorizenet_istest.patch

forgot to add the .toUpperCase()

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>         Attachments: authorizenet_istest.patch, authorizenet_istest.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1450:
------------------------------

    Attachment:     (was: authorizenet_istest.patch)

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>         Attachments: authorizenet_istest.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1450:
------------------------------

    Attachment: ver4AutorizenetTestmode.patch

patch for ver 4.0  not an improvement but bug fix.

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>         Attachments: authorizenet_istest.patch, ver4AutorizenetTestmode.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1450:
--------------------------------------

    Assignee: Jacques Le Roux

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>            Assignee: Jacques Le Roux
>         Attachments: authorizenet_istest.patch, ver4AutorizenetTestmode.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1450.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk

Thanks BJ,

Your patches are in
    trunk revisions: 605186, 605190
    release4.0 revisions: 605187, 605189

In later revisions I refactored your code, please follow coding conventions http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices (here was no brackets around blocks)

I also put the uppercase you wrote in release in trunk.

> allows better testing of testmode from propties file of authorize.net
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-1450
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1450
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>         Environment: applications/accounting/src/org/ofbiz/accounting/thirdparty/authorizedotnet/AIMPaymentServices.java
>            Reporter: BJ Freeman
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: authorizenet_istest.patch, ver4AutorizenetTestmode.patch
>
>
> Does more testing of the property to validate if this is in test mode or not.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.