OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

35 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

store/load possibility for AGGREGATED product configurations
------------------------------------------------------------

Key: OFBIZ-1453
URL: https://issues.apache.org/jira/browse/OFBIZ-1453
Project: OFBiz
Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Attachments: aggregated.patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1453:
---------------------------------

Attachment: aggregated.patch

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548189 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Hi all,

this is a full patch ready for review and testing. It allows to save product configuration and restore it later. Here is the stating discussion for it http://www.nabble.com/Enhance-configurable-%28AGGREGATED%29-products-tf4888953.html

I added new configId field to OrderItem, QuoteItem, CustRequestItem, ShoppingListItem and CartAbandonedLine entities.
These are all the places, where products can be added (configurable products could be also added, but w/o saving the configuration, they become useless).
I added also a new field called configId to ProductConfigWrapper class. This field will stores the persisted configuration Id.

How it works:
When user adds the configured product to shopping cart, the configuration is persisted and ProductConfigWrapper.configId gets the configId. Then the configurable product(and its configId) can be added to shopping list, Cust Request, Quote or to CartAbandonedLine entity when session times out, or to orderItem, when order is created. Later, when adding item back to cart (from shopping list, quote, cust request, existing order) the ProductConfigWrapper objct is restored through configId field.
This allows us to edit orders containing configurable products (right now it is not possible!), to create new order from existing one, to create Cust request, then Quote from Cust request...

Future ideas for improvements:
1) When saving the ProductConfigWrapper, it is possible first to check for existing saved configurations, and if they are the same, to return its configId instead of creating new records with the same configuration...
2) It is possible to add products to shopping list directly even w/o shopping cart (for example from party manager screens). There ProductConfigWrapper is not created, and we can create and store the default product configuration. This is dependent from OFBIZ-1393

I'd love to get your feedback.

Regards,
Bilgin Ibryam

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548207 ]

Jacopo Cappellato commented on OFBIZ-1453:
------------------------------------------

Bilgin,

it's great to see implemented this part of the system.
I yet didn't have a chance to review your patch (I will do as soon as I have a free moment) but I think that what you did is interesting.
My only and main concern is that there could be possibly (several) other places where we would need the configId.
For example, what about inventory? And what about inventory reservation routines, picking lists, shipments, returns, work efforts (e.g. production runs)?
My fear is that the configId field could be required potentially everywhere we have a productId.
That is why I also suggested to consider the approach of creating a new product when a new configuration for an aggregate product is needed.
By the way, also this approach has some cons... so I still don't have a strong opinion on the best solution. Maybe what you have implemented is fine.
I'd love to get feedback from others.

Jacopo

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548258 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacopo,

I was thinking that ProductConfigWrapper is needed/used only in order creation routinnes and once the order is created, the production run gets the configuration and issues the needed components for this configuration from inventory. I didnot imagine that configId would be required also in other places.

For now i would like to know is the current patch a right direction to go...

All suggestion are greatly appreciated.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1453:
-------------------------------------

Component/s: product
order

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550963 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

It looks like there are no other opinions :( I really like to work on this task these days.
Is there any opinions for NOT ADDING configId field to all the entities where productId is presented?

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Christopher L

RE: [jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

Thanks for the patch. I like the idea, I haven't looked at the implementation yet. I'll try and take a look today.

Chris

> Date: Wed, 12 Dec 2007 05:21:43 -0800
> From: [hidden email]
> To: [hidden email]
> Subject: [jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations
>
>
> [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550963 ]
>
> Bilgin Ibryam commented on OFBIZ-1453:
> --------------------------------------
>
> It looks like there are no other opinions :( I really like to work on this task these days.
> Is there any opinions for NOT ADDING configId field to all the entities where productId is presented?
>
> > store/load possibility for AGGREGATED product configurations
> > ------------------------------------------------------------
> >
> > Key: OFBIZ-1453
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: order, product
> > Affects Versions: SVN trunk
> > Reporter: Bilgin Ibryam
> > Priority: Minor
> > Fix For: SVN trunk
> >
> > Attachments: aggregated.patch, aggregated_full_for_review.patch
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551726 ]

Jacopo Cappellato commented on OFBIZ-1453:
------------------------------------------

Bilgin,

first of all I'd like to clarify that I'm really happy to see that you are enhancing and completing the AGGREGATE product implementation.
It would be great to get others' opinion on the best way to manage "configurations" in the system, but unfortunately it is a very complex and important decision and I'd say we should wait some more time to let other to elaborate and express the best solution.
It is a difficult one and in fact, even if I'm expressing here some of my opinions, I have to admit that I'm not totally sure about the best solution.

About the need to manage the configurations in inventory (InventoryItem): this could happen if we get a return from a customer; or if we assemble some products and then we can't ship them (for example because the order is cancelled); but there are possibly other scenarios. However, I know that for each of the above situations there are many alternative 'organizational' solutions and not necessarily we will need to store the configId in the InventoryItem.

By the way, here is a possible alternative solution:

1) the configuration is store exactly as you already did
2) instead of adding the configId field to the Order*, Inventory* etc entities, we will add it to the Product entity
3) when an order is created for a new configuration: the configuration is stored with a configId, a new special product is created with the configId set and it is associated to the AGGREGATE product (Product and ProductAssoc); this new productId will be used everywhere (orders, returns, inventory, production runs etc...)
4) it is probably ok to add the configId to the Quote, CustRequest, ShoppingList because we will create the new product only when a real order is created for the configuration

Jacopo

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552289 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

I did not review nor have tested the patch yet. But at first sight Jacopo'sidea of using a specific Product seems good to me.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552289 ]

jacques.le.roux edited comment on OFBIZ-1453 at 12/16/07 1:17 PM:
------------------------------------------------------------------

I did not review nor have tested the patch yet. But at first sight Jacopo'sidea of using a specific Product seems good to me.

Of course I have read the thread and all comments above ;o)

was (Author: jacques.le.roux):
I did not review nor have tested the patch yet. But at first sight Jacopo'sidea of using a specific Product seems good to me.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552292 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacopo, Jacques,

I think you are right, i will give it a try these days.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552938 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacopo, i should listen to your advice from the very beginning.

Updated the patch according to Jacopos alternative solution.

I wrote storeProductConfigWrapper method in hurry,so donot blame me for the ugly code :)
I will be away till next week and If someone is willing to refactor the code is welcome.

Also can someone offer me better name/type/description for the data added to ProductType and ProductAssocType entities ?

I'd love to get feedback

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553580 ]

Jacopo Cappellato commented on OFBIZ-1453:
------------------------------------------

Bilgin,

I did a quick review of your code (no tests) and it seems very good to me; I'd love to get feedback from others too; in the meantime, here are some misc comments:

1) you should create the new product and product assoc by colling the proper services (not directly storing the records in the db)
2) in general, I like the way you have implemented it; it is quite flexible: for example, in the future, we could implement the ability (with a flag somewhere) to define if new productId should be created (to represent the configuration) or not; if we don't want the new product id then we can simply add a condition in the getAggregatedProductId to always return the product id of the original AGGREGATE product and everything should work as expected (of course there will be places where the configuration is not available, for example inventory).

I'll add more comments in the next few days

Jacopo

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554511 ]

Chris Lombardi commented on OFBIZ-1453:
---------------------------------------

I reviewed only the latest patch, and it looks good to me. +1

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1453:
-----------------------------------

Attachment: aggregated_full_for_review.patch

Great work !

I upload some typo and tabs fixes.

I reviewed and tested the patch with a brand new DB (since I found some problems using an older one).

However I tried to duplicate an order from Order Manager (Order View) and I still get this error

2008-01-04 06:20:44,734 (http-0.0.0.0-28443-Processor3) [ShoppingCartServices.java:259:INFO ] Added Payment: 9015 / [no max]
2008-01-04 06:20:44,750 (http-0.0.0.0-28443-Processor3) [ ShoppingCartItem.java:491:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured
correctly.
2008-01-04 06:20:44,765 (http-0.0.0.0-28443-Processor3) [ShoppingCartServices.java:369:ERROR]
---- exception report ----------------------------------------------------------
Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
---- stack trace ---------------------------------------------------------------
org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:492)
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:324)
org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:557)
org.ofbiz.order.shoppingcart.ShoppingCartServices.loadCartFromOrder(ShoppingCartServices.java:364)

I get the same type of error when willing to add to cart (Add All to Cart) from eCommerce (from Shopping lists too).

Something to note : when you add a configured item to a shopping list you end with the default configuration in any cases.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
> Key: OFBIZ-1453
> URL: https://issues.apache.org/jira/browse/OFBIZ-1453
> Project: OFBiz
> Issue Type: Improvement
> Components: order, product
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.