[jira] Created: (OFBIZ-1453) store/load possibility for AGGREGATED product configurations

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1453:
---------------------------------

    Attachment: aggregated_full_for_review.patch

Chris, Jacques, thanks for testing the patch!

Jacques,

I noticed that you also replaced the tabs inserted after the file name before the revision number, for example: ProductConfigWorker.java    (revision 606901) . Is it required? I ask this because i noticed that eclipse always insert these tabs in patches, but when applying the patch, tabs do not affect anything.

I tested lots of different configurations but could not reproduce the bugs you described! Could you tell more details how you got them? Is it possible that you created the order or added products to shopping list before applying the patch (in this case the order items and shopping lists items are created w/o saved configuration)?

Also what you mean with "you end with the default configuration in any cases" I could not reproduce it too :)
I am not sure that this is the case, but if you expected to see the configured product in the cart, for now it is not possible and there is another issue for it:OFBIZ-1528. Even that the product is configured (you can notice it from its price) in the cart the products looks like with default configuration.

I fixed one more bug and updated the patch.

Thank you for your tests and bug reports.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1453:
---------------------------------

    Attachment: aggregated_full_for_review.patch

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555922#action_12555922 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

Bilgin,

Tabs inserted after the file name before the revision number :  not at all, it's just that I replaced all tabs in Scite (my prefered out-of-Eclipse Editor). There were a couple of them in code.

I load your new patch an retry it in a clean instance and will let you know...

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555996#action_12555996 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

Bilgin,

What I (re-)did
. Created a new PostGres DB
. Applied the patch (after having reverted previous one) on a slightly modified instance (ports changed, and some config stuffes not related to our issue)
. Ant run-install
. Created an order using Enchiladas in eCommerce (setting some options)

Maybe I missed something, but when I want to create an order from this existing order (in Order View) it appears that in line 348 of ShoppingCartServices the product type is AGGREGATED and not AGGREGATED_CONF hence configId is null and as a consequence the warn arises.

ShoppingCartItem.java:491:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.

You get the same problem when trying to add to cart from an existing order in eCommerce.

I tried to set Enchiladas as a "Configurable Good Configuration" but then it's not configurable anymore in eCommerce.

About "you end with the default configuration in any cases", I mean that when you put a configured item in a shopping list from configuration screen in eCommerce you do not get the configuration you settled but the default one (actually you get the base product with its base price). Maybe this is more related to  OFBIZ-1495 though...

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557254#action_12557254 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacques,

I fixed the bugs you described (Could you confirm this, please). You were right about them!

The only bug that i cannot reproduce is "create an order from this existing order (in Order View) " It works for me w/o errors.
In line 348 of ShoppingCartServices the product type *should be * AGGREGATED_CONF, because during order creation AGGREGATED products are replaced by AGGREGATED_CONF typed products, and orderItems are AGGREGATED_CONF. So in ShoppingCartServices.loadCartFromOrder() the product can not be AGGREGATED_CONF.  I do not know how you got an AGGREGATED product in OrderItems.

Also fixed the "you end with the default configuration in any cases" bug. But after the product is configured, before adding to shopping list is required to use "Verify Configuration" button. This should be replaced by an ajax event in the future.

Thanks for your help.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1453:
---------------------------------

    Attachment: aggregated_full_for_review.patch

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557367#action_12557367 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

Bilgin,

I suppose you did not test this patch

    protected double defaultPrice = 0.0;
was missing in ProductConfigWrapper

            String sequenceNum = null;
Should be
            Long sequenceNum = null;

in ProductConfigWorker.java and ProductConfigWrapper.java (and related changes)

The error you can't reproduce is still there :

2008-01-09 19:13:31,406 (http-0.0.0.0-28443-Processor3) [   ShoppingCartItem.java:491:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured
correctly.
2008-01-09 19:13:31,421 (http-0.0.0.0-28443-Processor3) [ShoppingCartServices.java:369:ERROR]
---- exception report ----------------------------------------------------------
Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
---- stack trace ---------------------------------------------------------------
org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:492)
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:324)
org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:557)
org.ofbiz.order.shoppingcart.ShoppingCartServices.loadCartFromOrder(ShoppingCartServices.java:364)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:96)
org.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:54)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:375)
org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:208)
org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
org.ofbiz.order.shoppingcart.ShoppingCartEvents.loadCartFromOrder(ShoppingCartEvents.java:1234)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:585)
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:88)
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:74)
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:454)
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:281)
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:193)
javax.servlet.http.HttpServlet.service(HttpServlet.java:595)
javax.servlet.http.HttpServlet.service(HttpServlet.java:688)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:248)
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:542)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
java.lang.Thread.run(Thread.java:595)
--------------------------------------------------------------------------------

2008-01-09 19:13:31,421 (http-0.0.0.0-28443-Processor3) [  ServiceDispatcher.java:513:ERROR] Error in Service [loadCartFromOrder]: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.

I stopped to test at this stage...

Thanks for your time

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557607#action_12557607 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacques,

I tested the patch before attaching.
 protected double defaultPrice = 0.0;  is (still)  not a field of ProductConfigWrapper.java in trunk. I suppose you applied locally the patch from OFBIZ-1495. Thats why you have it.
I replaced String sequenceNum with Long.

I create orders from order manager and ecommerce and then use "Create As New Order" links works any w/o errors.
Could you create a new order and try it.
If you get again this error, i'd like to know:
1. the productIds in the order
2. if the product is AGGREGATED or AGGREGATED_CONF, then is there a value in Product.configId field.

But i am sure you will not get the error :)

If the errors are gone, i'd like to know is this patch could be commited? If yes then i will work on production run, return, inventory part of it....

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1453:
---------------------------------

    Attachment: aggregated_full_for_review.patch

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557699#action_12557699 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

Bilgin,

Sorry for the defaultPrice miss.

I tested order creation from order view and yes you are right it works now, other cases also :o)

Before commiting the patch I would like to know if it's normal that when you put the cart content in a shopping list you get the defaut config and not the config you set in cart ?

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557701#action_12557701 ]

Jacques Le Roux commented on OFBIZ-1453:
----------------------------------------

Mmm... but Bilgin you are able to commit in application now isn' it ? ;o) In such case don't forget to update before since I have commited related patches.

Thanks for the good work !

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1453:
------------------------------------

    Assignee: Bilgin Ibryam

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557728#action_12557728 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

Jacques, thank you for testing and for the feedback.

ShoppingListItems should get the configuration of cartItems, not the default one. I will check it (again).

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557973#action_12557973 ]

Bilgin Ibryam commented on OFBIZ-1453:
--------------------------------------

The first rule from General Responsibilities of Committers says "first do no harm".
That's why I think there is one more thing to add to this patch before committing it.

Currently, createProductionRunFromConfiguration service creates a production run for every ordered AGGREGATED product and after completing the production run the AGGREGATED product is added to inventory.

But after applying this patch, the AGGREGATED products will be replaced by a new AGGREGATED_CONF type products, and the order is created for these new products.

So i think to do the following:
1. while creating and associating the new AGGREGATED_CONF, also copy the ROU_PROD_TEMPLATE from AGGREGATED product:

Example: while ordering PC001, create new product, associate it the PC001, and create a new WorkEffortGoodStandard for the new product, by copying it from PC001
    <WorkEffortGoodStandard workEffortId="ROUT01" productId="PC001" workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED" fromDate="2004-09-24 15:10:14.227"/>

    <WorkEffortGoodStandard workEffortId="ROUT01" productId="newProductId" workEffortGoodStdTypeId="ROU_PROD_TEMPLATE" statusId="WEGS_CREATED" fromDate="2004-09-24 15:10:14.227"/>

2. Do a small change in createProductionRunFromConfiguration service for calling createProductionRun service with the new AGGREGATED_CONF productId.

What do you think ?
I'd love to know also Jacopo's opinion on this.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1453.
--------------------------------

    Resolution: Fixed

I modified the patch as mentioned above (point 1 and 2) and finally committed to trunk r613216.
Thank you all for helping me.

> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch, aggregated_full_for_review.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.