[jira] Created: (OFBIZ-1465) JUnit Test Case fro "Receive Other Shipment"

[Nicolas Malin (Jira)]

JUnit Test Case fro "Receive Other Shipment"
--------------------------------------------

                 Key: OFBIZ-1465
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Vikas Mayur




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1465:
-------------------------------

    Attachment: ReceiveOtherShipmentTest.patch

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Vikas Mayur
>         Attachments: ReceiveOtherShipmentTest.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547461 ]

Vikas Mayur commented on OFBIZ-1465:
------------------------------------

Patch from Shubham Goyal

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Vikas Mayur
>         Attachments: ReceiveOtherShipmentTest.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1465:
-------------------------------

    Description: Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Vikas Mayur
>         Attachments: ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1465:
----------------------------------

          Component/s: product
        Fix Version/s: SVN trunk
             Assignee: Marco Risaliti
             Priority: Minor  (was: Major)
    Affects Version/s: SVN trunk

May I can test and then commit ?

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shubham Goyal updated OFBIZ-1465:
---------------------------------

    Attachment: ReceiveOtherShipmentTest.patch

Here is the updated patch.

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560315#action_12560315 ]

Jacques Le Roux commented on OFBIZ-1465:
----------------------------------------

Shubham,

ReceiveOtherShipmentTest.java is missing ASL2 header, else sounds good but not tested

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560329#action_12560329 ]

Marco Risaliti commented on OFBIZ-1465:
---------------------------------------

Hi Shubham,

From previously emails from David Jones it was better to use simple methods service instead of java service.
So could you please convert it to simple methods as Vikas has done into the issue OFBIZ-1468 and then I can review and commit it.
As Jacques suggested please remember to include the ASL2 header on new files into the patch.

Thanks
Marco

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560337#action_12560337 ]

Shubham Goyal commented on OFBIZ-1465:
--------------------------------------

Hi Jacques,

Mistakenly I forgot to add ASL2 header. I will add it and convert Java Service into Simple method as Marco suggested me. Thanks to both of you.

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shubham Goyal updated OFBIZ-1465:
---------------------------------

    Attachment: ReceiveOtherShipmentTest.patch

I have converted Java Service into Simple Method.

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563394#action_12563394 ]

Jacques Le Roux commented on OFBIZ-1465:
----------------------------------------

Reviewed (no tested) looks good to me. Thanks Shubham

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570685#action_12570685 ]

Shubham Goyal commented on OFBIZ-1465:
--------------------------------------

I have tested it extensively, it's working fine.

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-1465.
---------------------------------

    Resolution: Fixed

Thanks Shubham Goyal,

Your patch is in trunk rev. 642365.

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

parimal gain updated OFBIZ-1465:
--------------------------------

    Attachment: ReceiveOtherShipmentTest.patch

Here I have prepared demo shipment data for Automation of this test Case.

Thanks to Ratnesh Upadhyay for helping.

Thanks & Regards
- Parimal Gain

> JUnit Test Case fro "Receive Other Shipment"
> --------------------------------------------
>
>                 Key: OFBIZ-1465
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1465
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch, ReceiveOtherShipmentTest.patch
>
>
> Followed the process from http://docs.ofbiz.org/display/OFBENDUSER/Receive+Other+Shipment

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.