[jira] Created: (OFBIZ-1467) JUNIT test case for finding and editing a party(DemoCustomer)

[Nicolas Malin (Jira)]

 JUNIT test case for finding and editing a party(DemoCustomer)
--------------------------------------------------------------

                 Key: OFBIZ-1467
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
             Project: OFBiz
          Issue Type: Sub-task
            Reporter: Vikas Mayur
         Attachments: find_edit_party.patch



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1467:
-------------------------------

    Attachment: find_edit_party.patch

Patch from Santosh Malviya

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Vikas Mayur
>         Attachments: find_edit_party.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1467:
-------------------------------

    Description: Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>            Reporter: Vikas Mayur
>         Attachments: find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-1467:
----------------------------------

          Component/s: party
        Fix Version/s: SVN trunk
             Assignee: Marco Risaliti
             Priority: Minor  (was: Major)
    Affects Version/s: SVN trunk

May I can test and then commit ?

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570694#action_12570694 ]

Ratnesh Upadhyay commented on OFBIZ-1467:
-----------------------------------------

I have tested it extensively and it is working fine.

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573188#action_12573188 ]

Vikas Mayur commented on OFBIZ-1467:
------------------------------------

I think instead of Updating information on party DemoCustomer, we should create a test data probably with reader-name="test" and use that data to find, update information.
Any Thoughts ?

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santosh Malviya updated OFBIZ-1467:
-----------------------------------

    Attachment: find_edit_party.patch

I have  converted Java services into minilang.
Thanks to Brajesh Patel for discussion on the issue.

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1467:
----------------------------------

    Attachment: find_edit_party.patch

Done some modification in last uploaded patch :
1) . Put some condition in assert tag.
2). Changed some services from last uploaded patch which is not participating in process .


Thanks to Ratnesh Upadhyay for helping.
Thanks and Regards,
-Awdesh Parihar

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1467:
----------------------------------

    Attachment: find_edit_party.patch

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur reassigned OFBIZ-1467:
----------------------------------

    Assignee: Vikas Mayur  (was: Marco Risaliti)

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601541#action_12601541 ]

Vikas Mayur commented on OFBIZ-1467:
------------------------------------

Awdesh - patch looks good.

One change that I would like to propose is to use PartyWorker or ContactHelper methods to fetch contactMechId's for updating postal, telecom, email address etc. instead of using constant values.
This way test case will also work if it is run more than once.

- Vikas

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awdesh Parihar updated OFBIZ-1467:
----------------------------------

    Attachment: find_edit_party.patch

Thanks Vikas
In this patch I followed your suggestion and used PartyWorker methods to fetch contactMechId's for updating postal, telecom, email address .

Thanks to Ratnesh Upadhyay for helping.
Thanks and Regards,
-Awdesh Parihar

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur closed OFBIZ-1467.
------------------------------

    Resolution: Fixed

Thanks Awdesh, Ratnesh, Santosh and others,

Patch along with few modifications is in trunk rev. 663913

- Vikas

>  JUNIT test case for finding and editing a party(DemoCustomer)
> --------------------------------------------------------------
>
>                 Key: OFBIZ-1467
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1467
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: Vikas Mayur
>            Assignee: Vikas Mayur
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch, find_edit_party.patch
>
>
> Followed the process from link http://docs.ofbiz.org/display/OFBENDUSER/Find+and+Edit+Customer

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.