[jira] Created: (OFBIZ-1472) Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance

[Nicolas Malin (Jira)]

Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
--------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1472
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
            Reporter: Jacopo Cappellato


Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
Service definition:
    <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
        location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
        <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
        <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
        <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
    </service>

Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
1) replace shipmentId with fixedAssetId
2) do not set partyId and roleTypeId
3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)

The seca will be:

    <eca service="createItemIssuance" event="commit">
        <condition field-name="fixedAssetId" operator="is-not-empty"/>
        <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
    </eca>


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranay Pandey updated OFBIZ-1472:
---------------------------------

    Attachment: CreateAcctgTransForFixedAssetMaintIssuance.patch

Here is the patch attached for this issue.
I have one question :
Is there any special purpose behind commenting the following service resource entry in ofbiz-componenet.xml
<!--<service-resource type="eca" loader="main" location="servicedef/secas_ledger.xml"/>-->

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548097 ]

Pranay Pandey commented on OFBIZ-1472:
--------------------------------------

for running this service the commented code given earlier needs to be uncommented.

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548153 ]

Jacopo Cappellato commented on OFBIZ-1472:
------------------------------------------

Pranay,

yes, that line needs to be uncommented to activate GL auto posting services. For now we are keeping them disabled because the family of auto posting service is still incomplete, but very soon (maybe at the end of the week) I guess we could consider to uncomment it (you are all doing a great job and you are very fast).

Jacopo

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548155 ]

Ashish Vijaywargiya commented on OFBIZ-1472:
--------------------------------------------

Pranay,

I think you had swaped the entry for "glAccountTypeId".
Please read the task details again and do the necessary changes in the next patch.

--
Ashish

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548298 ]

Pranay Pandey commented on OFBIZ-1472:
--------------------------------------

Ashish,

The template service given in this task is "createAcctgTransForSalesShipmentIssuance", and in this the debit glAccountTypeId is COGS_ACCOUNT that's why i have swaped the entry for "glAccountTypeId", so i think that in the service "createAcctgTransForFixedAssetMaintIssuance" the debit glAccountTypeId will be FIXED_ASSET_MAINT.
--
Pranay

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-1472:
-----------------------------------

    Assignee: Anil K Patel

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-1472.
-------------------------------

    Resolution: Fixed

Thanks to Pranay Panday and others for providing implementation. Patch rev # 601855

> Implement an automatic GL posting service triggered when inventory is issued for fixed asset maintenance
> --------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1472
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1472
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: CreateAcctgTransForFixedAssetMaintIssuance.patch
>
>
> Name of the service: "createAcctgTransForFixedAssetMaintIssuance" or similar
> Service definition:
>     <service name="createAcctgTransForFixedAssetMaintIssuance" engine="simple"  auth="true"
>         location="org/ofbiz/accounting/ledger/GeneralLedgerServices.xml" invoke="createAcctgTransForFixedAssetMaintIssuance">
>         <description>Create an accounting transaction for inventory that is issued for fixed asset maintenance (Type: INVENTORY D: INVENTORY_ACCOUNT, C: FIXED_ASSET_MAINT)</description>
>         <attribute name="itemIssuanceId" type="String" mode="IN" optional="false"/>
>         <attribute name="acctgTransId" type="String" mode="OUT" optional="true"/>
>     </service>
> Use as a template the service "createAcctgTransForSalesShipmentIssuance". The new service will be very similar, with the following differences:
> 1) replace shipmentId with fixedAssetId
> 2) do not set partyId and roleTypeId
> 3) the Credit glAccountTypeId is FIXED_ASSET_MAINT (and not COGS_ACCOUNT)
> 4) the acctgTransTypeId is INVENTORY (and not SALES_SHIPMENT)
> The seca will be:
>     <eca service="createItemIssuance" event="commit">
>         <condition field-name="fixedAssetId" operator="is-not-empty"/>
>         <action service="createAcctgTransForFixedAssetMaintIssuance" mode="sync"/>
>     </eca>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.