[jira] Created: (OFBIZ-1499) When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.

[Nicolas Malin (Jira)]

When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
--------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1499
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
             Project: OFBiz
          Issue Type: Improvement
          Components: order
    Affects Versions: SVN trunk
            Reporter: Sumit Pandit
            Priority: Trivial
             Fix For: SVN trunk


1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1499:
--------------------------------

    Attachment: surveyProduct.patch

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1499:
--------------------------------

    Description:
1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)

Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

  was:
1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1499:
--------------------------------

    Attachment: surveyProduct.patch

Remove some unnecessary if statements from the code.

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1499:
------------------------------------

    Assignee: Bilgin Ibryam

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552385 ]

Bilgin Ibryam commented on OFBIZ-1499:
--------------------------------------

Hi Sumit,

I like your idea to pass surveyResponseId to calculateProductPrice and then to the customMethod

I got a question about these lines:
+                if (UtilValidate.isEmpty(surveyResponseId) && paramMap.containsKey("surveyResponseId")) {
+                    surveyResponseId = (String) paramMap.get("surveyResponseId");   // if SurveyResponceId is not getting from attribute then we can try to access it from paramMap.
+                }

Are there situations where surveyResponseId is not presented in requestAttributes, but exist in requestParameters?

One more thing: It is very important to document your code, but also i would recommend you to keep in mind this: *Document why something is being done, not just what.*

Thank you for your work.

Bilgin

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553248 ]

Sumit Pandit commented on OFBIZ-1499:
-------------------------------------

Hi Bilgin

Thanks for assign it to yourself and put comments.

Yes you are right about surveyResponceId,  it is always available in request. I am sorry for it. I need to remove it from patch. Updated code is in new patch.
But it is avail in parameters also.

Regarding to the comments these are only for Committees reference not for commit (Now discuss  on it is worth since it is not in new patch).

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1499:
--------------------------------

    Attachment: surveyProduct.patch

Modify according to the Bilgin Comments

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553248 ]

sumitp edited comment on OFBIZ-1499 at 12/18/07 11:22 PM:
----------------------------------------------------------------

Hi Bilgin

Thanks for assign it to yourself and put comments.

Yes you are right about surveyResponceId,  it is always available in request. I am sorry for it. I need to remove it from patch. Updated code is in new patch.
But it is avail in parameters also.

Regarding to the comments(// if SurveyResponceId is not getting from attribute then we can try to access it from paramMap.) these are only for Committers reference not for commit (Now discuss  on it is worth since it is not in new patch).

      was (Author: sumitp):
    Hi Bilgin

Thanks for assign it to yourself and put comments.

Yes you are right about surveyResponceId,  it is always available in request. I am sorry for it. I need to remove it from patch. Updated code is in new patch.
But it is avail in parameters also.

Regarding to the comments these are only for Committees reference not for commit (Now discuss  on it is worth since it is not in new patch).
 

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam closed OFBIZ-1499.
--------------------------------

    Resolution: Fixed

Thank Sumit.
Your patch is in trunk revision 606792.

Please, next time add references for commiters to the jira issue, and create the patch as ready for commit when possible :)

> When survey products are added to the cart then displaying survey price in the cart and adding it to the cart total.
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1499
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1499
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sumit Pandit
>            Assignee: Bilgin Ibryam
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: surveyProduct.patch, surveyProduct.patch, surveyProduct.patch
>
>
> 1) Set  surveyResponseId in service :- calculateProductPrice(services_pricepromo.xml)
> 2) Pass surveyResponseId  with inMap in calculateProductPrice method (PriceServices.java)
> Thanks to Anil Patel & Sumit Porwal for helping me in implementing this changes.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.