[jira] Created: (OFBIZ-1537) Form Widget: using the request parameters causes problems for some forms

[Nicolas Malin (Jira)]

Form Widget: using the request parameters causes problems for some forms
------------------------------------------------------------------------

                 Key: OFBIZ-1537
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1537
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Scott Gray
            Priority: Minor
             Fix For: SVN trunk


If a form is being rendered with an error message present in the context then the form fields try to get their value from the request parameters before the default map.  That is used to refill a form for the user so that they can correct any problems.

This causes problems for forms that aren't intended to be edited by the user, but exist solely for display purposes.  I've attached a screenshot that shows the problem clearly, note the statusId value in the url and in the Payment Header box.  The actual current status for the payment is Not Paid (PMNT_NOT_PAID)





--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray updated OFBIZ-1537:
------------------------------

    Attachment: screenshot-1.jpg

> Form Widget: using the request parameters causes problems for some forms
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>
> If a form is being rendered with an error message present in the context then the form fields try to get their value from the request parameters before the default map.  That is used to refill a form for the user so that they can correct any problems.
> This causes problems for forms that aren't intended to be edited by the user, but exist solely for display purposes.  I've attached a screenshot that shows the problem clearly, note the statusId value in the url and in the Payment Header box.  The actual current status for the payment is Not Paid (PMNT_NOT_PAID)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553628 ]

Scott Gray commented on OFBIZ-1537:
-----------------------------------

I'm thinking that the best way to fix this is to only use the request parameters when there is an error for form fields that are editable, any opinions?

> Form Widget: using the request parameters causes problems for some forms
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>
> If a form is being rendered with an error message present in the context then the form fields try to get their value from the request parameters before the default map.  That is used to refill a form for the user so that they can correct any problems.
> This causes problems for forms that aren't intended to be edited by the user, but exist solely for display purposes.  I've attached a screenshot that shows the problem clearly, note the statusId value in the url and in the Payment Header box.  The actual current status for the payment is Not Paid (PMNT_NOT_PAID)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566439#action_12566439 ]

Jacques Le Roux commented on OFBIZ-1537:
----------------------------------------

It seems better to me too, I did not look in code.

> Form Widget: using the request parameters causes problems for some forms
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1537
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1537
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: screenshot-1.jpg
>
>
> If a form is being rendered with an error message present in the context then the form fields try to get their value from the request parameters before the default map.  That is used to refill a form for the user so that they can correct any problems.
> This causes problems for forms that aren't intended to be edited by the user, but exist solely for display purposes.  I've attached a screenshot that shows the problem clearly, note the statusId value in the url and in the Payment Header box.  The actual current status for the payment is Not Paid (PMNT_NOT_PAID)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.