[jira] Created: (OFBIZ-1563) Re-Factor Party CommunicationEvent permissions to follow new patterns.

[Nicolas Malin (Jira)]

Re-Factor Party CommunicationEvent permissions to follow new patterns.
----------------------------------------------------------------------

                 Key: OFBIZ-1563
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
             Project: OFBiz
          Issue Type: Improvement
          Components: party
            Reporter: Abhijit Meshram




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Abhijit Meshram updated OFBIZ-1563:
-----------------------------------

    Attachment: partymgr_security.patch

Refactor the Party CommunicationEvent permission to follow up new pattern. Please have a look at this patch and suggest if it needs some modification.

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>         Attachments: partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Abhijit Meshram updated OFBIZ-1563:
-----------------------------------

    Attachment: partymgr_security.patch

Minor changes.

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>         Attachments: partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Abhijit Meshram updated OFBIZ-1563:
-----------------------------------

    Attachment: partymgr_security.patch

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1563:
-------------------------------

    Priority: Minor  (was: Major)

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-1563:
----------------------------------

    Assignee: Adrian Crum

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Adrian Crum
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557873#action_12557873 ]

Jacques Le Roux commented on OFBIZ-1563:
----------------------------------------

Thanks Abhijit ,

This looks good to me (only reviewed not tested yet).

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1563.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux  (was: Adrian Crum)

Thanks Abhijit,

Your patch is in trunk revision: 611236  

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558139#action_12558139 ]

Jacques Le Roux commented on OFBIZ-1563:
----------------------------------------

Abhijit,

In rev. 611257 I reverted a change from my previous commit 611236 since in this particular case creation is allowed for him/herself, see implementation.
I don't know if there is a better way (generalised) to deal with such cases so for now I simply reverted.

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558149#action_12558149 ]

Adrian Crum commented on OFBIZ-1563:
------------------------------------

Check  PartyPermissionServices.xml for the partyIdPermissionCheck method.

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558161#action_12558161 ]

Jacques Le Roux commented on OFBIZ-1563:
----------------------------------------

Thanks Adrian,

in trunk 611330

> Re-Factor Party CommunicationEvent permissions to follow new patterns.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-1563
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1563
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>            Reporter: Abhijit Meshram
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: partymgr_security.patch, partymgr_security.patch, partymgr_security.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.