[jira] Created: (OFBIZ-1568) if salesDiscWhenNotAvail field on variant is empty take the value from the virtual

[Nicolas Malin (Jira)]

if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
----------------------------------------------------------------------------------

                 Key: OFBIZ-1568
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1568
             Project: OFBiz
          Issue Type: New Feature
          Components: product
    Affects Versions: SVN trunk
            Reporter: Hans Bakker
         Attachments: discVirtual.diff

The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product.

Please let me know about any objections otherwise i will commit the attached path in a couple of days.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-1568:
-------------------------------

    Attachment: discVirtual.diff

> if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1568
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1568
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>         Attachments: discVirtual.diff
>
>
> The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product.
> Please let me know about any objections otherwise i will commit the attached path in a couple of days.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557872#action_12557872 ]

Jacques Le Roux commented on OFBIZ-1568:
----------------------------------------

+1 for the idea (cursory review ok)

Jacques

> if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1568
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1568
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>         Attachments: discVirtual.diff
>
>
> The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product.
> Please let me know about any objections otherwise i will commit the attached path in a couple of days.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-1568.
------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

implemented in revision 611121

> if salesDiscWhenNotAvail field on variant is empty take the value from the virtual
> ----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1568
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1568
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Hans Bakker
>             Fix For: SVN trunk
>
>         Attachments: discVirtual.diff
>
>
> The service checkProductInventoryDiscontinuation only checkes the field salesDiscWhenNotAvail on the actual product. The attached patch changes this behaviour that is the field is empty the system will look on the vitual product.
> Please let me know about any objections otherwise i will commit the attached path in a couple of days.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.