OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

Process order payment doesn't check for cancelled/rejected order (patch)
------------------------------------------------------------------------

Key: OFBIZ-1573
URL: https://issues.apache.org/jira/browse/OFBIZ-1573
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Reporter: Wickersheimer Jeremy
Priority: Minor
Fix For: SVN trunk

The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.

There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

> Process order payment doesn't check for cancelled/rejected order (patch)
> ------------------------------------------------------------------------
>
> Key: OFBIZ-1573
> URL: https://issues.apache.org/jira/browse/OFBIZ-1573
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: 1573.patch
>
>
> The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
> Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.
> There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1573.
----------------------------------

Resolution: Fixed
Assignee: Jacques Le Roux

Thanks Jeremy,

Your patch is in trunk rev. 611313

> Process order payment doesn't check for cancelled/rejected order (patch)
> ------------------------------------------------------------------------
>
> Key: OFBIZ-1573
> URL: https://issues.apache.org/jira/browse/OFBIZ-1573
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: 1573.patch
>
>
> The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
> Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.
> There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wickersheimer Jeremy updated OFBIZ-1573:
----------------------------------------

Attachment: 1573-2.patch

Si Chen suggested that we should returnFailure instead of returnSuccess in that case.
I also think this is cleaner, so here is the small patch.

> Process order payment doesn't check for cancelled/rejected order (patch)
> ------------------------------------------------------------------------
>
> Key: OFBIZ-1573
> URL: https://issues.apache.org/jira/browse/OFBIZ-1573
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: 1573-2.patch, 1573.patch
>
>
> The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
> Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.
> There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559153#action_12559153 ]

Jacques Le Roux commented on OFBIZ-1573:
----------------------------------------

I plenty agree : trunk rev. 612179

> Process order payment doesn't check for cancelled/rejected order (patch)
> ------------------------------------------------------------------------
>
> Key: OFBIZ-1573
> URL: https://issues.apache.org/jira/browse/OFBIZ-1573
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: 1573-2.patch, 1573.patch
>
>
> The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
> Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.
> There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.