[jira] Created: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Nicolas Malin (Jira)
Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items
------------------------------------------------------------------------------------

                 Key: OFBIZ-159
                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
             Project: OFBiz (The Open for Business Project)
          Issue Type: New Feature
          Components: order
         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
            Reporter: Tim Ruppert
         Attachments: suggestionList.patch

The goal here is to create an "Auto Suggestions" Shopping List for users based upon cross sell product associations.

If a product has cross sell associations, or if the product is a variant and it's virtual product has cross sell products, we create an "Auto Suggestion" Shopping List with the associated products - if it is not already there.  If it's there, add the cross sell products to the "Auto Suggestion" Shopping List.

There needs to be a Product Store flag that allows people to configure this option.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-159?page=comments#action_12428519 ]
           
Jacques Le Roux commented on OFBIZ-159:
---------------------------------------

This is interesting indeed, I vote for. No review yet.

> Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-159
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: order
>         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
>            Reporter: Tim Ruppert
>         Attachments: suggestionList.patch
>
>
> The goal here is to create an "Auto Suggestions" Shopping List for users based upon cross sell product associations.
> If a product has cross sell associations, or if the product is a variant and it's virtual product has cross sell products, we create an "Auto Suggestion" Shopping List with the associated products - if it is not already there.  If it's there, add the cross sell products to the "Auto Suggestion" Shopping List.
> There needs to be a Product Store flag that allows people to configure this option.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-159?page=all ]

David E. Jones closed OFBIZ-159.
--------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: David E. Jones

Thanks Tim, this is now in SVN, rev 432136. I also added the ProductStore flag to turn it on/off.

> Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-159
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: order
>         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: suggestionList.patch
>
>
> The goal here is to create an "Auto Suggestions" Shopping List for users based upon cross sell product associations.
> If a product has cross sell associations, or if the product is a variant and it's virtual product has cross sell products, we create an "Auto Suggestion" Shopping List with the associated products - if it is not already there.  If it's there, add the cross sell products to the "Auto Suggestion" Shopping List.
> There needs to be a Product Store flag that allows people to configure this option.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-159?page=comments#action_12428693 ]
           
Tim Ruppert commented on OFBIZ-159:
-----------------------------------

Unfortunately - I think we'll have to reopen this one.  I noticed when looking at the update that I provided that I had neglected to remove the log messages.  If someone can update this I would greatly appreciate it.

> Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-159
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: New Feature
>          Components: order
>         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
>            Reporter: Tim Ruppert
>         Assigned To: David E. Jones
>             Fix For: SVN trunk
>
>         Attachments: suggestionList.patch
>
>
> The goal here is to create an "Auto Suggestions" Shopping List for users based upon cross sell product associations.
> If a product has cross sell associations, or if the product is a variant and it's virtual product has cross sell products, we create an "Auto Suggestion" Shopping List with the associated products - if it is not already there.  If it's there, add the cross sell products to the "Auto Suggestion" Shopping List.
> There needs to be a Product Store flag that allows people to configure this option.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Tim Ruppert
I couldn't attach the patch to it, so I'm attaching it here.  Should I
create a sub-task or clone the issue when this happens in the future?

--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

Tim Ruppert (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/OFBIZ-159?page=comments#action_12428693 ]
>            
> Tim Ruppert commented on OFBIZ-159:
> -----------------------------------
>
> Unfortunately - I think we'll have to reopen this one.  I noticed when looking at the update that I provided that I had neglected to remove the log messages.  If someone can update this I would greatly appreciate it.
>
>  
>> Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items
>> ------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-159
>>                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
>>             Project: OFBiz (The Open for Business Project)
>>          Issue Type: New Feature
>>          Components: order
>>         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
>>            Reporter: Tim Ruppert
>>         Assigned To: David E. Jones
>>             Fix For: SVN trunk
>>
>>         Attachments: suggestionList.patch
>>
>>
>> The goal here is to create an "Auto Suggestions" Shopping List for users based upon cross sell product associations.
>> If a product has cross sell associations, or if the product is a variant and it's virtual product has cross sell products, we create an "Auto Suggestion" Shopping List with the associated products - if it is not already there.  If it's there, add the cross sell products to the "Auto Suggestion" Shopping List.
>> There needs to be a Product Store flag that allows people to configure this option.
>>    
>
>  

Index: applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml
===================================================================
--- applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml (revision 432282)
+++ applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml (working copy)
@@ -175,19 +175,16 @@
 
     <simple-method method-name="addDistinctShoppingListItem"
                    short-description="Adds a shopping list item if one with the same productId does not exist">
-        <log level="info" message="In addDistinctShoppingListItem" />
         <entity-condition entity-name="ShoppingListItem" list-name="shoppingListItemList">
             <condition-expr field-name="shoppingListId" env-name="parameters.shoppingListId" />
         </entity-condition>
 
         <iterate list-name="shoppingListItemList" entry-name="shoppingListItem">
             <if-compare-field field-name="parameters.productId" operator="equals" to-field-name="shoppingListItem.productId">
-                <log level="info" message="In shopingListItem ${shoppingListItem.productId}" />
                 <field-to-result field-name="shoppingListItem.shoppingListItemSeqId" result-name="shoppingListItemSeqId" />
                 <return />
             </if-compare-field>
         </iterate>
-        <log level="info" message="Right before createShoppingListItem" />
         <call-service service-name="createShoppingListItem" in-map-name="parameters">
             <result-to-result result-name="shoppingListItemSeqId" />
         </call-service>
@@ -297,7 +294,6 @@
             </condition-list>
         </entity-condition>
         <first-from-list list-name="orderRoleList" entry-name="orderRole" />
-        <log level="info" message="After orderRoleList" />
 
         <entity-condition entity-name="ShoppingList" list-name="shoppingListList">
             <condition-list combine="and">
@@ -318,23 +314,19 @@
         </else>            
         </if-empty>
 
-        <log level="info" message="Before iterating orderItemList" />
         <entity-condition entity-name="OrderItem" list-name="orderItemList">
             <condition-expr field-name="orderId" env-name="parameters.orderId" />
             <order-by field-name="orderItemSeqId" />
         </entity-condition>
         <iterate list-name="orderItemList" entry-name="orderItem">
             <if-not-empty field-name="orderItem.productId">
-                <log level="info" message="Found orderItem.productId [${orderItem.productId}]" />
                 <entity-condition entity-name="ProductAssoc" list-name="compProductAssocList" filter-by-date="true">
                     <condition-list combine="and">
                         <condition-expr field-name="productId" env-name="orderItem.productId" />
                         <condition-expr field-name="productAssocTypeId" value="PRODUCT_COMPLEMENT" />
                     </condition-list>
                 </entity-condition>
-                <log level="info" message="productAssocList = ${compProductAssocList}" />
                 <iterate list-name="compProductAssocList" entry-name="compProductAssoc">
-                    <log level="info" message="looping on assoc list" />
                     <clear-field field-name="shoppingListParameters" />
                     <set field="shoppingListParameters.productId" from-field="compProductAssoc.productIdTo" />
                     <set field="shoppingListParameters.shoppingListId" from-field="shoppingListId" />
@@ -359,9 +351,7 @@
                                 <condition-expr field-name="productAssocTypeId" value="PRODUCT_COMPLEMENT" />
                             </condition-list>
                         </entity-condition>
-                        <log level="info" message="productAssocList = ${compProductAssocList}" />
                         <iterate list-name="compProductAssocList" entry-name="compProductAssoc">
-                            <log level="info" message="looping on assoc list #2" />
                             <clear-field field-name="shoppingListParameters" />
                             <set field="shoppingListParameters.productId" from-field="compProductAssoc.productIdTo" />
                             <set field="shoppingListParameters.shoppingListId" from-field="shoppingListId" />
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-159) Add a dynamically built Suggestions, as a Shopping List, based upon Cross Sell Items

Tim Ruppert
Because I didn't hear from anyone on these questions, I created a clone
of the closed issue and attached the patch to it.  Could someone with
commit privileges apply this patch sometime soonish?  It is now OFBiz-172.

Cheers,
Tim

--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

Tim Ruppert wrote:

> I couldn't attach the patch to it, so I'm attaching it here.  Should I
> create a sub-task or clone the issue when this happens in the future?
>
> Tim Ruppert (JIRA) wrote:
>>     [
>> http://issues.apache.org/jira/browse/OFBIZ-159?page=comments#action_12428693 
>> ]             Tim Ruppert commented on OFBIZ-159:
>> -----------------------------------
>>
>> Unfortunately - I think we'll have to reopen this one.  I noticed
>> when looking at the update that I provided that I had neglected to
>> remove the log messages.  If someone can update this I would greatly
>> appreciate it.
>>
>>  
>>> Add a dynamically built Suggestions, as a Shopping List, based upon
>>> Cross Sell Items
>>> ------------------------------------------------------------------------------------
>>>
>>>
>>>                 Key: OFBIZ-159
>>>                 URL: http://issues.apache.org/jira/browse/OFBIZ-159
>>>             Project: OFBiz (The Open for Business Project)
>>>          Issue Type: New Feature
>>>          Components: order
>>>         Environment: Fedora Core 5, Java 1.5.0_05, ofbiz version 431735
>>>            Reporter: Tim Ruppert
>>>         Assigned To: David E. Jones
>>>             Fix For: SVN trunk
>>>
>>>         Attachments: suggestionList.patch
>>>
>>>
>>> The goal here is to create an "Auto Suggestions" Shopping List for
>>> users based upon cross sell product associations.
>>> If a product has cross sell associations, or if the product is a
>>> variant and it's virtual product has cross sell products, we create
>>> an "Auto Suggestion" Shopping List with the associated products - if
>>> it is not already there.  If it's there, add the cross sell products
>>> to the "Auto Suggestion" Shopping List.
>>> There needs to be a Product Store flag that allows people to
>>> configure this option.
>>>    
>>
>>  
> ------------------------------------------------------------------------
>
> Index: applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml
> ===================================================================
> --- applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml (revision 432282)
> +++ applications/order/script/org/ofbiz/order/shoppinglist/ShoppingListServices.xml (working copy)
> @@ -175,19 +175,16 @@
>  
>      <simple-method method-name="addDistinctShoppingListItem"
>                     short-description="Adds a shopping list item if one with the same productId does not exist">
> -        <log level="info" message="In addDistinctShoppingListItem" />
>          <entity-condition entity-name="ShoppingListItem" list-name="shoppingListItemList">
>              <condition-expr field-name="shoppingListId" env-name="parameters.shoppingListId" />
>          </entity-condition>
>  
>          <iterate list-name="shoppingListItemList" entry-name="shoppingListItem">
>              <if-compare-field field-name="parameters.productId" operator="equals" to-field-name="shoppingListItem.productId">
> -                <log level="info" message="In shopingListItem ${shoppingListItem.productId}" />
>                  <field-to-result field-name="shoppingListItem.shoppingListItemSeqId" result-name="shoppingListItemSeqId" />
>                  <return />
>              </if-compare-field>
>          </iterate>
> -        <log level="info" message="Right before createShoppingListItem" />
>          <call-service service-name="createShoppingListItem" in-map-name="parameters">
>              <result-to-result result-name="shoppingListItemSeqId" />
>          </call-service>
> @@ -297,7 +294,6 @@
>              </condition-list>
>          </entity-condition>
>          <first-from-list list-name="orderRoleList" entry-name="orderRole" />
> -        <log level="info" message="After orderRoleList" />
>  
>          <entity-condition entity-name="ShoppingList" list-name="shoppingListList">
>              <condition-list combine="and">
> @@ -318,23 +314,19 @@
>          </else>            
>          </if-empty>
>  
> -        <log level="info" message="Before iterating orderItemList" />
>          <entity-condition entity-name="OrderItem" list-name="orderItemList">
>              <condition-expr field-name="orderId" env-name="parameters.orderId" />
>              <order-by field-name="orderItemSeqId" />
>          </entity-condition>
>          <iterate list-name="orderItemList" entry-name="orderItem">
>              <if-not-empty field-name="orderItem.productId">
> -                <log level="info" message="Found orderItem.productId [${orderItem.productId}]" />
>                  <entity-condition entity-name="ProductAssoc" list-name="compProductAssocList" filter-by-date="true">
>                      <condition-list combine="and">
>                          <condition-expr field-name="productId" env-name="orderItem.productId" />
>                          <condition-expr field-name="productAssocTypeId" value="PRODUCT_COMPLEMENT" />
>                      </condition-list>
>                  </entity-condition>
> -                <log level="info" message="productAssocList = ${compProductAssocList}" />
>                  <iterate list-name="compProductAssocList" entry-name="compProductAssoc">
> -                    <log level="info" message="looping on assoc list" />
>                      <clear-field field-name="shoppingListParameters" />
>                      <set field="shoppingListParameters.productId" from-field="compProductAssoc.productIdTo" />
>                      <set field="shoppingListParameters.shoppingListId" from-field="shoppingListId" />
> @@ -359,9 +351,7 @@
>                                  <condition-expr field-name="productAssocTypeId" value="PRODUCT_COMPLEMENT" />
>                              </condition-list>
>                          </entity-condition>
> -                        <log level="info" message="productAssocList = ${compProductAssocList}" />
>                          <iterate list-name="compProductAssocList" entry-name="compProductAssoc">
> -                            <log level="info" message="looping on assoc list #2" />
>                              <clear-field field-name="shoppingListParameters" />
>                              <set field="shoppingListParameters.productId" from-field="compProductAssoc.productIdTo" />
>                              <set field="shoppingListParameters.shoppingListId" from-field="shoppingListId" />
>