[jira] Created: (OFBIZ-1602) FreeMaker exception1/ while approving the cutomer reviews created by a PartyGroup user

[Nicolas Malin (Jira)]

FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
---------------------------------------------------------------------------------------

                 Key: OFBIZ-1602
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: Ubuntu 7.10, Firefox 2.0.0.11
            Reporter: Raj Saini


FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.

How to reproduce:

1. Login as DemoCustCompany in the eCommerce,
2. Create a customer review.
3. Login to the Catalog Manager as admin.
4. Click on the Review tab in Catalog Manager.

FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.

Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562978#action_12562978 ]

Raj Saini commented on OFBIZ-1602:
----------------------------------

On further analysis, I found that exception occurs when getRelated is called to retrieve the Person entity. Solution could be:

1. Look up party based on postedUserLogin.partyId
2. Get the value of PartyTypeId from party.
3. Lookup the Person or PartyGroup based on the PartyTypeId.

> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>            Reporter: Raj Saini
>
> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
> How to reproduce:
> 1. Login as DemoCustCompany in the eCommerce,
> 2. Create a customer review.
> 3. Login to the Catalog Manager as admin.
> 4. Click on the Review tab in Catalog Manager.
> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
> Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raj Saini updated OFBIZ-1602:
-----------------------------

    Attachment: pendingReviews.ftl.patch

This patch fixes the bug. Please review.

> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>            Reporter: Raj Saini
>         Attachments: pendingReviews.ftl.patch
>
>
> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
> How to reproduce:
> 1. Login as DemoCustCompany in the eCommerce,
> 2. Create a customer review.
> 3. Login to the Catalog Manager as admin.
> 4. Click on the Review tab in Catalog Manager.
> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
> Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1602.
----------------------------------

    Resolution: Invalid
      Assignee: Jacques Le Roux

This code already exists in trunk and release4.0 seems not being concerned

> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>         Attachments: pendingReviews.ftl.patch
>
>
> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
> How to reproduce:
> 1. Login as DemoCustCompany in the eCommerce,
> 2. Create a customer review.
> 3. Login to the Catalog Manager as admin.
> 4. Click on the Review tab in Catalog Manager.
> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
> Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[rajsaini]

I don't know what you mean Jacques. It is a clear but and I reproduced
it on demo.hotwaxmedia.com. It is a bug even in e-commerce module.

Thanks

Raj

PS: I am posting it to mailing list as issues is closed.


Jacques Le Roux (JIRA) wrote:

>      [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Jacques Le Roux closed OFBIZ-1602.
> ----------------------------------
>
>     Resolution: Invalid
>       Assignee: Jacques Le Roux
>
> This code already exists in trunk and release4.0 seems not being concerned
>
>  
>> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
>> ---------------------------------------------------------------------------------------
>>
>>                 Key: OFBIZ-1602
>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>>             Project: OFBiz
>>          Issue Type: Bug
>>          Components: product
>>    Affects Versions: SVN trunk
>>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>>            Reporter: Raj Saini
>>            Assignee: Jacques Le Roux
>>         Attachments: pendingReviews.ftl.patch
>>
>>
>> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
>> How to reproduce:
>> 1. Login as DemoCustCompany in the eCommerce,
>> 2. Create a customer review.
>> 3. Login to the Catalog Manager as admin.
>> 4. Click on the Review tab in Catalog Manager.
>> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
>> Please advise.
>>    
>
>  

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raj Saini reopened OFBIZ-1602:
------------------------------


I have reviewed the Round Gizmo as DemoCustCompany. Trying going to Catalog->Reviews to approve this review. You should see stack trace on page

> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>         Attachments: pendingReviews.ftl.patch
>
>
> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
> How to reproduce:
> 1. Login as DemoCustCompany in the eCommerce,
> 2. Create a customer review.
> 3. Login to the Catalog Manager as admin.
> 4. Click on the Review tab in Catalog Manager.
> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
> Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Jacques Le Roux]

Oops! Sorry Raj,

Actually I applied the patch and forgot (I did something else in the meantime). Then when I tested in Eclipse it did not refresh and
it seemed that it was already applied.

Your patch is in trunk rev. 616167, thanks for the good work.

My apologies, no excuses

Jacques

From: "Raj Saini" <[hidden email]>

>I don't know what you mean Jacques. It is a clear but and I reproduced it on demo.hotwaxmedia.com. It is a bug even in e-commerce
>module.
>
> Thanks
>
> Raj
>
> PS: I am posting it to mailing list as issues is closed.
>
>
> Jacques Le Roux (JIRA) wrote:
>>      [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Jacques Le Roux closed OFBIZ-1602.
>> ----------------------------------
>>
>>     Resolution: Invalid
>>       Assignee: Jacques Le Roux
>>
>> This code already exists in trunk and release4.0 seems not being concerned
>>
>>
>>> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
>>> ---------------------------------------------------------------------------------------
>>>
>>>                 Key: OFBIZ-1602
>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>>>             Project: OFBiz
>>>          Issue Type: Bug
>>>          Components: product
>>>    Affects Versions: SVN trunk
>>>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>>>            Reporter: Raj Saini
>>>            Assignee: Jacques Le Roux
>>>         Attachments: pendingReviews.ftl.patch
>>>
>>>
>>> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
>>> How to reproduce:
>>> 1. Login as DemoCustCompany in the eCommerce,
>>> 2. Create a customer review.
>>> 3. Login to the Catalog Manager as admin.
>>> 4. Click on the Review tab in Catalog Manager.
>>> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to
>>> to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of
>>> firstName and lastName.
>>> Please advise.
>>>
>>
>>
>
>

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1602.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Raj,

And sorry for the confusion. You patch is in trunk rev. 616167

> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1602
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>            Reporter: Raj Saini
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: pendingReviews.ftl.patch
>
>
> FreeMaker exception1/ while approving  the cutomer reviews created by a PartyGroup user.
> How to reproduce:
> 1. Login as DemoCustCompany in the eCommerce,
> 2. Create a customer review.
> 3. Login to the Catalog Manager as admin.
> 4. Click on the Review tab in Catalog Manager.
> FreeMarker exception is thrown. FreeMarker template expects a Person where as the user was created by PartyGroup. One fix is to  to retrived  the PartyGroup if the userLogin.getRelated() returns null Person.  And then use the groupName field instead of  firstName and lastName.
> Please advise.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[rajsaini]

Never mind, it may be due to burning midnight oil.  ;-)

Raj

Jacques Le Roux wrote:

> Oops! Sorry Raj,
>
> Actually I applied the patch and forgot (I did something else in the
> meantime). Then when I tested in Eclipse it did not refresh and it
> seemed that it was already applied.
>
> Your patch is in trunk rev. 616167, thanks for the good work.
>
> My apologies, no excuses
>
> Jacques
>
> From: "Raj Saini" <[hidden email]>
>> I don't know what you mean Jacques. It is a clear but and I
>> reproduced it on demo.hotwaxmedia.com. It is a bug even in e-commerce
>> module.
>>
>> Thanks
>>
>> Raj
>>
>> PS: I am posting it to mailing list as issues is closed.
>>
>>
>> Jacques Le Roux (JIRA) wrote:
>>>      [
>>> https://issues.apache.org/jira/browse/OFBIZ-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>>> ]
>>>
>>> Jacques Le Roux closed OFBIZ-1602.
>>> ----------------------------------
>>>
>>>     Resolution: Invalid
>>>       Assignee: Jacques Le Roux
>>>
>>> This code already exists in trunk and release4.0 seems not being
>>> concerned
>>>
>>>
>>>> FreeMaker exception1/ while approving  the cutomer reviews created
>>>> by a PartyGroup user
>>>> ---------------------------------------------------------------------------------------
>>>>
>>>>
>>>>                 Key: OFBIZ-1602
>>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1602
>>>>             Project: OFBiz
>>>>          Issue Type: Bug
>>>>          Components: product
>>>>    Affects Versions: SVN trunk
>>>>         Environment: Ubuntu 7.10, Firefox 2.0.0.11
>>>>            Reporter: Raj Saini
>>>>            Assignee: Jacques Le Roux
>>>>         Attachments: pendingReviews.ftl.patch
>>>>
>>>>
>>>> FreeMaker exception1/ while approving  the cutomer reviews created
>>>> by a PartyGroup user.
>>>> How to reproduce:
>>>> 1. Login as DemoCustCompany in the eCommerce,
>>>> 2. Create a customer review.
>>>> 3. Login to the Catalog Manager as admin.
>>>> 4. Click on the Review tab in Catalog Manager.
>>>> FreeMarker exception is thrown. FreeMarker template expects a
>>>> Person where as the user was created by PartyGroup. One fix is to
>>>> to retrived  the PartyGroup if the userLogin.getRelated() returns
>>>> null Person.  And then use the groupName field instead of firstName
>>>> and lastName.
>>>> Please advise.
>>>>
>>>
>>>
>>
>>
>
>