[jira] Created: (OFBIZ-1628) Replace javascript popup calendar for selecting dates/times with new ofbiz-based one

[Nicolas Malin (Jira)]

Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
------------------------------------------------------------------------------------

                 Key: OFBIZ-1628
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
         Environment: Any
            Reporter: Daniel Martínez
            Priority: Minor


This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-1628:
-----------------------------------

    Attachment: calendar.patch

Implementation, things to check and TODO:

- Write a nice CSS for calendar.ftl ;)
- As it is no more fully javascript based, the element (input text) is passed by name (as javascript object cannot be passed). It is supposed that these names are unique. This should be checked or be found a better way to do it.
- Test for different languages and calendars

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567469#action_12567469 ]

Adrian Crum commented on OFBIZ-1628:
------------------------------------

Daniel,

Thank you for working on this! I tried to apply your patch, but it generates an error. Could you recreate it and attach it again please?

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-1628:
-----------------------------------

    Attachment:     (was: calendar.patch)

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-1628:
-----------------------------------

    Attachment: calendar.patch

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567470#action_12567470 ]

Daniel Martínez commented on OFBIZ-1628:
----------------------------------------

Thanks Adrian, try with this new one. I manually edited the previous one to take out some a test screen in example. If it does not work please comment on the error.

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569590#action_12569590 ]

Jacques Le Roux commented on OFBIZ-1628:
----------------------------------------

Hi Daniel,

Works well so far, some minor comments :
tabs --> 4 spaces
Headers missing : services_calendar.xml

I just wonder one point. The main problem with OFBiz Calendar is that it's long before popping (especially  in Firefox). Of cours,e this is not related to OFBiz but due to the fact that the browser must create a popup. Could not be possible to keep ans reuse the 1st popup created ? This could avoid a lot of waiting time when using calendars. Of course this could maybe meant to use some Ajax magic ?

Anyway IMHO as it is, your calendar is a great pace in the good direction, thanks !

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1628:
--------------------------------------

    Assignee: Jacques Le Roux

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-1628:
-----------------------------------

    Attachment:     (was: calendar.patch)

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Martínez updated OFBIZ-1628:
-----------------------------------

    Attachment: calendar.patch

New version. There were some errors in the original patch, also included a css for the calendar (still ugly). Maybe someone with more expreience with CSS could look onto it?

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1628.
----------------------------------

       Resolution: Duplicate
    Fix Version/s: SVN trunk

Another new calendar is already commited : OFBIZ-1825

> Replace javascript popup calendar for selecting dates/times with new ofbiz-based one
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1628
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Daniel Martínez
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: calendar.patch
>
>
> This new calendar is constructed with the jdk Calendar class so it should display different calendars depending on locale (i.e. lunar based calendars). It is also language localized.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.