OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1634) can not Cannot review a product.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

13 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1634) can not Cannot review a product.

can not Cannot review a product.
--------------------------------

Key: OFBIZ-1634
URL: https://issues.apache.org/jira/browse/OFBIZ-1634
Project: OFBiz
Issue Type: Bug
Components: ecommerce
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor
Fix For: SVN trunk

http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
click on
Be The First To Review This Product!
login (i did as admin)

get a blank page with this message
Cannot review an unknown product.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1634) Cannot review a product.

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-1634:
------------------------------

Summary: Cannot review a product. (was: can not Cannot review a product.)

modified the summary

> Cannot review a product.
> ------------------------
>
> Key: OFBIZ-1634
> URL: https://issues.apache.org/jira/browse/OFBIZ-1634
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: BJ Freeman
> Priority: Minor
> Fix For: SVN trunk
>
>
> http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
> click on
> Be The First To Review This Product!
> login (i did as admin)
> get a blank page with this message
> Cannot review an unknown product.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569703#action_12569703 ]

Jacques Le Roux commented on OFBIZ-1634:
----------------------------------------

Hi BJ,

Not sure why but it works locally with an instance having only these changes (only URL and DB changes):
D:\workspace\ofbizRun>svn st
M .project
M framework\common\config\general.properties
M framework\base\config\ofbiz-containers.xml
M framework\entity\config\entityengine.xml
? framework\entity\lib\jdbc\postgresql-8.2-504.jdbc3.jar
M framework\webapp\config\url.properties

You even might be able to try using "Alternative demo servers" from OFBiz site (use trunk one). I tried with DemoCustomer and admin.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571240#action_12571240 ]

Bilgin Ibryam commented on OFBIZ-1634:
--------------------------------------

While trying to reproduce the bug, I saw 2 strange issues here (both cannot be reproduced locally!)

1) If you go directly (w/o clicking around in ecommerce before that) to the product screen http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644

the "Review Product" link looks like that: href="/ecommerce/control/reviewProduct;jsessionid=A399361B726899A88B27E5CA2F7B4C75.jvm1?category_id=PROMOTIONS&product_id=GZ-2644"

BUT when you click on it, the server does NOT get the parameters, you can see that in the browser and at the server logs:
2008-02-21 17:37:29,055 (TP-Processor20) [ RequestHandler.java:243:INFO ] [Processing Request]: reviewProduct sessionId=A399361B726899A88B27E5CA2F7B4C75.jvm1
2008-02-21 17:37:29,055 (TP-Processor20) [ LoginWorker.java:264:INFO ] reqParams Map: []
2008-02-21 17:37:29,056 (TP-Processor20) [ LoginWorker.java:265:INFO ] queryString:

Locally, the link looks the same, but when i click on it, the logs looks like that:
2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ RequestHandler.java:243:INFO ] [Processing Request]: reviewProduct sessionId=23CCE5697BB17CD923DC858A0D2097A8.jvm1
2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ LoginWorker.java:264:INFO ] reqParams Map: [product_id=FA-001, category_id=PROMOTIONS]
2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ LoginWorker.java:265:INFO ] queryString: product_id=FA-001&category_id=PROMOTIONS

You can see that when testing locally, product_id and category_id are not lost and the product can be reviewed.

Any ideas why these reqParams are lost on the demo server?

2) The second issue is a more common one and easier to reproduce (on the demo server):
If the request on ecomerce looks like that: <security auth="true" https="false"/> for example editShoppingList and reviewProduct links, click on it will require auth and you will get the login screen. BUT at this stage the URL is http ( not https). If you enter username and pass, they will be not accepted. The error message is:

The Username was empty, please re-enter.
The Password was empty, please re-enter.

Now the URL is https and you have to enter AGAIN your user name and pass to log in.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacopo Cappellato

Re: [jira] Commented: (OFBIZ-1634) Cannot review a product.

Bilgin Ibryam (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571240#action_12571240 ]
>
> Bilgin Ibryam commented on OFBIZ-1634:
> --------------------------------------
>
> While trying to reproduce the bug, I saw 2 strange issues here (both cannot be reproduced locally!)
>
> 1) If you go directly (w/o clicking around in ecommerce before that) to the product screen http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
>
> the "Review Product" link looks like that: href="/ecommerce/control/reviewProduct;jsessionid=A399361B726899A88B27E5CA2F7B4C75.jvm1?category_id=PROMOTIONS&product_id=GZ-2644"
>
> BUT when you click on it, the server does NOT get the parameters, you can see that in the browser and at the server logs:
> 2008-02-21 17:37:29,055 (TP-Processor20) [ RequestHandler.java:243:INFO ] [Processing Request]: reviewProduct sessionId=A399361B726899A88B27E5CA2F7B4C75.jvm1
> 2008-02-21 17:37:29,055 (TP-Processor20) [ LoginWorker.java:264:INFO ] reqParams Map: []
> 2008-02-21 17:37:29,056 (TP-Processor20) [ LoginWorker.java:265:INFO ] queryString:
>
> Locally, the link looks the same, but when i click on it, the logs looks like that:
> 2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ RequestHandler.java:243:INFO ] [Processing Request]: reviewProduct sessionId=23CCE5697BB17CD923DC858A0D2097A8.jvm1
> 2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ LoginWorker.java:264:INFO ] reqParams Map: [product_id=FA-001, category_id=PROMOTIONS]
> 2008-02-22 01:49:24,953 (http-0.0.0.0-8080-Processor3) [ LoginWorker.java:265:INFO ] queryString: product_id=FA-001&category_id=PROMOTIONS
>
> You can see that when testing locally, product_id and category_id are not lost and the product can be reviewed.
>
> Any ideas why these reqParams are lost on the demo server?
>

I've noticed this behavior in the demo server in different screens, too.
For example sometime when I log in and then go to Facility and then
click in one of the facilities, the url is messed up by the
;jsessionid=A399361B726899A88B27E5CA2F7B4C75.jvm1? string (probably in
the wrong position) and so the facility is not found: if you then click
again everything works fine (I think there is also a Jira issue for
this, but not sure).
I've tried to search in the past for the issue, but I didn't find the
problem in OFBiz... my suspect is that there is something weird
happening between OFBiz and the web server.

Jacopo

> 2) The second issue is a more common one and easier to reproduce (on the demo server):
> If the request on ecomerce looks like that: <security auth="true" https="false"/> for example editShoppingList and reviewProduct links, click on it will require auth and you will get the login screen. BUT at this stage the URL is http ( not https). If you enter username and pass, they will be not accepted. The error message is:
>
> The Username was empty, please re-enter.
> The Password was empty, please re-enter.
>
> Now the URL is https and you have to enter AGAIN your user name and pass to log in.
>
>> Cannot review a product.
>> ------------------------
>>
>> Key: OFBIZ-1634
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1634
>> Project: OFBiz
>> Issue Type: Bug
>> Components: ecommerce
>> Affects Versions: SVN trunk
>> Reporter: BJ Freeman
>> Priority: Minor
>> Fix For: SVN trunk
>>
>>
>> http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
>> click on
>> Be The First To Review This Product!
>> login (i did as admin)
>> get a blank page with this message
>> Cannot review an unknown product.
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571387#action_12571387 ]

Jacques Le Roux commented on OFBIZ-1634:
----------------------------------------

I don't know what is used for HWM demo servers (at Contegix I suppose). But I would recommend to try Apache HHTPD 2.2.x with mod_proxy_ajp as it's now the recommend way to use HTTPS as front server for Tomcat: http://docs.ofbiz.org/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo#FAQ-Tips-Tricks-Cookbook-HowTo-Howtousemodproxyajp

I may be wrong, my 2 cts

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571452#action_12571452 ]

David E. Jones commented on OFBIZ-1634:
---------------------------------------

This appears to be a URL writing problem, and if so would be a problem with OFBiz code and not with how it is deployed.

If I remember right from running into this before the problem happens when the parameters for the URL are not included in the ofbizUrl tag, so the jsessionid gets inserted in a bad place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571455#action_12571455 ]

Bilgin Ibryam commented on OFBIZ-1634:
--------------------------------------

If you wish to use the comment text you have typed (shown below), please copy it now. This text will be lost when you leave this screen.

What is the right place for jsessionid ? Before or after parameters ?

First I also thought that jsessionid is not inserted at the right place, but after looking at RequestHandler.makeLink:831 decided it work fine, because HttpServletResponse.encodeURL(String()) inserts jsessionid before "?param1=value1" and ofbiz code does the same here:

if (response != null && !forceManualJsessionid && !isSpider) {
encodedUrl = response.encodeURL(newURL.toString());
} else {
if (!isSpider){
String sessionId = ";jsessionid=" + request.getSession().getId();
// this should be inserted just after the "?" for the parameters, if there is one, or at the end of the string
int questionIndex = newURL.indexOf("?");
if (questionIndex == -1) {
newURL.append(sessionId);
} else {
newURL.insert(questionIndex, sessionId);
}
}
encodedUrl = newURL.toString();
}

And also locally everything works w/o errors.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571456#action_12571456 ]

Bilgin Ibryam commented on OFBIZ-1634:
--------------------------------------

Please ignore the first line from my post. It is copied by mistake while testing jsessionId ;)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571467#action_12571467 ]

Bilgin Ibryam commented on OFBIZ-1634:
--------------------------------------

BTW the link mentioned above is enclosed with <@ofbizUrl>
Here it is:

<a href="<@ofbizUrl>reviewProduct?category_id=${categoryId?if_exists}&product_id=${product.productId}</@ofbizUrl>" class="buttontext">${uiLabelMap.ProductReviewThisProduct}!</a>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571717#action_12571717 ]

Jacques Le Roux commented on OFBIZ-1634:
----------------------------------------

I just realise now that my comment above should not have been in this issue. As often I was too fast, I thought I was commenting another issue BJ opened (and closed for personnal reason) about the need to log in twice when you log to HWM demo server : OFBIZ-1370. That's why I made this suggestion (FWIW)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641163#action_12641163 ]

Marco Risaliti commented on OFBIZ-1634:
---------------------------------------

I have tested it again and seems to me that everything is ok also on demo server.
Why don't close this issue using Cannot Reproduce causal.

Thanks
Marco

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1634) Cannot review a product.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1634.
----------------------------------

Resolution: Cannot Reproduce
Assignee: Jacques Le Roux

Just tested on demo server, it works well without anything special in log.

Just closed as Marco suggested

> Cannot review a product.
> ------------------------
>
> Key: OFBIZ-1634
> URL: https://issues.apache.org/jira/browse/OFBIZ-1634
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
> Affects Versions: SVN trunk
> Reporter: BJ Freeman
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
>
> http://demo.hotwaxmedia.com/ecommerce/control/product/~category_id=PROMOTIONS/~product_id=GZ-2644
> click on
> Be The First To Review This Product!
> login (i did as admin)
> get a blank page with this message
> Cannot review an unknown product.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.