OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

27 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

Ship If Capture Fails option in productstore doesn't work
---------------------------------------------------------

Key: OFBIZ-2001
URL: https://issues.apache.org/jira/browse/OFBIZ-2001
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Environment: trunk version 703450
Reporter: William Perng

This issue is related to the function introduced in issue ofbiz-558. Order status is still changed to "complete" after packing even this option is turned on and credit card capature is failed. The right behavior should display "Cannot ship order because credit card captures were unsuccessful" error message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640732#action_12640732 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

do you have some logs.
I am wondering if a CC failure is really being returned by the gateway.
or if the failure show in the gateway but is not passed back up to the calling program.

> Ship If Capture Fails option in productstore doesn't work
> ---------------------------------------------------------
>
> Key: OFBIZ-2001
> URL: https://issues.apache.org/jira/browse/OFBIZ-2001
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Environment: trunk version 703450
> Reporter: William Perng
>
> This issue is related to the function introduced in issue ofbiz-558. Order status is still changed to "complete" after packing even this option is turned on and credit card capature is failed. The right behavior should display "Cannot ship order because credit card captures were unsuccessful" error message.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640736#action_12640736 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

I don't believe the problem is with 558.
I believe it has todo with the accual drivers for the gateway that PaymentGatewayServices.java calls.
for instance IcsPaymentServices.java
// TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire, resultBadCardNumber
are not done.
"authResult" is return to PaymentGatewayServices but it does not do anything with it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640737#action_12640737 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

the patch is good.
it is the code in the gateways that is called by PaymentGatewayServices.java
"authResult" is returned but PaymentGatewayServices does not evaluate it.
// TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire, resultBadCardNumber
so the gateway code does not return these statuses, that PaymentGatewayServices looks for.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640738#action_12640738 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

not the patch
it is the underlying gateway drivers that PaymentGatewayServices calls.
// TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire, resultBadCardNumber

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640739#action_12640739 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

not the patch
it is the underlying gateway drivers that PaymentGatewayServices calls.
// TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire, resultBadCardNumber

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

BJ Freeman

Re: [jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

for some reason my comments are not showing up in the jira

BJ Freeman (JIRA) sent the following on 10/17/2008 6:54 PM:

> [ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640732#action_12640732 ]
>
> BJ Freeman commented on OFBIZ-2001:
> -----------------------------------
>
> do you have some logs.
> I am wondering if a CC failure is really being returned by the gateway.
> or if the failure show in the gateway but is not passed back up to the calling program.
>
>
>> Ship If Capture Fails option in productstore doesn't work
>> ---------------------------------------------------------
>>
>> Key: OFBIZ-2001
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2001
>> Project: OFBiz
>> Issue Type: Bug
>> Components: accounting
>> Affects Versions: SVN trunk
>> Environment: trunk version 703450
>> Reporter: William Perng
>>
>> This issue is related to the function introduced in issue ofbiz-558. Order status is still changed to "complete" after packing even this option is turned on and credit card capature is failed. The right behavior should display "Cannot ship order because credit card captures were unsuccessful" error message.
>

BJ Freeman

Re: [jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

same here. just see it in the email but not on the jira

BJ Freeman (JIRA) sent the following on 10/17/2008 7:16 PM:

> [ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640736#action_12640736 ]
>
> BJ Freeman commented on OFBIZ-2001:
> -----------------------------------
>
> I don't believe the problem is with 558.
> I believe it has todo with the accual drivers for the gateway that PaymentGatewayServices.java calls.
> for instance IcsPaymentServices.java
> // TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire, resultBadCardNumber
> are not done.
> "authResult" is return to PaymentGatewayServices but it does not do anything with it.
>
>> Ship If Capture Fails option in productstore doesn't work
>> ---------------------------------------------------------
>>
>> Key: OFBIZ-2001
>> URL: https://issues.apache.org/jira/browse/OFBIZ-2001
>> Project: OFBiz
>> Issue Type: Bug
>> Components: accounting
>> Affects Versions: SVN trunk
>> Environment: trunk version 703450
>> Reporter: William Perng
>>
>> This issue is related to the function introduced in issue ofbiz-558. Order status is still changed to "complete" after packing even this option is turned on and credit card capature is failed. The right behavior should display "Cannot ship order because credit card captures were unsuccessful" error message.
>

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

Administrator

Hi BJ,

I can see all your comments in Jira

Jacques

From: "BJ Freeman" <[hidden email]>

> same here. just see it in the email but not on the jira
>
> BJ Freeman (JIRA) sent the following on 10/17/2008 7:16 PM:
>> [
>> https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640736#action_12640736 ]
>>
>> BJ Freeman commented on OFBIZ-2001:
>> -----------------------------------
>>
>> I don't believe the problem is with 558.
>> I believe it has todo with the accual drivers for the gateway that PaymentGatewayServices.java calls.
>> for instance IcsPaymentServices.java
>> // TODO: based on reasonCode populate the following flags as applicable: resultDeclined, resultNsf, resultBadExpire,
>> resultBadCardNumber
>> are not done.
>> "authResult" is return to PaymentGatewayServices but it does not do anything with it.
>>
>>> Ship If Capture Fails option in productstore doesn't work
>>> ---------------------------------------------------------
>>>
>>> Key: OFBIZ-2001
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-2001
>>> Project: OFBiz
>>> Issue Type: Bug
>>> Components: accounting
>>> Affects Versions: SVN trunk
>>> Environment: trunk version 703450
>>> Reporter: William Perng
>>>
>>> This issue is related to the function introduced in issue ofbiz-558. Order status is still changed to "complete" after packing
>>> even this option is turned on and credit card capature is failed. The right behavior should display "Cannot ship order because
>>> credit card captures were unsuccessful" error message.
>>
>

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

BJ Freeman updated OFBIZ-2001:
------------------------------

Comment: was deleted

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

BJ Freeman

Re: [jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Jacques Le Roux

thanks.. Not sure why I could not see them last night.
sorry for all the Jira posts to correct the problem.

Jacques Le Roux sent the following on 10/18/2008 1:36 AM:

> Hi BJ,
>
> I can see all your comments in Jira
>
> Jacques
>
> From: "BJ Freeman" <[hidden email]>
>> same here. just see it in the email but not on the jira
>>
>> BJ Freeman (JIRA) sent the following on 10/17/2008 7:16 PM:
>>> [
>>> https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640736#action_12640736
>>> ]
>>>
>>> BJ Freeman commented on OFBIZ-2001:
>>> -----------------------------------
>>>
>>> I don't believe the problem is with 558.
>>> I believe it has todo with the accual drivers for the gateway that
>>> PaymentGatewayServices.java calls.
>>> for instance IcsPaymentServices.java
>>> // TODO: based on reasonCode populate the following flags
>>> as applicable: resultDeclined, resultNsf, resultBadExpire,
>>> resultBadCardNumber
>>> are not done.
>>> "authResult" is return to PaymentGatewayServices but it does not do
>>> anything with it.
>>>
>>>> Ship If Capture Fails option in productstore doesn't work
>>>> ---------------------------------------------------------
>>>>
>>>> Key: OFBIZ-2001
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-2001
>>>> Project: OFBiz
>>>> Issue Type: Bug
>>>> Components: accounting
>>>> Affects Versions: SVN trunk
>>>> Environment: trunk version 703450
>>>> Reporter: William Perng
>>>>
>>>> This issue is related to the function introduced in issue
>>>> ofbiz-558. Order status is still changed to "complete" after
>>>> packing even this option is turned on and credit card capature is
>>>> failed. The right behavior should display "Cannot ship order
>>>> because credit card captures were unsuccessful" error message.
>>>
>>
>
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641019#action_12641019 ]

William Perng commented on OFBIZ-2001:
--------------------------------------

1. Yes, you are right. The problem is nothing to do with the issue 255. I am just trying to describe the function I would like to discuss here is introduced in issue 255.
2. I don't have log.
3. Here are the Scenarios I test :
a. The authorization is successful, the capture is declined, the reauth is failed and the "ship if capature is failed" is set to N -- The error message will be shown in the pack page. The transaction is rolled back. It looks correct but the capture transaction record doesn't exist in PaymentGatewayResponse table, because the roll back removes it. There will be two authorization records in order detail page, but no capture record. In my personal opinion, the credit card problem should not throw exception, it should be processed by program flow.
b. The authorization is successful, the capture is declined, the reauth is successful and the "ship if capature is failed" is set to N -- There will be no error message in the pack page. The order status will be "complete". The order detail page will have 2 authorization record and 1 capture record. However, the 2nd authorization record will not be captured automatically. (Is there any setting for automatic capture after reauth ?). When this happens, the order will be shipped even the capture has not happened, since the order status is complete.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641054#action_12641054 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

My understanding/experience is if you have an Authorization, you should also have a capture if done within 3 business days.
so my first concern is why you not getting a capture.
how have you determine the capture fails?
I suggest you put some log.info in the PaymentGatewayServices.java to see what it is returning.
then work you way up.
BTW which gateway driver are you using.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641070#action_12641070 ]

William Perng commented on OFBIZ-2001:
--------------------------------------

I use "testCCProcessorCaptureAlwaysDecline" in the product store to fail the capture.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641160#action_12641160 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

The problem is the fix in 588 is in the captureOrderPayments
testCCProcessorCaptureAlwaysDecline does not use captureOrderPayments
need to update testCCProcessorCaptureAlwaysDecline

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641243#action_12641243 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

my final comment.
real testing should be done using a payment gateway sandbox

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641375#action_12641375 ]

William Perng commented on OFBIZ-2001:
--------------------------------------

fine. Could you tell me what should be the expected result for the two scenarios above ? If the expected result is the same, there is no need for me to re-test by using production server.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-2001) Ship If Capture Fails option in productstore doesn't work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641438#action_12641438 ]

BJ Freeman commented on OFBIZ-2001:
-----------------------------------

not more than I have said at this point.
will have to wait for someone to test it again and report results.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.