OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1687) POS: full credit card number is printed on receipt

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

12 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1687) POS: full credit card number is printed on receipt

POS: full credit card number is printed on receipt
--------------------------------------------------

Key: OFBIZ-1687
URL: https://issues.apache.org/jira/browse/OFBIZ-1687
Project: OFBiz
Issue Type: Improvement
Components: specialpurpose/pos
Affects Versions: SVN trunk
Reporter: Chris Lombardi
Priority: Minor

Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-1687) POS: full credit card number is printed on receipt

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1687:
--------------------------------------

Assignee: Jacques Le Roux

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]

Jacques Le Roux commented on OFBIZ-1687:
----------------------------------------

Hi Chris,

Have you a patch for this (before I look at it, seems simple) ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Vince Clark

Re: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt

Scott did this for us a few months ago. Scott, feel free to commit to trunk.

----- Original Message -----
From: "Jacques Le Roux (JIRA)" <[hidden email]>
To: [hidden email]
Sent: Thursday, February 28, 2008 12:49:51 PM (GMT-0700) America/Denver
Subject: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]

Jacques Le Roux commented on OFBIZ-1687:
----------------------------------------

Hi Chris,

Have you a patch for this (before I look at it, seems simple) ?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacques Le Roux

Re: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt

Administrator

Thanks Vince,

Jacques

From: "Vince M. Clark" <[hidden email]>

> Scott did this for us a few months ago. Scott, feel free to commit to trunk.
>
> ----- Original Message -----
> From: "Jacques Le Roux (JIRA)" <[hidden email]>
> To: [hidden email]
> Sent: Thursday, February 28, 2008 12:49:51 PM (GMT-0700) America/Denver
> Subject: [jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt
>
>
> [
> https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573419#action_12573419 ]
>
> Jacques Le Roux commented on OFBIZ-1687:
> ----------------------------------------
>
> Hi Chris,
>
> Have you a patch for this (before I look at it, seems simple) ?
>
>> POS: full credit card number is printed on receipt
>> --------------------------------------------------
>>
>> Key: OFBIZ-1687
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
>> Project: OFBiz
>> Issue Type: Improvement
>> Components: specialpurpose/pos
>> Affects Versions: SVN trunk
>> Reporter: Chris Lombardi
>> Assignee: Jacques Le Roux
>> Priority: Minor
>>
>> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced
>> with asterisk or 'x' characters.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573532#action_12573532 ]

Chris Lombardi commented on OFBIZ-1687:
---------------------------------------

I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.

If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573532#action_12573532 ]

clearchris edited comment on OFBIZ-1687 at 2/28/08 4:56 PM:
----------------------------------------------------------------

I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.

If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.

EDIT: saw this on the mailing list, attaching to issue.

From: Vince M. Clark ([hidden email])
Sent: Thu 2/28/08 2:13 PM
To: [hidden email]

Scott did this for us a few months ago. Scott, feel free to commit to trunk.

was (Author: clearchris):
I haven't looked at it yet, I was reading through the interchange guidelines today (dry reading that) and wanted to record this before I forgot.

If you take a look at it before I do (probably after I finish up the other cc related issue), please put the function somewhere reusable as I'd also like to mask the credit card numbers printed in cleartext in the logs.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1687:
----------------------------------

Attachment: ofbiz-1687-1.patch

Patch to add in formatPrintableCreditCard() and tests to base.

I'll add another patch to utilize this in POS, but not today.

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Lombardi updated OFBIZ-1687:
----------------------------------

Attachment: ofbiz-1687-2.patch

This was easier than I thought it would be. Patch #2 removes the credit card printouts in the log and masks the card number printouts on the receipts.

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: ofbiz-1687-1.patch, ofbiz-1687-2.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1687) POS: full credit card number is printed on receipt

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1687.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk

Thanks Chris,

Your patches are in trunk rev. 637310

> POS: full credit card number is printed on receipt
> --------------------------------------------------
>
> Key: OFBIZ-1687
> URL: https://issues.apache.org/jira/browse/OFBIZ-1687
> Project: OFBiz
> Issue Type: Improvement
> Components: specialpurpose/pos
> Affects Versions: SVN trunk
> Reporter: Chris Lombardi
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ofbiz-1687-1.patch, ofbiz-1687-2.patch
>
>
> Card processing guidelines allow only the last 4 digits of a card number to be printed on a receipt. The rest should be replaced with asterisk or 'x' characters.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.