OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1689) CASifying OFBiz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

39 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626330#action_12626330 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

I did a 1st cursory review :
. You don't need to provide NOTICE and LICENCE file since there should be no changes in them (you granted your right to ASF). BTW there is only one instance of these files in root. They are now only copied by ant builds in jar files : http://fisheye6.atlassian.com/qsearch/ofbiz/?q=notice
. Don't use tabs but 4 spaces in code, please *read* http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices
. I'm still not sure of ldap.jar licence, which one did you used ?
. Where may I find ofbiz-ldap.jar ?
. Please don't use absolut pathes like /usr/local/workspace/OFBiz4.0

Thanks for your work !

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ofbiz4.0-ldap-patch-20080826.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shi Yusen updated OFBIZ-1689:
-----------------------------

Attachment: ldap.zip
ofbiz4.0-ldap-patch-20080828.txt

Jacquest,

Your doult on the ldap.jar is right. I removed it and it still work for me.

I changed the tabs in patch file to 4 spaces. The ofbiz-ldap.jar is built from the source code and placed under specialpurpose/ldap/build/lib.

The zip file is just for the case somebody may want to have a quick test on the component.

Regards,

Shi Yusen/Beijing Langhua Ltd.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627230#action_12627230 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

I just realize now, this patch if for release4.0 only ? Did you testit in trunk since your last comment about that ?

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627344#action_12627344 ]

Shi Yusen commented on OFBIZ-1689:
----------------------------------

Jacques,

I made some changes on the code and test it with trunk version 688743. Both single login and logout work in my environment.

I'll change the license later and try to contribute the code back to OFBiz.

Here's the code:
http://www.langhua.cn/viewvc/ofbiz-components/OFBiz-LDAP/branch/OFBiz-688743-CAS3.2.1.1-OpenLDAP2.4.8/

Regards,

Shi Yusen/Beijing Langhua Ltd.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628016#action_12628016 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

There is, at least, one thing not clear in your last patch. You said that your ldap component works without the ldap.jar library but I see a reference to it in the patch. Are you sure it works without it (ok I can't see in zip, but...) ?

Else it looks good apart
. Please don't put a reference to generated ofbiz-ldap.jar. And actually any Jars in patch : I will take them from your zip file and will put version in names as we do in OFBiz
. Add menu-name="secondary" in ofbiz-component.xml section webapp to place the button at bottom (though you put app-bar-display="false"). No base-permission needed ?
. Some tabs I easily replaced by 4 spaces in patch
. "ldap://127.0.0.1:389" in code. Should we not make a properties for that (using localhost and separating server and port) ?
. Same for "https://localhost:8443/cas" and what is https://cms.chinare.org.cn:8444/cas ?
. Also I would prefer
LDAPUiLabelsxml UTF8 file in place of LDAPUiLabels.properties and LDAPUiLabels_zh.properties
FastMap in place of Hashtable

I'm ready to commit it, when you will have fixed the points above (please take them more as didactical)
I will commit in CTT mode (commit then test) as I have no need and time to test all the component now.
So please be ready for questions when it will be really tested/used by other users...

Thanks for your work !

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shi Yusen updated OFBIZ-1689:
-----------------------------

Attachment: ofbiz-trunk688743-ldap-patch-20080904.txt

Jacques,

Thanks for your instruction.

In ofbiz-trunk688743-ldap-patch-20080904.txt:

I removed jndi.jar and ldap.jar because I found the functions of these jars were enhanced in JDK 1.5. See http://java.sun.com/products/jndi/.

I removed the specialpurpose/ldap/build as I mentioned.

I removed webapp element from the ofbiz-component.xml.

I removed LDAPUiLabels.properties and LDAPUiLabels_zh.properties because I didn't use the properties defined in them. :)

"ldap://127.0.0.1:389" and so on: currently the configurations is in config/ldap.xml which it's convenient for my development and deploy in the case there are not many OFBiz backend users. As you mentioned, it would be better to put the configurations in a property file and load to memory when OFBiz starts. Currently, it's ok for my requirements. When the configurations be in a property file, the HashTable can be replaced with Properties as LdapAuthenticationServices.java did. BTW, are the properties singletoned and could be re-initialized in OFBiz?

Regards,

Shi Yusen/Beijing Langhua Ltd.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Shi Yusen

Re: [jira] Updated: (OFBIZ-1689) CASifying OFBiz

oops. So many mistakes.

I mean "I removed the specialpurpose/ldap/build as YOU mentioned".

and

"are the properties singletoned and able to be re-initialized during
OFBiz running?"

Shi Yusen/Beijing Langhua Ltd.

在 2008-09-04四的 02:43 -0700，Shi Yusen (JIRA)写道：

> [ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Shi Yusen updated OFBIZ-1689:
> -----------------------------
>
> Attachment: ofbiz-trunk688743-ldap-patch-20080904.txt
>
> Jacques,
>
> Thanks for your instruction.
>
> In ofbiz-trunk688743-ldap-patch-20080904.txt:
>
> I removed jndi.jar and ldap.jar because I found the functions of these jars were enhanced in JDK 1.5. See http://java.sun.com/products/jndi/.
>
> I removed the specialpurpose/ldap/build as I mentioned.
>
> I removed webapp element from the ofbiz-component.xml.
>
> I removed LDAPUiLabels.properties and LDAPUiLabels_zh.properties because I didn't use the properties defined in them. :)
>
> "ldap://127.0.0.1:389" and so on: currently the configurations is in config/ldap.xml which it's convenient for my development and deploy in the case there are not many OFBiz backend users. As you mentioned, it would be better to put the configurations in a property file and load to memory when OFBiz starts. Currently, it's ok for my requirements. When the configurations be in a property file, the HashTable can be replaced with Properties as LdapAuthenticationServices.java did. BTW, are the properties singletoned and could be re-initialized in OFBiz?
>
> Regards,
>
> Shi Yusen/Beijing Langhua Ltd.
>
> > CASifying OFBiz
> > ---------------
> >
> > Key: OFBIZ-1689
> > URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> > Project: OFBiz
> > Issue Type: New Feature
> > Components: ALL COMPONENTS
> > Affects Versions: Release Branch 4.0
> > Reporter: Shi Yusen
> > Assignee: Jacques Le Roux
> > Priority: Trivial
> > Fix For: Release Branch 4.0
> >
> > Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz4.0-ldap-patch-20080828.txt
> >
> > Original Estimate: 336h
> > Remaining Estimate: 336h
> >
> > I'll start my work on CASifying OFBiz, the method will be similar to this one:
> > http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> > Please keep this issue open, I'll post my code to this issue when it's done.
> > I'm eager to hear your suggestions on this topic.
> > TIA
> > Shi Yusen/Beijing Langhua Ltd.
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628446#action_12628446 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Hi Shi,

Did not look into details (actually I tried but ran out of time) about jndi.jar and ldap.jar. Did you mean that there are no longer needed or that I should take them in JDK 1.5 ?

Not sure about what you meaned by "I removed the specialpurpose/ldap/build as *you* mentioned.". AFAIK I did not mention anything about that ;)

You asked on ML "are the properties singletoned and able to be re-initialized during OFBiz running?". No they are not : you must reload OFBiz. But you may use XML files for that as we do for i18n. Then clearing related cache is enough, no need to reload.

Tonight I
* fixed one tab (great effort ;o)
* changed 2 127.0.0.1 to localhost
* loaded cas-server-core-3.1.jar from http://www.langhua.cn/viewvc/modules/ldap/trunk/lib/cas-server-core-3.1.jar?view=log
* loaded the licence from http://www.ja-sig.org/products/cas/overview/license/index.html

I will continue the review tomorrow

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628580#action_12628580 ]

Shi Yusen commented on OFBIZ-1689:
----------------------------------

Jacques,

Honestly, I didn't test it in JDK 1.5, I tested it in JDK 1.6. Personally I think the two jars can be removed. I'm not sure whether the jars from ActiveDirectory will need them. I don't have ActiveDirectory environment now so I cannot test this.

As you mentioned the ofbiz-ldap.jar should not be included in the patch file, so I removed the ldap/build and then created the patch.

I saw the new i18n xml files in trunk. It's quite convenient for localization now.

Shi Yusen/Beijing Langhua Ltd.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629740#action_12629740 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Hi Shi,

I'm have no time to test it seriously. Could you please replace the 4 "cn.langhua" strings by "org" in your code and test it ?

Thanks

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1689:
-----------------------------------

Attachment: ofbiz-trunk688743-ldap.patch

Please Shi, use this lastet patch I slightly modified (see my comments above) for your test

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629859#action_12629859 ]

Shi Yusen commented on OFBIZ-1689:
----------------------------------

Jacques,

I'm embarrassed by so many mistakes you have fixed for me. Thank you!

I downloaded the ofbiz-trunk688743-ldap.patch and applied it in my enviroment. I added a lib directory and cas-server-core-3.1.jar, rebuilt and run OFBiz, configed ldap.xml, both org.ofbiz.ldap.cas.OFBizCasAuthenticationHandler and org.ofbiz.ldap.openldap.OFBizLdapAuthenticationHandler worked fine.

Regards,

Shi Yusen/Beijing Langhua Ltd.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629968#action_12629968 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

Don't worry too much. I do mine also and some kind people around help me too. I think I will commit the patch soon, except if someone see a problem with that of course.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630321#action_12630321 ]

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

Did you try with a brand new check out (svn co) ?

Yes I was surprised by this Jira behaviour : I had to switch to jira-users. But before it was (in French) "All users" is there a difference ?

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630383#action_12630383 ]

Shi Yusen commented on OFBIZ-1689:
----------------------------------

Jacques,

I just tested the new patch with trunk 694293. It works like a charming.

The difference of two user groups is that we can keep say something not that public when we use jira-users. It's also possible to setup a group to keep issues internal.

BTW, perhaps the lucene-2.2.0.jar in applications/content/lib can be updated to lucene-2.3.0.jar without any code change. I feel the new LONG comparator in lucene-2.3.0.jar is very useful.

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630226#action_12630226 ]

jacques.le.roux edited comment on OFBIZ-1689 at 9/11/08 11:37 PM:
------------------------------------------------------------------

Hi Shi,

Could you please retry with this new patch on a fresh checkout.

I crossed some problems an I'd prefer to let you deal with them.
Note that I respectively renamed A_ an I_ to Abstract and Interface in order to follow OFBiz best pratices.
Else no major code changes, only LICENSE and LICENCE files update

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: Release Branch 4.0
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1689) CASifying OFBiz

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1689.
----------------------------------

Resolution: Fixed
Fix Version/s: (was: Release Branch 4.0)
SVN trunk

Hi Shi,

It was not my intention to make my comment only visible by jira-users. Actually I was surprised by this new Jira behaviour which surprisingly happened. This morning things was more clear in my mind :). I guess it was because Infra updated Jira while I was editing (it's more Frenchy this morning, almost all in French now).

BTW your patch (modified to follow OFBiz best practices, etc.) is in trunk rev. 694647

Thanks for your work !

> CASifying OFBiz
> ---------------
>
> Key: OFBIZ-1689
> URL: https://issues.apache.org/jira/browse/OFBIZ-1689
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
> Affects Versions: Release Branch 4.0
> Reporter: Shi Yusen
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz-trunk688743-ldap-patch-20080904.txt, ofbiz-trunk688743-ldap.patch, ofbiz-trunk688743-ldap.patch, ofbiz4.0-ldap-patch-20080828.txt
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.