Missing or misplaced resource bundle property in ParyUiLabels.xml
----------------------------------------------------------------- Key: OFBIZ-1699 URL: https://issues.apache.org/jira/browse/OFBIZ-1699 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Environment: Ubuntu 7.10, Firex 2.0.11 Reporter: Raj Saini Priority: Minor CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raj Saini updated OFBIZ-1699: ----------------------------- Environment: Ubuntu 7.10, Firefox 2.0.11 (was: Ubuntu 7.10, Firex 2.0.11) Corrected misspelled Firefox > Missing or misplaced resource bundle property in ParyUiLabels.xml > ----------------------------------------------------------------- > > Key: OFBIZ-1699 > URL: https://issues.apache.org/jira/browse/OFBIZ-1699 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: Ubuntu 7.10, Firefox 2.0.11 > Reporter: Raj Saini > Priority: Minor > > CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1699: ------------------------------------ Assignee: Bilgin Ibryam > Missing or misplaced resource bundle property in ParyUiLabels.xml > ----------------------------------------------------------------- > > Key: OFBIZ-1699 > URL: https://issues.apache.org/jira/browse/OFBIZ-1699 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: Ubuntu 7.10, Firefox 2.0.11 > Reporter: Raj Saini > Assignee: Bilgin Ibryam > Priority: Minor > > CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1699. -------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Thanks Raj. Committed in trunk rev. 634920 > Missing or misplaced resource bundle property in ParyUiLabels.xml > ----------------------------------------------------------------- > > Key: OFBIZ-1699 > URL: https://issues.apache.org/jira/browse/OFBIZ-1699 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: Ubuntu 7.10, Firefox 2.0.11 > Reporter: Raj Saini > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > > CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576523#action_12576523 ] Bilgin Ibryam commented on OFBIZ-1699: -------------------------------------- Raj, In the commit log I wrote by mistake "Applied my patch... " but it is actually your fix. I am sorry for that. Thanks again for reporting and proposing how to fix it. > Missing or misplaced resource bundle property in ParyUiLabels.xml > ----------------------------------------------------------------- > > Key: OFBIZ-1699 > URL: https://issues.apache.org/jira/browse/OFBIZ-1699 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: Ubuntu 7.10, Firefox 2.0.11 > Reporter: Raj Saini > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > > CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576535#action_12576535 ] Raj Saini commented on OFBIZ-1699: ---------------------------------- Nevermind Bilgin. Thanks for your quick action and fix. > Missing or misplaced resource bundle property in ParyUiLabels.xml > ----------------------------------------------------------------- > > Key: OFBIZ-1699 > URL: https://issues.apache.org/jira/browse/OFBIZ-1699 > Project: OFBiz > Issue Type: Bug > Components: party > Affects Versions: SVN trunk > Environment: Ubuntu 7.10, Firefox 2.0.11 > Reporter: Raj Saini > Assignee: Bilgin Ibryam > Priority: Minor > Fix For: SVN trunk > > > CommunicationEventServices.java (line 159) refers to a resource bundle property "commeventservices.errorForEmailAddress" which does not exists in the PartyUiLable. Instead there is a property "commeventservices.errorInSendEmailToContactListService" in PartyUiLabel.xml (line 6829). To me it looks "commeventservices.errorForEmailAddress" property referred in CommunicationEventServices.java is misplaced and it should be "commeventservices.errorInSendEmailToContactListService". If someone can confirm this, I will create a patch and submit. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |