[jira] Created: (OFBIZ-1700) To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz

[Nicolas Malin (Jira)]

To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
----------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1700
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
             Project: OFBiz
          Issue Type: New Feature
            Reporter: Vikas Mayur


 We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1700:
-------------------------------

    Attachment: screenshot2.png

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: screenshot1.png, screenshot2.png
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1700:
-------------------------------

    Attachment: screenshot1.png

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: screenshot1.png, screenshot2.png
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vikas Mayur updated OFBIZ-1700:
-------------------------------

    Description:
 We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html




  was:
 We can put OFBiz Revision Number :
1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
2) In the footer file. Refer to screenshot2 a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: screenshot1.png, screenshot2.png
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1700:
-------------------------------

    Attachment: svninfo.patch

A very simple solution could be the following: (implemented in the attached "svninfo.patch")

The footer.ftl includes a link to an external file (/images/svninfo.txt).
This file is generated with a new ant task that can be run with "ant svninfo".
The ant task uses the "svn info" command and captures the output.

In the patch there is a default svninfo.txt file that should be committed that contains the following:
-----------------------
**** SVN info not present !!! ****
**** Please run "ant svninfo" ****
-----------------------

When the ant task is run it is overwritten and the correct svn information are displayed as follows:
-----------------------
Percorso: .
URL: http://svn.apache.org/repos/asf/ofbiz/trunk
Repository: http://svn.apache.org/repos/asf
UUID del Repository: 13f79535-47bb-0310-9956-ffa450edef68
Revisione: 634426
Tipo di Nodo: directory
Azione: normale
Autore dell'Ultimo Cambiamento: chrisg
Revisione dell'Ultimo Cambiamento: 634226
Data dell'Ultimo Cambiamento: 2008-03-06 12:33:26 +0100 (gio, 06 mar 2008)
-----------------------

The best would be IMHO to have the additional link in the footer only if a configuration property is set so that could be disabled for production installations.

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: screenshot1.png, screenshot2.png, svninfo.patch
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1700:
-------------------------------

    Attachment: svninfo_ss2.gif
                svninfo_ss1.gif

In the attached files you can see how the link looks like in the footer (svninfo_ss1.gif) and what you get when you click on it (svninfo_ss2.gif)

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1700:
-------------------------------

    Attachment: about_ss.JPG

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1700:
-------------------------------

    Attachment: about_app.zip

Hi,
I have worked a little bit on this issue and have set up a little application that you can find in the about_app.zip attachment. (see about_ss.jpg for a sample screenshot). Hereafter i post the content of the readme.txt file that is also included in the app.
Hope this helps!

--------------------------------------------------------
This application can be used to show to the OFBiz user information about the SVN revision that has originated the running release.

Requisite:
- The "svn" command line Subversion client must present in the system and available on the execution path.
- The OFBiz ant build task must be executed from a valid SVN working copy (.svn directories must be present)

Installation:
- Copy the About application in the OFBiz hot-deploy directory

Usage:
- Every time the OFBiz working copy is updated from the SVN repository the ant "build" target must be executed. This can be done
  simply running the "ant refresh" command on the OFBiz
- The information are shown selecting the About application

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610339#action_12610339 ]

Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------

Should we close this issue ? No one seems really interested...

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1700.
----------------------------------

    Resolution: Later
      Assignee: Jacques Le Roux

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-1700:
------------------------------------


We need that !

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Busco updated OFBIZ-1700:
-------------------------------

    Attachment: svninfo.patch

Please find attached a new patch.
This solution is much simpler:
The ant svninfo task does everithing. The Abouut application is not necessary.

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010 ]

Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------

Hi Bruno,

It's great, but I see a problem with this approach :  if for a reason or another svninfo is not run, then svninfo.ftl will contain a wrong release number.
I suggest that
* we put "unknown" in place of  ??? by default (more clear)
* we put back "unknown" in svninfo.ftl when "build", or a "run-" target is run (maybe did not look into details)

My 2cts

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1700:
-----------------------------------

    Attachment: svninfo.patch

Something like last patch

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670024#action_12670024 ]

Adrian Crum commented on OFBIZ-1700:
------------------------------------

It's unfortunate we don't have a way to set up the repository so that each revision number is stored in a file in the OFBiz home folder. The current revision could be read from the file during OFBiz startup, stored internally, and then accessed for display.

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Bruno Busco]

Yes,
this is a good point.
I agree but I then suggest to have the svninfo.ftl not committed.
It will be created by a "ant build" command (with "unknown") and/or by the
"ant svinfo" (with the correct version).

If this is ok I will proceed to update the patch.
-Bruno

2009/2/3 Jacques Le Roux (JIRA) <[hidden email]>

>
>    [
> https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010]
>
> Jacques Le Roux commented on OFBIZ-1700:
> ----------------------------------------
>
> Hi Bruno,
>
> It's great, but I see a problem with this approach :  if for a reason or
> another svninfo is not run, then svninfo.ftl will contain a wrong release
> number.
> I suggest that
> * we put "unknown" in place of  ??? by default (more clear)
> * we put back "unknown" in svninfo.ftl when "build", or a "run-" target is
> run (maybe did not look into details)
>
> My 2cts
>
> > To show Current Revision number of OFBiz on its home site that will
> facilate in testing and comparing things with a local copy of OFBiz
> >
> ----------------------------------------------------------------------------------------------------------------------------------------
> >
> >                 Key: OFBIZ-1700
> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
> >             Project: OFBiz
> >          Issue Type: New Feature
> >            Reporter: Vikas Mayur
> >            Assignee: Jacques Le Roux
> >         Attachments: about_app.zip, about_ss.JPG, screenshot1.png,
> screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif,
> svninfo_ss2.gif
> >
> >
> >  We can put OFBiz Revision Number :
> > 1) along with the Trunk and Release labels under Demo Sites section in
> OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> > 2) In the footer file. Refer to screenshot2 & a discussion started by
> Jacques at
> http://www.nabble.com/Mention-of-version---in-release-to13078575.html
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[Jacques Le Roux]

Yes this seems wiser/simpler indeed.
The "unknown" generation should not be only in "ant build"' I guess, at least "ant run-install" as well and surely more (I use
mostly these 2)

Jacques

From: "Bruno Busco" <[hidden email]>

> Yes,
> this is a good point.
> I agree but I then suggest to have the svninfo.ftl not committed.
> It will be created by a "ant build" command (with "unknown") and/or by the
> "ant svinfo" (with the correct version).
>
> If this is ok I will proceed to update the patch.
> -Bruno
>
> 2009/2/3 Jacques Le Roux (JIRA) <[hidden email]>
>
>>
>>    [
>> https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670010#action_12670010]
>>
>> Jacques Le Roux commented on OFBIZ-1700:
>> ----------------------------------------
>>
>> Hi Bruno,
>>
>> It's great, but I see a problem with this approach :  if for a reason or
>> another svninfo is not run, then svninfo.ftl will contain a wrong release
>> number.
>> I suggest that
>> * we put "unknown" in place of  ??? by default (more clear)
>> * we put back "unknown" in svninfo.ftl when "build", or a "run-" target is
>> run (maybe did not look into details)
>>
>> My 2cts
>>
>> > To show Current Revision number of OFBiz on its home site that will
>> facilate in testing and comparing things with a local copy of OFBiz
>> >
>> ----------------------------------------------------------------------------------------------------------------------------------------
>> >
>> >                 Key: OFBIZ-1700
>> >                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>> >             Project: OFBiz
>> >          Issue Type: New Feature
>> >            Reporter: Vikas Mayur
>> >            Assignee: Jacques Le Roux
>> >         Attachments: about_app.zip, about_ss.JPG, screenshot1.png,
>> screenshot2.png, svninfo.patch, svninfo.patch, svninfo_ss1.gif,
>> svninfo_ss2.gif
>> >
>> >
>> >  We can put OFBiz Revision Number :
>> > 1) along with the Trunk and Release labels under Demo Sites section in
>> OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
>> > 2) In the footer file. Refer to screenshot2 & a discussion started by
>> Jacques at
>> http://www.nabble.com/Mention-of-version---in-release-to13078575.html
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670555#action_12670555 ]

Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------

I think, it's always better to keep comments in issue and not diverging on dev ML

{quote}Yes this seems wiser/simpler indeed.
The "unknown" generation should not be only in "ant build"' I guess, at least "ant run-install" as well and surely more (I use
mostly these 2)

Jacques

From: "Bruno Busco" <[hidden email]>
> Yes,
> this is a good point.
> I agree but I then suggest to have the svninfo.ftl not committed.
> It will be created by a "ant build" command (with "unknown") and/or by the
> "ant svinfo" (with the correct version).
>
> If this is ok I will proceed to update the patch.
> -Bruno
{quote}

Finally I thought about that a bit more and I think it's easier to do it as I did : you don't have to worry about existing and future targets. In any case, if svninfo was not run, "unknown" will be shown. We may even put an information about that in svinfo.ftl : instead of only
unknwon
put
unknwon (run "ant svninfo" to show your version)

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1700:
-----------------------------------

    Attachment: svninfo.patch

patch with : (run "ant svninfo" to show your version)

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670704#action_12670704 ]

Jacopo Cappellato commented on OFBIZ-1700:
------------------------------------------

From the dev list:

Bruno,

I like the approach you are taking (an ant target that writes the rev id into a text file that is then included into the footer).
However, it would be great if you would address the following scenarios/:

1) svn is not available: the build process should proceed without errors
2) the ant svn plugin is not available (I think it is an optional lib): the build process should proceed without errors
3) internate connection is not available when the ant target is invoked: the build process should proceed without errors
4) evaluate possible license issues (if any) with the ant svn plugin
5) (as Tim mentioned) the trunk was exported instead of checked out

Ideally, in all these situations the footer should show an empty rev id.

Also, where should we place the text file with the rev number in it? I'd suggest in the runtime folder (so that we don't write files inside the framework).

Just my 2 cents,

Jacopo

> To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.