[jira] Created: (OFBIZ-1756) Happy hour promotions

[Nicolas Malin (Jira)]

Happy hour promotions
---------------------

                 Key: OFBIZ-1756
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
             Project: OFBiz
          Issue Type: New Feature
          Components: product
    Affects Versions: SVN trunk
            Reporter: Bilgin Ibryam
            Priority: Minor




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1756:
---------------------------------

    Attachment: happy_hour_promo.patch

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam reassigned OFBIZ-1756:
------------------------------------

    Assignee: Bilgin Ibryam

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592983#action_12592983 ]

Bilgin Ibryam commented on OFBIZ-1756:
--------------------------------------

The discussion about this issue can be followed here http://www.nabble.com/Happy-hour-promotions-to16853097.html
Some important remarks from David:

The design intent going forward is still to deprecate the  
TechDataCalendarWeek entity and make sure that the Recurrence*  
entities can handle those sorts of time period definitions.

Sooner or later someone needs to go through and figure that out,  
extending the entity and the generic methods that work with it.

If you don't want to dive into that now it's fine, but I just mention  
it so there is a little more public awareness of this redundancy in  
the data model and the hope to have a stronger generic base to work  
from in the future.

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1756:
---------------------------------

    Attachment: promotion_recurrence.patch

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596191#action_12596191 ]

Bilgin Ibryam commented on OFBIZ-1756:
--------------------------------------

David, thank you for showing the right way.

I created a new patch which uses RecurrenceInfo and RecurrenceRule entities instead of TechDataCalendarWeek. Added a demo happy hour  promotion.

Fixed some bugs in RecurrenceRule.java and added new method, which checks if the given time is valid for the current recurrence rule.

If you think that the patch is fine, please someone with framework access commit it.

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1756:
---------------------------------

    Assignee:     (was: Bilgin Ibryam)

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1756:
---------------------------------

    Component/s: framework

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bilgin Ibryam updated OFBIZ-1756:
---------------------------------

    Attachment: promotion_recurrence.patch

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597851#action_12597851 ]

Jacques Le Roux commented on OFBIZ-1756:
----------------------------------------

Please Bilgin, should we use both patches or only the last one (did not look in them yet) ?

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597889#action_12597889 ]

Bilgin Ibryam commented on OFBIZ-1756:
--------------------------------------

happy_hour_promo.patch  is using TechDataCalendarWeek entity which will be depreceted soon. I let is in the issue only for demonstration purpose.

promotion_recurrence.patch is using RecurrenceInfo and RecurrenceRule entities and only this patch should be committed.

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David E. Jones closed OFBIZ-1756.
---------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Bilgin Ibryam

This approach looks good Bilgin and based on a quick review it looks fine.

I've committed the recurrence patch in SVN rev 658108.

This is a great addition to the implementation of the recurrence stuff for use all over the place in OFBiz, even in the service job scheduler.

> Happy hour promotions
> ---------------------
>
>                 Key: OFBIZ-1756
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1756
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework, product
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Assignee: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: happy_hour_promo.patch, promotion_recurrence.patch, promotion_recurrence.patch
>
>

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.