[jira] Created: (OFBIZ-1758) Sandbox: Changes to Layout Needed for Internet Explorer 7

[Nicolas Malin (Jira)]

Sandbox: Changes to Layout Needed for Internet Explorer 7
---------------------------------------------------------

                 Key: OFBIZ-1758
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: SVN trunk
            Reporter: Adrian Crum
            Assignee: Adrian Crum
            Priority: Minor
             Fix For: SVN trunk


The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-1758:
-------------------------------

    Attachment: tab-bar-fix.patch

tab-bar-fix.patch is a solution I came up with for the tab-bar style problem.

IE7 paints container padding OVER the contained elements - which broke the tab-bar style that we use. A temporary fix was committed that made the tab-bar style usable, but now it doesn't look right in other browsers.

The patch's solution involves adding another decorator-section element to the Global Decorator, and putting the menu using the tab-bar style in that decorator section. It's a little more complicated solution than I like, but I can't come up with any other way to fix it.

Apply the patch, then navigate to

https://127.0.0.1:8443/partymgr/control/viewprofile?partyId=admin

to see the fix.

Please evaluate and comment. I'll wait until after the weekend before proceeding further.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592924#action_12592924 ]

Adrian Crum commented on OFBIZ-1758:
------------------------------------

I figured out the problem with IE7 and the main navigation - it doesn't support the :hover pseudo class on elements that aren't links. I reversed the direction of the tab gifs and got it to work. I also learned that IE7 doesn't support CSS class inheritance - that's why the fonts inside <table> elements are whacky.

I have fixed a number of the IE7 layout issues and I will commit the fixes as soon as commit access is restored to the repository.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592949#action_12592949 ]

Jacopo Cappellato commented on OFBIZ-1758:
------------------------------------------

Adrian,

first of all, thanks for your work on this.
I've noticed that in some screens the error messages returned by services (for example when a form with incorrect data is submitted) don't appear anymore: my first guess was that something was wrong in the ui labels side of things but now I'm wondering if it is just a layout issue (the errors are in the html page but they are hidden, due to some css issues, by another element in the page).
Is this possible? I will try to get more details as soon as I have a free minute.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593155#action_12593155 ]

Jacques Le Roux commented on OFBIZ-1758:
----------------------------------------

Hi Adrian,

I see at list one issue : have a look at the catalog main page. Also https://localhost:8443/projectmgr/control/projectView?projectId=9100. Shooting a moving target (Micro$oft is a specialist for that) is not easy, thanks for your work !

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593156#action_12593156 ]

Adrian Crum commented on OFBIZ-1758:
------------------------------------

Jacques,

The screens that use the tab-bar style will have to be updated to use the new decorator-section. I provided some examples in the Party Manager component, but I haven't converted all of the screens. I apologize for the confusion.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593403#action_12593403 ]

Adrian Crum commented on OFBIZ-1758:
------------------------------------

I found another IE7 bug. If you float an element inside a container that has a background color set, IE7 paints the background color OVER the floated element.

I'm thinking we may have to put IE CSS fixes in a separate style sheet that is loaded conditionally.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593428#action_12593428 ]

Jacques Le Roux commented on OFBIZ-1758:
----------------------------------------

Adrian,

Yes I agree : we need to support IE 7.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641733#action_12641733 ]

Jacques Le Roux commented on OFBIZ-1758:
----------------------------------------

Seems that we have crossed the Float Drop Bug. Not sure it's the best but here is something which cope with that http://opentaps.org/docs/index.php/CSS_Display_Bugs_in_IE

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641882#action_12641882 ]

Adrian Crum commented on OFBIZ-1758:
------------------------------------

Jacques,

I don't agree with the solution in that link. First of all, our styles are not based on pixels. Secondly, our multi-column layouts use percentages - so the screen can be resized.

The real problem is due to IE7's inability to perform simple math. Example: left column width set to 30%, right column width set to 70%. In IE7, 30 + 70 = 110 (or some other number greater than 100).

To solve this problem, column widths have to be reduced to less than 100% total. But that results in an unacceptable gap between columns in other browsers - so a hack has to employed to reduce column widths only in IE7. That's why I suggested an IE-specific style sheet that could be cascaded from the main one. The maincss.css file could accommodate all non-IE browsers, and the IE spreadsheet contains the IE hacks and fixups. Using IE-specific HTML, it could be loaded conditionally.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641888#action_12641888 ]

Jacques Le Roux commented on OFBIZ-1758:
----------------------------------------

Yes I agree with you Adrian, that why I did not even try to apply it in OFBiz (I mean pixel fixed width).
I agree also on the IE-specific style sheet. I think the best deal with that is to use "Conditional Comments" (it's the recommended best practice AFAIK) like

{code}
<link rel="stylesheet" type="text/css" href="Styles.css" media="all"/>
<!--[if lt IE 7]>
<link rel="stylesheet" type="text/css" href="Styles-IE6.css" media="all"/>
<![endif]-->
<!--[if IE 7]>
<link rel="stylesheet" type="text/css" href="Styles-IE7.css" media="all"/>
<![endif]-->
{code}

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-1758.
------------------------------

    Resolution: Fixed

Closing this due to introduction of visual themes.

> Sandbox: Changes to Layout Needed for Internet Explorer 7
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1758
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1758
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: tab-bar-fix.patch
>
>
> The latest Internet Explorer update breaks a lot of our existing layout. This issue is intended for collaboration on solutions to the IE7 layout problems. Details are in the comments.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.