[jira] Created: (OFBIZ-1775) Bug when adding an item to an existing order created online by a customer in eCommerce

[Nicolas Malin (Jira)]

Bug when adding an item to an existing order created online by a customer  in eCommerce
---------------------------------------------------------------------------------------

                 Key: OFBIZ-1775
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1775
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk, Release Branch 4.0
            Reporter: Jacques Le Roux


If you want to add an item to an existing order created online by a customer in eCommerce (I think this makes sense as a customer could ask by phone to add after she/he has made her/his order online), you get this error if you have a configured product in the order

2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ ShoppingCartItem.java:535:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ShoppingCartServices.java:376:ERROR]
---- exception report ----------------------------------------------------------
Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
---- stack trace ---------------------------------------------------------------
org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:536)
org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:345)
org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:593)
[...]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599889#action_12599889 ]

Jacques Le Roux commented on OFBIZ-1775:
----------------------------------------

This issue seems related to https://issues.apache.org/jira/browse/OFBIZ-1453. I retested : you can't "Create As New Order" as soon as you are in the state described above. In other words you can duplicate  an order containing a configurable product before adding another item to it but as soon as you have added a product (of any kind) you can't.

The weird point is that it works (adding a product in ordermgr) the 1st time for PC001 but not after. It does not work even the 1st time for ENCHILADAS.
So in the case of PC001 it seems that we loose the AGGREGATED_CONF infos the 1st time we add a product. A clue may be that if for ENCHILADAS you don't use the default setting but change at least an option (I guess, I changed only both in my test) then it works also the 1st time for it.

I propose to put the 2 checking blocks ASSET_USAGE (ShoppingCartItem[471]) and AGGREGATED (ShoppingCartItem[529]) under the scope of the skipProductChecks parameter to skip these 2 blocks when we just add an item to an existing already approved order.  The same trick could maybe be used in the case of the order duplication ("Create As New Order")

I will propose a patch soon.

> Bug when adding an item to an existing order created online by a customer  in eCommerce
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1775
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1775
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Jacques Le Roux
>
> If you want to add an item to an existing order created online by a customer in eCommerce (I think this makes sense as a customer could ask by phone to add after she/he has made her/his order online), you get this error if you have a configured product in the order
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ ShoppingCartItem.java:535:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ShoppingCartServices.java:376:ERROR]
> ---- exception report ----------------------------------------------------------
> Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
> Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> ---- stack trace ---------------------------------------------------------------
> org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:536)
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:345)
> org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:593)
> [...]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-1775:
-----------------------------------

    Attachment: ShoppingCartItem.java.patch

> Bug when adding an item to an existing order created online by a customer  in eCommerce
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1775
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1775
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Jacques Le Roux
>         Attachments: ShoppingCartItem.java.patch
>
>
> If you want to add an item to an existing order created online by a customer in eCommerce (I think this makes sense as a customer could ask by phone to add after she/he has made her/his order online), you get this error if you have a configured product in the order
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ ShoppingCartItem.java:535:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ShoppingCartServices.java:376:ERROR]
> ---- exception report ----------------------------------------------------------
> Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
> Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> ---- stack trace ---------------------------------------------------------------
> org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:536)
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:345)
> org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:593)
> [...]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1775.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 4.0
                   SVN trunk
         Assignee: Jacques Le Roux

Commited a completed and amended patch in trunk rev. 660680, release4.0 660691

> Bug when adding an item to an existing order created online by a customer  in eCommerce
> ---------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1775
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1775
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk, Release Branch 4.0
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk, Release Branch 4.0
>
>         Attachments: ShoppingCartItem.java.patch
>
>
> If you want to add an item to an existing order created online by a customer in eCommerce (I think this makes sense as a customer could ask by phone to add after she/he has made her/his order online), you get this error if you have a configured product in the order
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ ShoppingCartItem.java:535:WARN ] Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> 2008-05-08 16:10:56,343 (http-0.0.0.0-18443-Processor4) [ShoppingCartServices.java:376:ERROR]
> ---- exception report ----------------------------------------------------------
> Exception: org.ofbiz.order.shoppingcart.CartItemModifyException
> Message: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> ---- stack trace ---------------------------------------------------------------
> org.ofbiz.order.shoppingcart.CartItemModifyException: Tried to add the Product Enchiladas (productId: ENCHILADAS) to the cart, not adding: the product is not configured correctly.
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:536)
> org.ofbiz.order.shoppingcart.ShoppingCartItem.makeItem(ShoppingCartItem.java:345)
> org.ofbiz.order.shoppingcart.ShoppingCart.addItemToEnd(ShoppingCart.java:593)
> [...]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.