[jira] Created: (OFBIZ-1794) Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.

[Nicolas Malin (Jira)]

Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
-----------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1794
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
             Project: OFBiz
          Issue Type: New Feature
          Components: order
            Reporter: Jacopo Cappellato
            Priority: Minor


Implement CRUD services and UI for the AgreementRole entity:
* CRUD services should be implemented in the order component
* UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)

Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
* for sales orders, the party is associated as a CUSTOMER (AgreementRole)
* for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)

We may want to define a view-entity (AgreementAndRole) to perform the lookup.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-1794:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597867#action_12597867 ]

Jacopo Cappellato commented on OFBIZ-1794:
------------------------------------------

The last part of this task is to extend this to the eCommerce application:
when the customer submits the user/password in the ecommerce site, the system will check if there are agreements in place and if they are found:
if there is more than one agreement display a drop down box similar to the one of the order component but force the user to select at least one; if there is just one agreement, notify the user that the agreement will be used
The selected agreement will be set in the cart in the session.
Note that this is mostly the same behavior of the backend order entry.

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment: AgreementProcessing .patch

Improvements done in patch given by Raviendra Mandre , I have implemented  Agreement processing for e-commerce and done some changes as per the details.

Thanks to Rishi Solanki for review,
And Pranay Pandey for explaning work done by raviendra.

Done By :
- Ratnesh Upadhyay

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment: AgreementProcessing.patch

Here is the Updated patch.
Thanks Ashish for suggestions.

- Ratnesh Upadhyay

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment:     (was: AgreementProcessing.patch )

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment: AgreementProcessing.patch

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment:     (was: AgreementProcessing.patch)

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ratnesh Upadhyay updated OFBIZ-1794:
------------------------------------

    Attachment: AgreementProcessing.patch

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604448#action_12604448 ]

Ashish Vijaywargiya commented on OFBIZ-1794:
--------------------------------------------

Thanks Ratnesh and Ravindra for your patch.
Its in trunk rev # 667006.

Special thanks to Rishi Solanki for helping the guys.

--
Ashish

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604451#action_12604451 ]

Ashish Vijaywargiya commented on OFBIZ-1794:
--------------------------------------------

For now I am not closing this issue.
If nobody will be having any objection in few days then I will close this issue.

--
Ashish

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-1794.
--------------------------------------

    Resolution: Fixed

Didn't get any comment on the commit Related to this issue.
So I think its safe to close this issue.

--
Ashish

> Implement CRUD services and UI for the AgreementRole entity; enhance the way agreement are associated to parties.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1794
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1794
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>            Reporter: Jacopo Cappellato
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: AgreementProcessing .patch, AgreementProcessing.patch
>
>
> Implement CRUD services and UI for the AgreementRole entity:
> * CRUD services should be implemented in the order component
> * UI is in the accounting component (but in the future we will move all the Agreement screens to the order component as well)
> Then, in the orderagreements.bsh script in the order component we will enhance the way agreements associated to parties are selected.
> Right now, at lines 50 and 54, agreements are selected only considering the role types in the Agreement entity; we should additionally include the agreements in which:
> * for sales orders, the party is associated as a CUSTOMER (AgreementRole)
> * for purchase orders, the party is associated as a SUPPLIER  (AgreementRole)
> We may want to define a view-entity (AgreementAndRole) to perform the lookup.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.