[jira] Created: (OFBIZ-1796) A scheduled service to generate Invoice.

[Nicolas Malin (Jira)]

A scheduled service to generate Invoice.
----------------------------------------

                 Key: OFBIZ-1796
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
             Project: OFBiz
          Issue Type: Improvement
          Components: accounting
            Reporter: Sumit Pandit
            Priority: Minor


A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1796:
--------------------------------

    Attachment: InvoiceScheduleService.patch

Here is the patch for scheduled service to generate the invoice peroidically.
In this patch it generates the invoice monthly.

for this I add a new field (recurrenceInfoId)in the Entity Invoice.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1796:
--------------------------------

    Attachment: InvoiceScheduleService.patch

corrected a spelling mistake in previous patch.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597723#action_12597723 ]

Vikas Mayur commented on OFBIZ-1796:
------------------------------------

Sumit,

In service autoGenerateInvoiceFromTemplate, I think we need to generate a new invoice and not a invoice template.
Invoice template will be only be used to generate  new Invoices.

Other thing I see is the service definition, recurrenceInfoId field should be false.

- Vikas

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1796:
--------------------------------

    Attachment: InvoiceScheduleService.patch

Thanks Vikas for your suggestions.
The new corrected patch is uploaded.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-1796:
--------------------------------------

    Assignee: Jacques Le Roux

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652559#action_12652559 ]

Jacques Le Roux commented on OFBIZ-1796:
----------------------------------------

Hi Sumit,

I suppose it should be launched every month and not every minute, isn'it ?
Also not sure why there are 2 "applications/accounting/ofbiz-component.xml (revision 657321)"
Also the service name should not better be autoGenerateInvoicesFromTemplate ?

Else seems quite good

I'm always impressed by all the services which are available in OFBiz (I often learn at least one while reviewing :o)

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653238#action_12653238 ]

BJ Freeman commented on OFBIZ-1796:
-----------------------------------

suggestions:
Though some businesses invoice monthly, some invoice daily.
so the interval should be accessible to the user, via a UI, say in accounting.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653243#action_12653243 ]

Jacques Le Roux commented on OFBIZ-1796:
----------------------------------------

I second BJ's suggestion

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654048#action_12654048 ]

Sumit Pandit commented on OFBIZ-1796:
-------------------------------------

Thank you BJ and Jacques for your comments, Now a days I am little bit busy in some other work, but I am sure that I'll implement the suggestion given by you As I get time for it.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654050#action_12654050 ]

Sumit Pandit commented on OFBIZ-1796:
-------------------------------------

Jacques, I was a bit confuse regarding to the service name, It would be appreciable if some one please suggest better name for it.

Thanks
Sumit Pandit

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656141#action_12656141 ]

Jacques Le Roux commented on OFBIZ-1796:
----------------------------------------

autoGenerateInvoiceFromExistingInvoice ?

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656249#action_12656249 ]

Sumit Pandit commented on OFBIZ-1796:
-------------------------------------

Thanks a lot Jacques,
I will try to do work on it by this Sunday. Sorry for being delay.

--
Ragards
Sumit Pandit

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sumit Pandit updated OFBIZ-1796:
--------------------------------

    Attachment: InvoiceScheduleService.patch

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656544#action_12656544 ]

Sumit Pandit commented on OFBIZ-1796:
-------------------------------------

Thanks Jacques and BJ,
Here is the corrected patch. Currently it contains the schedule service which generate the invoices monthly.
Later we will provide the choice to user to set the frequency of RecurrenceRule.
Thanks again.

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1796.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Hi Sumit,

Your patch in in trunk revision: 726662  

In future please provide UI labels (here for Recurrence Info Id, something like    <property key="FormFieldTitle_recurrenceInfoId ">...)

Thanks

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656961#action_12656961 ]

Sumit Pandit commented on OFBIZ-1796:
-------------------------------------

Thank you very much Jacques, for commit and for comment.

Thanks
Sumit Pandit

> A scheduled service to generate Invoice.
> ----------------------------------------
>
>                 Key: OFBIZ-1796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1796
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Sumit Pandit
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch, InvoiceScheduleService.patch
>
>
> A scheduled service which generate an invoice from invoice template in a regular intervel.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.