[jira] Created: (OFBIZ-1811) Move Billing Account permissions to follow new the pattern

[Nicolas Malin (Jira)]

Move Billing Account permissions to follow new the pattern
----------------------------------------------------------

                 Key: OFBIZ-1811
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
             Project: OFBiz
          Issue Type: Task
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Rashko Rejmer
            Priority: Minor
             Fix For: SVN trunk


Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1811:
---------------------------------

    Attachment: billing_account_permissions.xml

Patch for the issue.

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.xml
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1811:
---------------------------------

    Attachment: billing_account_permissions.patch

I changed the file extension. Sorry!

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1811:
---------------------------------

    Attachment:     (was: billing_account_permissions.xml)

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1811:
---------------------------------

    Attachment: billing_account_permissions.patch

One more service converted to use the new pattern.

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch, billing_account_permissions.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1811.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Rashko,

Your patch is in trunk rev.  662726. Despite this was a recent patch I add to delete uiLabels entries by hand, OFBiz is really accelerating this last time :o) Also don't forget to use a relative path (but anyway this is trivial as it takes 3 sec to fix ;o)

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch, billing_account_permissions.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer reopened OFBIZ-1811:
----------------------------------


It was bad idea to add permission checking to calcBillingAccountBalance service because it is used in ecommerce when paying with billing account.

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch, billing_account_permissions.patch, calcBillingAccountBalance.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rashko Rejmer updated OFBIZ-1811:
---------------------------------

    Attachment: calcBillingAccountBalance.patch

This patch removes permission checking for calcBillingAccountBalance service.

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch, billing_account_permissions.patch, calcBillingAccountBalance.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1811.
----------------------------------

    Resolution: Fixed

Thanks Rashko,

I have committed your patch in trunk revision 664697. Sorry to have not spotted this one, and thanks for your care.

> Move Billing Account permissions to follow new the pattern
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1811
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1811
>             Project: OFBiz
>          Issue Type: Task
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Rashko Rejmer
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: billing_account_permissions.patch, billing_account_permissions.patch, calcBillingAccountBalance.patch
>
>
> Make BillingAccount* CRUD services to follow the new permissions pattern.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.