OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

14 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

Conversion from Writer to Appendable for all rendering classes
--------------------------------------------------------------

Key: OFBIZ-1816
URL: https://issues.apache.org/jira/browse/OFBIZ-1816
Project: OFBiz
Issue Type: Improvement
Components: content, framework
Reporter: Jacopo Cappellato
Priority: Minor

Based on a recent discussion in the dev list, and especially on the comments from David Jones and the work done by Adrian Crum, I'm submitting here for your review a patch to refactor all the widget rendering methods and some of the content and Freemarker rendering classes to use Appendable instead of Writer.
What do you think?
There is just one place where the code is not very good; in the FreeMarkerWorker.renderTemplate (at line 197) I've added a casting from Appendable to Writer:

Environment env = template.createProcessingEnvironment(context, (Writer)outWriter);

This would cause an issue if in the future we will not pass a Writer to that method.
I'm testing this work right now; if there are no objections I am going to commit this in the next few days.

Jacopo

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

[ https://issues.apache.org/jira/browse/OFBIZ-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato updated OFBIZ-1816:
-------------------------------------

Attachment: writer2appendable.patch

In this patch all the method's signature have been modified from Writer to Appendable and all the calls to Writer.write have been converted to Appendable.append

> Conversion from Writer to Appendable for all rendering classes
> --------------------------------------------------------------
>
> Key: OFBIZ-1816
> URL: https://issues.apache.org/jira/browse/OFBIZ-1816
> Project: OFBiz
> Issue Type: Improvement
> Components: content, framework
> Reporter: Jacopo Cappellato
> Priority: Minor
> Attachments: writer2appendable.patch
>
>
> Based on a recent discussion in the dev list, and especially on the comments from David Jones and the work done by Adrian Crum, I'm submitting here for your review a patch to refactor all the widget rendering methods and some of the content and Freemarker rendering classes to use Appendable instead of Writer.
> What do you think?
> There is just one place where the code is not very good; in the FreeMarkerWorker.renderTemplate (at line 197) I've added a casting from Appendable to Writer:
> Environment env = template.createProcessingEnvironment(context, (Writer)outWriter);
> This would cause an issue if in the future we will not pass a Writer to that method.
> I'm testing this work right now; if there are no objections I am going to commit this in the next few days.
> Jacopo

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Eric DE MAULDE

SIPS : external credit card payment (Atos Origin)

In reply to this post by Nicolas Malin (Jira)

Hi,

I begin in the JAVA language and OFBiz.
I succeeded to implement this payment in the accounting application.
Now to share this development, how do I implement it in the "specialpurpose"
directory ?
Do I keep the same directory tree than in the accounting application, as
far as the "thirdparty" directory ?
I already read the FAQ, do you have another article or documentation ?

Thanks

Eric

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601467#action_12601467 ]

Adrian Crum commented on OFBIZ-1816:
------------------------------------

Jacopo,

Thank you for your work! I'll test it today and let you know what I find.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Jacques Le Roux

Re: SIPS : external credit card payment (Atos Origin)

Administrator

In reply to this post by Eric DE MAULDE

Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdparty seems fine to me

Have you any files outside of this directory ?

Jacques

From: "Eric DE MAULDE" <[hidden email]>

> Hi,
>
> I begin in the JAVA language and OFBiz.
> I succeeded to implement this payment in the accounting application.
> Now to share this development, how do I implement it in the "specialpurpose"
> directory ?
> Do I keep the same directory tree than in the accounting application, as
> far as the "thirdparty" directory ?
> I already read the FAQ, do you have another article or documentation ?
>
> Thanks
>
> Eric
>

Eric DE MAULDE

Re: SIPS : external credit card payment (Atos Origin)

Hi Jacques,

Thanks for your help

Here is my files tree :

/applications/accounting/config/sips/certif.fr.01429303911111
(binary)

parmcom.01429303911111
(full URLs to return and cancel page, auto response servlet ; currency, shop
logo, payment means)

certif..fr.
01429303911111- (binary)

pathfile
(credit card logo URL, full path to these files in this directory)

parmcom.sips
(display properties, accepted card list, buyer language code, bank logo,
shop contry code, shop language code)

/applications/accounting/lib/sips/apipayment.jar

/applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including the path to "pathfile" ; first method "service") sipsResponseServlet.java (ditto) sipsAutoResponseServlet.java (ditto)Data :"insert into PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID, DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è Via /applications/accounting/data/AccountingTypeData.xml"insert into PAYMENT_METHOD_TYPE_GL_ACCOUNT (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values ('EXT_SIPS', 'Company','122500')"è Via /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar" extension in/applications/accounting/ofbiz-component.xml+ translations+ changes in /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
and web.xml+ changes in /applications/accounting/build.xml+ add images in /framework//images/webapp/images/sips/... .gif+ changes in ecommerce .ftl filesProblems :. Where can I save many different bank response codes (from my bank and AtosOrigin) ? From these codes, I manage payment validation.. the API language codes have just 2 chars, how can I manage that ?Do you want me to send you files ?Eric> Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to me>> Have you any files outside of this directory ?>> Jacques>> From: "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA language and OFBiz.>> I succeeded to implement this payment in the accounting application.>> Now to share this development, how do I implement it in the"specialpurpose" directory ?>> Do I keep the same directory tree than in the accounting application, asfar as the "thirdparty" directory ?>> I already read the FAQ, do you have another article or documentation ?
>>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.4/1476 - ReleaseDate: 31/05/2008 12:25>>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601507#action_12601507 ]

Adrian Crum commented on OFBIZ-1816:
------------------------------------

Jacopo,

I've been using this patch all day without problems. I'd suggest committing it. As soon as it is committed I will begin cleaning up the compiler warnings.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-1816) Conversion from Writer to Appendable for all rendering classes

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1816.
------------------------------------

Resolution: Fixed

Thanks for your review, Adrian.

Committed in rev. 662328

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Eric DE MAULDE

Re: SIPS : external credit card payment (Atos Origin)

In reply to this post by Eric DE MAULDE

Hi,

When I pay an order in my Web store with SIPS,
My order is auto-approved if the payment is validated, with the right party
;
but in Accounting (AR) - Show payments received : in the field "From party
ID"
there isn't a party ID, instead there is ",[_NA_]" !!!

And my Response Servlet creates a new session when the buyer comes backs
from the bank Web site to my Web store, is it right ?

Thanks

Eric

> Hi Jacques,
>
> Thanks for your help
>
> Here is my files tree :
>
> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
>
>
> parmcom.01429303911111 (full URLs to return and cancel page, auto response
> servlet ; currency, shop logo, payment means)
>
> certif..fr.
> 01429303911111- (binary)
>
> pathfile (credit
> card logo URL, full path to these files in this directory)
>
> parmcom.sips
> (display properties, accepted card list, buyer language code, bank logo,
> shop contry code, shop language code)
>
>
>
> /applications/accounting/lib/sips/apipayment.jar
>
>
>
> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including
> the path to "pathfile" ; first method "service")
> sipsResponseServlet.java (ditto)
> sipsAutoResponseServlet.java (ditto)Data :"insert into
> PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID,
> DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è
> Via /applications/accounting/data/AccountingTypeData.xml"insert into
> PAYMENT_METHOD_TYPE_GL_ACCOUNT
> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values
> ('EXT_SIPS', 'Company','122500')"è Via
> /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar"
> extension in/applications/accounting/ofbiz-component.xml+ translations+
> changes in /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> and web.xml+ changes in /applications/accounting/build.xml+ add images in
> /framework//images/webapp/images/sips/... .gif+ changes in ecommerce .ftl
> filesProblems :. Where can I save many different bank response codes (from
> my bank and AtosOrigin) ? From these codes, I manage payment validation..
> the API language codes have just 2 chars, how can I manage that ?Do you
> want me to send you files ?Eric> Keeping it in
> /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to
> me>> Have you any files outside of this directory ?>> Jacques>> From:
> "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA language
> and OFBiz.>> I succeeded to implement this payment in the accounting
> application.>> Now to share this development, how do I implement it in
> the"specialpurpose" directory ?>> Do I keep the same directory tree than
> in the accounting application, asfar as the "thirdparty" directory ?>> I
> already read the FAQ, do you have another article or documentation ?
> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.>
> >>>> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.4/1476 -
> >>>> ReleaseDate: 31/05/2008 12:25>>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.4/1476 - Release
> Date: 31/05/2008 12:25
>
>

Jacques Le Roux

Re: SIPS : external credit card payment (Atos Origin)

Administrator

In reply to this post by Eric DE MAULDE

Hi Eric,

When you firtst talk about this I did not realise that you were spoking about Atos's SPIPS. I have also used this toolkit in the
past but I wonder now if we are able to put that in OFBiz. I looked for information about its licence, but found nothing yet. In my
experience SIPS is brought to you by a bank which is the real party you exchange with. Have you more informations ?

Thanks

Jacques

From: "Eric DE MAULDE" <[hidden email]>

> Hi Jacques,
>
> Thanks for your help
>
> Here is my files tree :
>
> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
>
> parmcom.01429303911111 (full URLs to return and cancel page, auto
> response servlet ; currency, shop logo, payment means)
>
> certif..fr. 01429303911111- (binary)
>
> pathfile (credit card logo URL, full path to these files in this
> directory)
>
> parmcom.sips (display properties, accepted card list, buyer language
> code, bank logo, shop contry code, shop language code)
>
>
>
> /applications/accounting/lib/sips/apipayment.jar
>
>
>
> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including the path to "pathfile" ; first
> method "service")
> sipsResponseServlet.java (ditto)
> sipsAutoResponseServlet.java (ditto)Data :"insert into PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID,
> DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è Via
> /applications/accounting/data/AccountingTypeData.xml"insert into PAYMENT_METHOD_TYPE_GL_ACCOUNT
> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values ('EXT_SIPS', 'Company','122500')"è Via
> /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar" extension
> in/applications/accounting/ofbiz-component.xml+ translations+ changes in
> /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> and web.xml+ changes in /applications/accounting/build.xml+ add images in /framework//images/webapp/images/sips/... .gif+ changes
> in ecommerce .ftl filesProblems :. Where can I save many different bank response codes (from my bank and AtosOrigin) ? From these
> codes, I manage payment validation.. the API language codes have just 2 chars, how can I manage that ?Do you want me to send you
> files ?Eric> Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to me>> Have you any files
> outside of this directory ?>> Jacques>> From: "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA language and
> OFBiz.>> I succeeded to implement this payment in the accounting application.>> Now to share this development, how do I implement
> it in the"specialpurpose" directory ?>> Do I keep the same directory tree than in the accounting application, asfar as the
> "thirdparty" directory ?>> I already read the FAQ, do you have another article or documentation ?
> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.> Checked by AVG. Version: 7.5.524 / Virus Database:
> >>>> 269.24.4/1476 - ReleaseDate: 31/05/2008 12:25>>
>

Eric DE MAULDE

Re: SIPS : external credit card payment (Atos Origin)

Hi Jacques,

I sent again emails to Sherlock's office (Le Crédit Lyonnais) and SIPS
office (Atos Origin)
Yesterday, LCL replied me :
"Le service de sécurisation sur Internet Sherlock's commercialisé par LCL
et développé sur la base d'une solution SIPS personnalisée ne peut être
utilisé que par des commerçants LCL."
Translation : Sherlock's Web securing service (marketed by LCL and developed
with a customized SIPS system) just can be used by LCL merchants.

On the phone, Atos told me several renting Web shop companies implement
their system in standard. I think without the LCL certificate and logo,
because the SOCIETE GENERALE markets this system too.

For my part, I continue to improve my Sips implementation.
And I'm waiting an answer from Atos to get a permission as in another
renting Web shop.

Jacques, tell me if you want further informations ...

Eric

> Hi Eric,
>
> When you firtst talk about this I did not realise that you were spoking
> about Atos's SPIPS. I have also used this toolkit in the past but I wonder
> now if we are able to put that in OFBiz. I looked for information about
> its licence, but found nothing yet. In my experience SIPS is brought to
> you by a bank which is the real party you exchange with. Have you more
> informations ?
>
> Thanks
>
> Jacques
>
> From: "Eric DE MAULDE" <[hidden email]>
>> Hi Jacques,
>>
>> Thanks for your help
>>
>> Here is my files tree :
>>
>> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
>>
>>
>> parmcom.01429303911111 (full URLs to return and cancel page, auto
>> response servlet ; currency, shop logo, payment means)
>>
>> certif..fr.
>> 01429303911111- (binary)
>>
>> pathfile
>> (credit card logo URL, full path to these files in this directory)
>>
>> parmcom.sips
>> (display properties, accepted card list, buyer language code, bank logo,
>> shop contry code, shop language code)
>>
>>
>>
>> /applications/accounting/lib/sips/apipayment.jar
>>
>>
>>
>> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including
>> the path to "pathfile" ; first method "service") sipsResponseServlet.java
>> (ditto) sipsAutoResponseServlet.java (ditto)Data :"insert into
>> PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID,
>> DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips',
>> '122000')"è Via
>> /applications/accounting/data/AccountingTypeData.xml"insert into
>> PAYMENT_METHOD_TYPE_GL_ACCOUNT
>> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values
>> ('EXT_SIPS', 'Company','122500')"è Via
>> /applications/accounting/data/DemoGlSetupData.xml+ add directory and
>> "jar" extension in/applications/accounting/ofbiz-component.xml+
>> translations+ changes in
>> /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> and web.xml+ changes in /applications/accounting/build.xml+ add images in
>> /framework//images/webapp/images/sips/... .gif+ changes in ecommerce .ftl
>> filesProblems :. Where can I save many different bank response codes
>> (from my bank and AtosOrigin) ? From these codes, I manage payment
>> validation.. the API language codes have just 2 chars, how can I manage
>> that ?Do you want me to send you files ?Eric> Keeping it in
>> /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to
>> me>> Have you any files outside of this directory ?>> Jacques>> From:
>> "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA language
>> and OFBiz.>> I succeeded to implement this payment in the accounting
>> application.>> Now to share this development, how do I implement it in
>> the"specialpurpose" directory ?>> Do I keep the same directory tree than
>> in the accounting application, asfar as the "thirdparty" directory ?>> I
>> already read the FAQ, do you have another article or documentation ?
>> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.>
>> >>>> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.4/1476 -
>> >>>> ReleaseDate: 31/05/2008 12:25>>
>>
>
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.5/1479 - Release
> Date: 02/06/2008 19:02
>
>

Jacques Le Roux-2

Re: SIPS : external credit card payment (Atos Origin)

Hi Eric,

This is a rather old post (related to https://issues.apache.org/jira/browse/OFBIZ-2554) but I think it's worth to be revisited.
For instance see "our concurrents" in France
http://www.alatak.net/tutoriels-paiement-virtuemart-11/configuration-du-paiement-securise-sips-pour-joomla-15-et-virtuemart-11.html
http://www.magentocommerce.com/boards/viewthread/22044/P120/
http://extensions.joomla.org/extensions/extension-specific/virtuemart-extensions/virtuemart-payment-systems/2443

Did you get some news? Else I will apprecaite a little help from the French community in order to commit this in OFBiz following the
regular practices for this kind of stuff (payment method in store)

Thanks

Jacques

From: "Eric DE MAULDE" <[hidden email]>

> Hi Jacques,
>
> I sent again emails to Sherlock's office (Le Crédit Lyonnais) and SIPS office (Atos Origin)
> Yesterday, LCL replied me :
> "Le service de sécurisation sur Internet Sherlock's commercialisé par LCL et développé sur la base d'une solution SIPS
> personnalisée ne peut être utilisé que par des commerçants LCL."
> Translation : Sherlock's Web securing service (marketed by LCL and developed with a customized SIPS system) just can be used by
> LCL merchants.
>
> On the phone, Atos told me several renting Web shop companies implement their system in standard. I think without the LCL
> certificate and logo, because the SOCIETE GENERALE markets this system too.
>
> For my part, I continue to improve my Sips implementation.
> And I'm waiting an answer from Atos to get a permission as in another renting Web shop.
>
> Jacques, tell me if you want further informations ...
>
> Eric
>
>
>
>
>> Hi Eric,
>>
>> When you firtst talk about this I did not realise that you were spoking about Atos's SPIPS. I have also used this toolkit in the
>> past but I wonder now if we are able to put that in OFBiz. I looked for information about its licence, but found nothing yet. In
>> my experience SIPS is brought to you by a bank which is the real party you exchange with. Have you more informations ?
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Eric DE MAULDE" <[hidden email]>
>>> Hi Jacques,
>>>
>>> Thanks for your help
>>>
>>> Here is my files tree :
>>>
>>> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
>>>
>>>
>>> parmcom.01429303911111 (full URLs to return and cancel page, auto response servlet ; currency, shop logo, payment means)
>>>
>>> certif..fr. 01429303911111- (binary)
>>>
>>> pathfile (credit card logo URL, full path to these files in this
>>> directory)
>>>
>>> parmcom.sips (display properties, accepted card list, buyer language
>>> code, bank logo, shop contry code, shop language code)
>>>
>>>
>>>
>>> /applications/accounting/lib/sips/apipayment.jar
>>>
>>>
>>>
>>> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including the path to "pathfile" ; first
>>> method "service") sipsResponseServlet.java (ditto) sipsAutoResponseServlet.java (ditto)Data :"insert into
>>> PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID, DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è Via
>>> /applications/accounting/data/AccountingTypeData.xml"insert into PAYMENT_METHOD_TYPE_GL_ACCOUNT
>>> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values ('EXT_SIPS', 'Company','122500')"è Via
>>> /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar" extension
>>> in/applications/accounting/ofbiz-component.xml+ translations+ changes in
>>> /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>>> and web.xml+ changes in /applications/accounting/build.xml+ add images in /framework//images/webapp/images/sips/... .gif+
>>> changes in ecommerce .ftl filesProblems :. Where can I save many different bank response codes (from my bank and AtosOrigin) ?
>>> From these codes, I manage payment validation.. the API language codes have just 2 chars, how can I manage that ?Do you want me
>>> to send you files ?Eric> Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to me>> Have you
>>> any files outside of this directory ?>> Jacques>> From: "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA
>>> language and OFBiz.>> I succeeded to implement this payment in the accounting application.>> Now to share this development, how
>>> do I implement it in the"specialpurpose" directory ?>> Do I keep the same directory tree than in the accounting application,
>>> asfar as the "thirdparty" directory ?>> I already read the FAQ, do you have another article or documentation ?
>>> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.> Checked by AVG. Version: 7.5.524 / Virus Database:
>>> >>>> 269.24.4/1476 - ReleaseDate: 31/05/2008 12:25>>
>>>
>>
>>
>>
>>
>> --
>> No virus found in this incoming message.
>> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.5/1479 - Release Date: 02/06/2008 19:02
>>
>>
>

Eric DE MAULDE

Re: SIPS : external credit card payment (Atos Origin)

Hi Jacques,

I have created my own french firm with another bank CIC-Crédit Mutuel
Their on-line payment is managed by EURO-INFORMATION.

I have succeeded to implement their demo payment.
I will told you when my french website works well and my address.

SIPS and EURO-INFORMATION have the same integration.
I have keeped my SIPS integration.

I'm available to help you.

Eric

On Thu, 2011-01-20 at 16:25 +0100, Jacques Le Roux wrote:

> Hi Eric,
>
> This is a rather old post (related to https://issues.apache.org/jira/browse/OFBIZ-2554) but I think it's worth to be revisited.
> For instance see "our concurrents" in France
> http://www.alatak.net/tutoriels-paiement-virtuemart-11/configuration-du-paiement-securise-sips-pour-joomla-15-et-virtuemart-11.html
> http://www.magentocommerce.com/boards/viewthread/22044/P120/
> http://extensions.joomla.org/extensions/extension-specific/virtuemart-extensions/virtuemart-payment-systems/2443
>
> Did you get some news? Else I will apprecaite a little help from the French community in order to commit this in OFBiz following the
> regular practices for this kind of stuff (payment method in store)
>
> Thanks
>
> Jacques
>
> From: "Eric DE MAULDE" <[hidden email]>
> > Hi Jacques,
> >
> > I sent again emails to Sherlock's office (Le Crédit Lyonnais) and SIPS office (Atos Origin)
> > Yesterday, LCL replied me :
> > "Le service de sécurisation sur Internet Sherlock's commercialisé par LCL et développé sur la base d'une solution SIPS
> > personnalisée ne peut être utilisé que par des commerçants LCL."
> > Translation : Sherlock's Web securing service (marketed by LCL and developed with a customized SIPS system) just can be used by
> > LCL merchants.
> >
> > On the phone, Atos told me several renting Web shop companies implement their system in standard. I think without the LCL
> > certificate and logo, because the SOCIETE GENERALE markets this system too.
> >
> > For my part, I continue to improve my Sips implementation.
> > And I'm waiting an answer from Atos to get a permission as in another renting Web shop.
> >
> > Jacques, tell me if you want further informations ...
> >
> > Eric
> >
> >
> >
> >
> >> Hi Eric,
> >>
> >> When you firtst talk about this I did not realise that you were spoking about Atos's SPIPS. I have also used this toolkit in the
> >> past but I wonder now if we are able to put that in OFBiz. I looked for information about its licence, but found nothing yet. In
> >> my experience SIPS is brought to you by a bank which is the real party you exchange with. Have you more informations ?
> >>
> >> Thanks
> >>
> >> Jacques
> >>
> >> From: "Eric DE MAULDE" <[hidden email]>
> >>> Hi Jacques,
> >>>
> >>> Thanks for your help
> >>>
> >>> Here is my files tree :
> >>>
> >>> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
> >>>
> >>>
> >>> parmcom.01429303911111 (full URLs to return and cancel page, auto response servlet ; currency, shop logo, payment means)
> >>>
> >>> certif..fr. 01429303911111- (binary)
> >>>
> >>> pathfile (credit card logo URL, full path to these files in this
> >>> directory)
> >>>
> >>> parmcom.sips (display properties, accepted card list, buyer language
> >>> code, bank logo, shop contry code, shop language code)
> >>>
> >>>
> >>>
> >>> /applications/accounting/lib/sips/apipayment.jar
> >>>
> >>>
> >>>
> >>> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including the path to "pathfile" ; first
> >>> method "service") sipsResponseServlet.java (ditto) sipsAutoResponseServlet.java (ditto)Data :"insert into
> >>> PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID, DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è Via
> >>> /applications/accounting/data/AccountingTypeData.xml"insert into PAYMENT_METHOD_TYPE_GL_ACCOUNT
> >>> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values ('EXT_SIPS', 'Company','122500')"è Via
> >>> /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar" extension
> >>> in/applications/accounting/ofbiz-component.xml+ translations+ changes in
> >>> /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
> >>> and web.xml+ changes in /applications/accounting/build.xml+ add images in /framework//images/webapp/images/sips/... .gif+
> >>> changes in ecommerce .ftl filesProblems :. Where can I save many different bank response codes (from my bank and AtosOrigin) ?
> >>> From these codes, I manage payment validation.. the API language codes have just 2 chars, how can I manage that ?Do you want me
> >>> to send you files ?Eric> Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to me>> Have you
> >>> any files outside of this directory ?>> Jacques>> From: "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA
> >>> language and OFBiz.>> I succeeded to implement this payment in the accounting application.>> Now to share this development, how
> >>> do I implement it in the"specialpurpose" directory ?>> Do I keep the same directory tree than in the accounting application,
> >>> asfar as the "thirdparty" directory ?>> I already read the FAQ, do you have another article or documentation ?
> >>> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.> Checked by AVG. Version: 7.5.524 / Virus Database:
> >>> >>>> 269.24.4/1476 - ReleaseDate: 31/05/2008 12:25>>
> >>>
> >>
> >>
> >>
> >>
> >> --
> >> No virus found in this incoming message.
> >> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.5/1479 - Release Date: 02/06/2008 19:02
> >>
> >>
> >
>
>

Jacques Le Roux

Re: SIPS : external credit card payment (Atos Origin)

Administrator

From: "eric" <[hidden email]>

> Hi Jacques,
>
> I have created my own french firm with another bank CIC-Crédit Mutuel
> Their on-line payment is managed by EURO-INFORMATION.
>
> I have succeeded to implement their demo payment.
> I will told you when my french website works well and my address.
>
> SIPS and EURO-INFORMATION have the same integration.
> I have keeped my SIPS integration.
>
> I'm available to help you.
>
> Eric

Do you mean to create a patch? Else, as I already said in the Jira issue, I already implemented SIPS for a customer. That's not a
big deal if you don't follow OFBiz way (payment method in a store). That's what I'd be interested of. In other word my interest is
for the community not for my own needs... But I still wonder if SIPS can be embedded in OFBIz using payment method for 2 reasons:
technical (I remember the DLL on Windows for SIPS) and especially license at the SIPS level (since as you said there are companies
which bizness is to integrate SIPS for clients...)

Thanks

Jacques

>
> On Thu, 2011-01-20 at 16:25 +0100, Jacques Le Roux wrote:
>
>> Hi Eric,
>>
>> This is a rather old post (related to https://issues.apache.org/jira/browse/OFBIZ-2554) but I think it's worth to be revisited.
>> For instance see "our concurrents" in France
>> http://www.alatak.net/tutoriels-paiement-virtuemart-11/configuration-du-paiement-securise-sips-pour-joomla-15-et-virtuemart-11.html
>> http://www.magentocommerce.com/boards/viewthread/22044/P120/
>> http://extensions.joomla.org/extensions/extension-specific/virtuemart-extensions/virtuemart-payment-systems/2443
>>
>> Did you get some news? Else I will apprecaite a little help from the French community in order to commit this in OFBiz following
>> the
>> regular practices for this kind of stuff (payment method in store)
>>
>> Thanks
>>
>> Jacques
>>
>> From: "Eric DE MAULDE" <[hidden email]>
>> > Hi Jacques,
>> >
>> > I sent again emails to Sherlock's office (Le Crédit Lyonnais) and SIPS office (Atos Origin)
>> > Yesterday, LCL replied me :
>> > "Le service de sécurisation sur Internet Sherlock's commercialisé par LCL et développé sur la base d'une solution SIPS
>> > personnalisée ne peut être utilisé que par des commerçants LCL."
>> > Translation : Sherlock's Web securing service (marketed by LCL and developed with a customized SIPS system) just can be used by
>> > LCL merchants.
>> >
>> > On the phone, Atos told me several renting Web shop companies implement their system in standard. I think without the LCL
>> > certificate and logo, because the SOCIETE GENERALE markets this system too.
>> >
>> > For my part, I continue to improve my Sips implementation.
>> > And I'm waiting an answer from Atos to get a permission as in another renting Web shop.
>> >
>> > Jacques, tell me if you want further informations ...
>> >
>> > Eric
>> >
>> >
>> >
>> >
>> >> Hi Eric,
>> >>
>> >> When you firtst talk about this I did not realise that you were spoking about Atos's SPIPS. I have also used this toolkit in
>> >> the
>> >> past but I wonder now if we are able to put that in OFBiz. I looked for information about its licence, but found nothing yet.
>> >> In
>> >> my experience SIPS is brought to you by a bank which is the real party you exchange with. Have you more informations ?
>> >>
>> >> Thanks
>> >>
>> >> Jacques
>> >>
>> >> From: "Eric DE MAULDE" <[hidden email]>
>> >>> Hi Jacques,
>> >>>
>> >>> Thanks for your help
>> >>>
>> >>> Here is my files tree :
>> >>>
>> >>> /applications/accounting/config/sips/certif.fr.01429303911111 (binary)
>> >>>
>> >>>
>> >>> parmcom.01429303911111 (full URLs to return and cancel page, auto response servlet ; currency, shop logo, payment means)
>> >>>
>> >>> certif..fr. 01429303911111- (binary)
>> >>>
>> >>> pathfile (credit card logo URL, full path to these files in this
>> >>> directory)
>> >>>
>> >>> parmcom.sips (display properties, accepted card list, buyer
>> >>> language
>> >>> code, bank logo, shop contry code, shop language code)
>> >>>
>> >>>
>> >>>
>> >>> /applications/accounting/lib/sips/apipayment.jar
>> >>>
>> >>>
>> >>>
>> >>> /applications/accounting/src/org/accounting/thirdparty/sips/sipsRequestServlet.java(including the path to "pathfile" ; first
>> >>> method "service") sipsResponseServlet.java (ditto) sipsAutoResponseServlet.java (ditto)Data :"insert into
>> >>> PAYMENT_METHOD_TYPE (PAYMENT_METHOD_TYPE_ID, DESCRIPTION,DEFAULT_GL_ACCOUNT_ID) values ('EXT_SIPS', 'Sips', '122000')"è Via
>> >>> /applications/accounting/data/AccountingTypeData.xml"insert into PAYMENT_METHOD_TYPE_GL_ACCOUNT
>> >>> (PAYMENT_METHOD_TYPE_ID,ORGANIZATION_PARTY_ID, GL_ACCOUNT_ID) values ('EXT_SIPS', 'Company','122500')"è Via
>> >>> /applications/accounting/data/DemoGlSetupData.xml+ add directory and "jar" extension
>> >>> in/applications/accounting/ofbiz-component.xml+ translations+ changes in
>> >>> /applications/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
>> >>> and web.xml+ changes in /applications/accounting/build.xml+ add images in /framework//images/webapp/images/sips/... .gif+
>> >>> changes in ecommerce .ftl filesProblems :. Where can I save many different bank response codes (from my bank and AtosOrigin)
>> >>> ?
>> >>> From these codes, I manage payment validation.. the API language codes have just 2 chars, how can I manage that ?Do you want
>> >>> me
>> >>> to send you files ?Eric> Keeping it in /applications/accounting/src/org/ofbiz/accounting/thirdpartyseems fine to me>> Have
>> >>> you
>> >>> any files outside of this directory ?>> Jacques>> From: "Eric DE MAULDE" <[hidden email]>>> Hi,>>>> I begin in the JAVA
>> >>> language and OFBiz.>> I succeeded to implement this payment in the accounting application.>> Now to share this development,
>> >>> how
>> >>> do I implement it in the"specialpurpose" directory ?>> Do I keep the same directory tree than in the accounting application,
>> >>> asfar as the "thirdparty" directory ?>> I already read the FAQ, do you have another article or documentation ?
>> >>> >>>> Thanks>>>> Eric>>>> --> No virus found in this incoming message.> Checked by AVG. Version: 7.5.524 / Virus Database:
>> >>> >>>> 269.24.4/1476 - ReleaseDate: 31/05/2008 12:25>>
>> >>>
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> No virus found in this incoming message.
>> >> Checked by AVG. Version: 7.5.524 / Virus Database: 269.24.5/1479 - Release Date: 02/06/2008 19:02
>> >>
>> >>
>> >
>>
>>
>
>
>