[jira] Created: (OFBIZ-1826) Allow EntityListIterator to be created from JDBC ResultSet

[Nicolas Malin (Jira)]

Allow EntityListIterator to be created from JDBC ResultSet
----------------------------------------------------------

                 Key: OFBIZ-1826
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1826
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Si Chen
            Priority: Minor


EntitylistIterator can only be constructed from a SQLProcessor  right now, but in fact, it does not really use the SQLProcessor except to .close().  I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet.  When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor.  Otherwise, it will call the ResultSet's close method.

This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator.

Please take a look at this.  If nobody opposes it, I will commit it next week

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen updated OFBIZ-1826:
---------------------------

    Attachment: ofbiz-1826.patch

> Allow EntityListIterator to be created from JDBC ResultSet
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1826
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1826.patch
>
>
> EntitylistIterator can only be constructed from a SQLProcessor  right now, but in fact, it does not really use the SQLProcessor except to .close().  I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet.  When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor.  Otherwise, it will call the ResultSet's close method.
> This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator.
> Please take a look at this.  If nobody opposes it, I will commit it next week

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603236#action_12603236 ]

Si Chen commented on OFBIZ-1826:
--------------------------------

by the way, I have apply this patch and rerun all the entity unit tests, and they passed

> Allow EntityListIterator to be created from JDBC ResultSet
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1826
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1826.patch
>
>
> EntitylistIterator can only be constructed from a SQLProcessor  right now, but in fact, it does not really use the SQLProcessor except to .close().  I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet.  When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor.  Otherwise, it will call the ResultSet's close method.
> This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator.
> Please take a look at this.  If nobody opposes it, I will commit it next week

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-1826.
--------------------------

    Resolution: Fixed

> Allow EntityListIterator to be created from JDBC ResultSet
> ----------------------------------------------------------
>
>                 Key: OFBIZ-1826
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1826
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Si Chen
>            Priority: Minor
>         Attachments: ofbiz-1826.patch
>
>
> EntitylistIterator can only be constructed from a SQLProcessor  right now, but in fact, it does not really use the SQLProcessor except to .close().  I have created a new constructor for the EntityListIterator which allows it to be created from a JDBC ResultSet.  When it comes to closing the list iterator, the behavior is the same as before, if there is a SQLProcessor.  Otherwise, it will call the ResultSet's close method.
> This would not affect anybody who is already using the delegator, but it would make it more flexible for people who are not using the delegator.
> Please take a look at this.  If nobody opposes it, I will commit it next week

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.